diff options
author | Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> | 2019-12-20 12:12:35 +0100 |
---|---|---|
committer | Tomaž Vajngerl <quikee@gmail.com> | 2019-12-29 17:00:30 +0100 |
commit | 50f13bbedf0bba0509b7bf98bc782ec821c7777b (patch) | |
tree | 075561038379e173ea04f626accb0ee00f2d255c | |
parent | 22db41d4078f56d03905efbc71c16c322b2df091 (diff) |
acc. check: add "goto" button to see the acc. issue in document
This adds the UI for the goto functionality to the UI, but
currently no goto implementation to jump to the specific issue
area in the document is written.
Change-Id: I5b326a000e62231c491c179b1ff8accde15e1e98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85920
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
-rw-r--r-- | include/svx/AccessibilityCheckDialog.hxx | 3 | ||||
-rw-r--r-- | include/svx/AccessibilityIssue.hxx | 1 | ||||
-rw-r--r-- | svx/source/dialog/AccessibilityCheckDialog.cxx | 7 | ||||
-rw-r--r-- | svx/uiconfig/ui/accessibilitycheckentry.ui | 14 | ||||
-rw-r--r-- | sw/source/core/inc/AccessibilityIssue.hxx | 1 |
5 files changed, 25 insertions, 1 deletions
diff --git a/include/svx/AccessibilityCheckDialog.hxx b/include/svx/AccessibilityCheckDialog.hxx index d1cb2b8e20ab..0656abe1593d 100644 --- a/include/svx/AccessibilityCheckDialog.hxx +++ b/include/svx/AccessibilityCheckDialog.hxx @@ -26,6 +26,7 @@ private: std::unique_ptr<weld::Builder> m_xBuilder; std::unique_ptr<weld::Container> m_xContainer; std::unique_ptr<weld::Label> m_xLabel; + std::unique_ptr<weld::Button> m_xGotoButton; std::shared_ptr<AccessibilityIssue> const& m_pAccessibilityIssue; @@ -34,6 +35,8 @@ public: std::shared_ptr<AccessibilityIssue> const& pAccessibilityIssue); weld::Widget* get_widget() const { return m_xContainer.get(); } + + DECL_LINK(GotoButtonClicked, weld::Button&, void); }; class SVX_DLLPUBLIC AccessibilityCheckDialog final : public weld::GenericDialogController diff --git a/include/svx/AccessibilityIssue.hxx b/include/svx/AccessibilityIssue.hxx index 1f5089d97064..b0508f5801b9 100644 --- a/include/svx/AccessibilityIssue.hxx +++ b/include/svx/AccessibilityIssue.hxx @@ -31,6 +31,7 @@ public: { } virtual ~AccessibilityIssue() {} + virtual void gotoIssue() const = 0; AccessibilityIssueID m_eIssueID; OUString m_aIssueText; diff --git a/svx/source/dialog/AccessibilityCheckDialog.cxx b/svx/source/dialog/AccessibilityCheckDialog.cxx index 5459cb5ea5f5..af96c09295d5 100644 --- a/svx/source/dialog/AccessibilityCheckDialog.cxx +++ b/svx/source/dialog/AccessibilityCheckDialog.cxx @@ -19,12 +19,19 @@ AccessibilityCheckEntry::AccessibilityCheckEntry( : m_xBuilder(Application::CreateBuilder(pParent, "svx/ui/accessibilitycheckentry.ui")) , m_xContainer(m_xBuilder->weld_container("accessibilityCheckEntryBox")) , m_xLabel(m_xBuilder->weld_label("accessibilityCheckEntryLabel")) + , m_xGotoButton(m_xBuilder->weld_button("accessibilityCheckEntryGotoButton")) , m_pAccessibilityIssue(rAccessibilityIssue) { m_xLabel->set_label(m_pAccessibilityIssue->m_aIssueText); + m_xGotoButton->connect_clicked(LINK(this, AccessibilityCheckEntry, GotoButtonClicked)); m_xContainer->show(); } +IMPL_LINK_NOARG(AccessibilityCheckEntry, GotoButtonClicked, weld::Button&, void) +{ + m_pAccessibilityIssue->gotoIssue(); +} + AccessibilityCheckDialog::AccessibilityCheckDialog( weld::Window* pParent, AccessibilityIssueCollection const& rIssueCollection) : GenericDialogController(pParent, "svx/ui/accessibilitycheckdialog.ui", diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui b/svx/uiconfig/ui/accessibilitycheckentry.ui index bfd013491e51..4a4633eb3f14 100644 --- a/svx/uiconfig/ui/accessibilitycheckentry.ui +++ b/svx/uiconfig/ui/accessibilitycheckentry.ui @@ -10,7 +10,9 @@ <object class="GtkLabel" id="accessibilityCheckEntryLabel"> <property name="visible">True</property> <property name="can_focus">False</property> + <property name="hexpand">True</property> <property name="selectable">True</property> + <property name="xalign">0</property> </object> <packing> <property name="expand">False</property> @@ -19,7 +21,17 @@ </packing> </child> <child> - <placeholder/> + <object class="GtkButton" id="accessibilityCheckEntryGotoButton"> + <property name="label" translatable="yes" context="accessibilitycheckentry|accessibilityCheckEntryGotoButton">Goto Issue</property> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">1</property> + </packing> </child> </object> </interface> diff --git a/sw/source/core/inc/AccessibilityIssue.hxx b/sw/source/core/inc/AccessibilityIssue.hxx index c0eaf73b1df6..afb5b57d6170 100644 --- a/sw/source/core/inc/AccessibilityIssue.hxx +++ b/sw/source/core/inc/AccessibilityIssue.hxx @@ -22,6 +22,7 @@ public: : svx::AccessibilityIssue(eIssueID) { } + void gotoIssue() const override {} }; } // end sw namespace |