diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-18 15:55:55 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-22 08:13:56 +0200 |
commit | 6921cde3917dcb4f420b50823394f84c3c8348c9 (patch) | |
tree | 0ac183e0c7231b9e86f37f281f7f08a2f6f8348e | |
parent | db90e072fa0d0fe6514361cc50273aaa47563478 (diff) |
loplugin:virtualdead unused param in ChartTypeDialogController
Change-Id: I71eaedcd2fbd5b6d05bc90c4c5ddbc7fca9f5925
Reviewed-on: https://gerrit.libreoffice.org/81271
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 files changed, 7 insertions, 13 deletions
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx index eeebd989e5ed..bbe3c1fd82d5 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx @@ -358,8 +358,7 @@ void ChartTypeDialogController::showExtraControls(weld::Builder* /*pBuilder*/) void ChartTypeDialogController::hideExtraControls() const { } -void ChartTypeDialogController::fillExtraControls( const ChartTypeParameter& /*rParameter*/ - , const uno::Reference< XChartDocument >& /*xChartModel*/ +void ChartTypeDialogController::fillExtraControls( const uno::Reference< XChartDocument >& /*xChartModel*/ , const uno::Reference< beans::XPropertySet >& /*xTemplateProps*/ ) const { } @@ -1147,8 +1146,8 @@ void CombiColumnLineChartDialogController::hideExtraControls() const m_xMF_NumberOfLines->hide(); } -void CombiColumnLineChartDialogController::fillExtraControls( const ChartTypeParameter& /*rParameter*/ - , const uno::Reference< XChartDocument >& xChartModel +void CombiColumnLineChartDialogController::fillExtraControls( + const uno::Reference< XChartDocument >& xChartModel , const uno::Reference< beans::XPropertySet >& xTemplateProps ) const { if (!m_xMF_NumberOfLines) diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx index e655394c1da3..35953980578d 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx @@ -102,8 +102,7 @@ public: virtual void showExtraControls(weld::Builder* pBuilder); virtual void hideExtraControls() const; - virtual void fillExtraControls( const ChartTypeParameter& rParameter - , const css::uno::Reference< css::chart2::XChartDocument >& xChartModel + virtual void fillExtraControls( const css::uno::Reference< css::chart2::XChartDocument >& xChartModel , const css::uno::Reference< css::beans::XPropertySet >& xTemplateProps ) const; /// @throws css::uno::RuntimeException virtual void setTemplateProperties( const css::uno::Reference< css::beans::XPropertySet >& xTemplateProps ) const; @@ -267,8 +266,7 @@ public: virtual void showExtraControls(weld::Builder* pBuilder) override; virtual void hideExtraControls() const override; - virtual void fillExtraControls( const ChartTypeParameter& rParameter - , const css::uno::Reference< css::chart2::XChartDocument >& xChartModel + virtual void fillExtraControls( const css::uno::Reference< css::chart2::XChartDocument >& xChartModel , const css::uno::Reference< css::beans::XPropertySet >& xTemplateProps ) const override; virtual void setTemplateProperties( const css::uno::Reference< css::beans::XPropertySet >& xTemplateProps ) const override; diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index f2d9e1e22b31..f46192b5a880 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -818,7 +818,7 @@ void ChartTypeTabPage::selectMainType() fillAllControls( aParameter ); uno::Reference< beans::XPropertySet > xTemplateProps( getCurrentTemplate(), uno::UNO_QUERY ); - m_pCurrentMainType->fillExtraControls(aParameter,m_xChartModel,xTemplateProps); + m_pCurrentMainType->fillExtraControls(m_xChartModel,xTemplateProps); } } @@ -898,7 +898,7 @@ void ChartTypeTabPage::initializePage() fillAllControls( aParameter ); if( m_pCurrentMainType ) - m_pCurrentMainType->fillExtraControls(aParameter,m_xChartModel,xTemplateProps); + m_pCurrentMainType->fillExtraControls(m_xChartModel,xTemplateProps); break; } ++nM; diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results index fda3eaf9f698..6a050a13ffcb 100644 --- a/compilerplugins/clang/virtualdead.unusedparams.results +++ b/compilerplugins/clang/virtualdead.unusedparams.results @@ -34,9 +34,6 @@ basic/source/comp/codegen.cxx:467 chart2/source/controller/dialogs/ChangingResource.hxx:30 void chart::ResourceChangeListener::stateChanged(class chart::ChangingResource *,) 0 -chart2/source/controller/dialogs/ChartTypeDialogController.hxx:105 - void chart::ChartTypeDialogController::fillExtraControls(const class chart::ChartTypeParameter &,const class com::sun::star::uno::Reference<class com::sun::star::chart2::XChartDocument> &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySet> &,)const - 011 desktop/source/deployment/registry/inc/dp_backend.h:84 void dp_registry::backend::Package::processPackage_(class osl::ResettableGuard<class osl::Mutex> &,_Bool,_Bool,const class rtl::Reference<class dp_misc::AbortChannel> &,const class com::sun::star::uno::Reference<class com::sun::star::ucb::XCommandEnvironment> &,) 01111 |