loplugin:virtualdead

Change-Id: Idcaaecd5be080e43b731f8edcbbfb8aed5e2e28c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97048
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 93 insertions, 52 deletions

diff --git a/compilerplugins/clang/virtualdead.results b/compilerplugins/clang/virtualdead.results
index 9a39282eff04..831d23c4d24f 100644
--- a/compilerplugins/clang/virtualdead.results
+++ b/compilerplugins/clang/virtualdead.results
@@ -28,7 +28,7 @@ canvas/inc/base/graphicdevicebase.hxx:318
 desktop/source/deployment/registry/inc/dp_backenddb.hxx:120
     class rtl::OUString dp_registry::backend::BackendDb::getDbNSName()
     "http://openoffi
-include/basegfx/utils/unopolypolygon.hxx:97
+include/basegfx/utils/unopolypolygon.hxx:94
     void basegfx::unotools::UnoPolyPolygon::modifying()const
     empty
 include/connectivity/sdbcx/IRefreshable.hxx:31
@@ -61,18 +61,30 @@ include/ucbhelper/resultset.hxx:411
 include/unotools/desktopterminationobserver.hxx:36
     _Bool utl::ITerminationListener::queryTermination()const
     1
-include/vbahelper/vbahelperinterface.hxx:77
+include/vbahelper/vbahelperinterface.hxx:74
     int InheritedHelperInterfaceImpl::getCreator()
     1400204879
-include/vcl/treelistbox.hxx:458
-    _Bool SvTreeListBox::NotifyAcceptDrop(class SvTreeListEntry *,)
+QtGui/qaccessible.h:466
+    class QObject * QAccessibleInterface::object()const
+    0
+QtGui/qaccessible.h:467
+    class QWindow * QAccessibleInterface::window()const
+    0
+QtGui/qaccessible.h:479
+    int QAccessibleInterface::indexOfChild(const class QAccessibleInterface *,)const
+    0
+QtGui/qaccessible.h:483
+    void QAccessibleInterface::setText(enum QAccessible::Text,const class QString &,)
+    empty
+QtGui/qaccessible.h:613
+    _Bool QAccessibleTableInterface::isColumnSelected(int,)const
     1
-include/vcl/treelistbox.hxx:493
-    class rtl::OUString SvTreeListBox::GetEntryAltText(class SvTreeListEntry *,)const
-    ""
-include/vcl/treelistbox.hxx:494
-    class rtl::OUString SvTreeListBox::GetEntryLongDescription(class SvTreeListEntry *,)const
-    ""
+QtGui/qaccessible.h:614
+    _Bool QAccessibleTableInterface::isRowSelected(int,)const
+    1
+QtGui/qaccessible.h:620
+    void QAccessibleTableInterface::modelChange(class QAccessibleTableModelChangeEvent *,)
+    empty
 sc/source/core/opencl/formulagroupcl.cxx:1069
     void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
     empty
@@ -82,10 +94,10 @@ sc/source/core/opencl/opbase.hxx:203
 sc/source/ui/vba/vbasheetobject.hxx:117
     class rtl::OUString ScVbaSheetObjectBase::implGetBaseName()const
     "Button"
-sc/source/ui/vba/vbasheetobjects.cxx:141
+sc/source/ui/vba/vbasheetobjects.cxx:142
     class rtl::OUString ScVbaObjectContainer::implGetShapeServiceName()const
     "com.sun.star.drawing.ControlShape"
-slideshow/source/engine/animationfactory.cxx:437
+slideshow/source/engine/animationfactory.cxx:434
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
     empty
 vcl/inc/qt5/Qt5FilePicker.hxx:172
@@ -100,9 +112,6 @@ vcl/inc/salframe.hxx:147
 vcl/inc/salframe.hxx:204
     _Bool SalFrame::MapUnicodeToKeyCode(char16_t,struct o3tl::strong_int<unsigned short, struct LanguageTypeTag>,class vcl::KeyCode &,)
     0
-vcl/inc/salframe.hxx:264
-    void SalFrame::BeginSheet(class SalFrame *,)const
-    empty
 vcl/inc/salgdiimpl.hxx:119
     _Bool SalGraphicsImpl::drawPolyLineBezier(unsigned int,const struct SalPoint *,const enum PolyFlags *,)
     0
@@ -115,10 +124,10 @@ vcl/inc/salgdiimpl.hxx:129
 vcl/inc/salgdiimpl.hxx:170
     _Bool SalGraphicsImpl::drawEPS(long,long,long,long,void *,unsigned int,)
     0
-vcl/inc/salinst.hxx:92
+vcl/inc/salinst.hxx:93
     _Bool SalInstance::SVMainHook(int *,)
     0
-vcl/inc/salinst.hxx:202
+vcl/inc/salinst.hxx:203
     void SalInstance::releaseMainThread()
     empty
 vcl/inc/salmenu.hxx:77
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index a3ba798e4f22..a4e3bbc5ff5d 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -64,7 +64,7 @@ extensions/source/bibliography/loadlisteneradapter.hxx:111
 include/cppuhelper/propshlp.hxx:326
     void cppu::IEventNotificationHook::fireEvents(int *,int,unsigned char,_Bool,)
     0111
-include/drawinglayer/primitive2d/textbreakuphelper.hxx:60
+include/drawinglayer/primitive2d/textbreakuphelper.hxx:58
     _Bool drawinglayer::primitive2d::TextBreakupHelper::allowChange(unsigned int,class basegfx::B2DHomMatrix &,unsigned int,unsigned int,)
     0111
 include/editeng/editeng.hxx:484
@@ -127,17 +127,65 @@ include/vcl/dndhelp.hxx:72
 include/vcl/opengl/OpenGLContext.hxx:141
     struct SystemWindowData OpenGLContext::generateWinData(class vcl::Window *,_Bool,)
     10
-include/vcl/treelistbox.hxx:455
+include/vcl/treelistbox.hxx:466
     enum DragDropMode SvTreeListBox::NotifyStartDrag(class TransferDataContainer &,class SvTreeListEntry *,)
-    01
-include/vcl/treelistbox.hxx:458
-    _Bool SvTreeListBox::NotifyAcceptDrop(class SvTreeListEntry *,)
+    00
+include/vcl/treelistbox.hxx:715
+    void SvTreeListBox::ExecuteContextMenuAction(unsigned short,)
     0
-include/vcl/treelistbox.hxx:493
-    class rtl::OUString SvTreeListBox::GetEntryAltText(class SvTreeListEntry *,)const
+QtCore/qmimedata.h:88
+    class QVariant QMimeData::retrieveData(const class QString &,enum QVariant::Type,)const
+    10
+QtGui/qaccessible.h:479
+    int QAccessibleInterface::indexOfChild(const class QAccessibleInterface *,)const
+    0
+QtGui/qaccessible.h:483
+    void QAccessibleInterface::setText(enum QAccessible::Text,const class QString &,)
+    00
+QtGui/qaccessible.h:528
+    void QAccessibleTextInterface::addSelection(int,int,)
+    00
+QtGui/qaccessible.h:529
+    void QAccessibleTextInterface::removeSelection(int,)
     0
-include/vcl/treelistbox.hxx:494
-    class rtl::OUString SvTreeListBox::GetEntryLongDescription(class SvTreeListEntry *,)const
+QtGui/qaccessible.h:530
+    void QAccessibleTextInterface::setSelection(int,int,int,)
+    011
+QtGui/qaccessible.h:538
+    class QString QAccessibleTextInterface::textBeforeOffset(int,enum QAccessible::TextBoundaryType,int *,int *,)const
+    0000
+QtGui/qaccessible.h:540
+    class QString QAccessibleTextInterface::textAfterOffset(int,enum QAccessible::TextBoundaryType,int *,int *,)const
+    0000
+QtGui/qaccessible.h:542
+    class QString QAccessibleTextInterface::textAtOffset(int,enum QAccessible::TextBoundaryType,int *,int *,)const
+    0000
+QtGui/qaccessible.h:547
+    class QRect QAccessibleTextInterface::characterRect(int,)const
+    0
+QtGui/qaccessible.h:548
+    int QAccessibleTextInterface::offsetAtPoint(const class QPoint &,)const
+    0
+QtGui/qaccessible.h:613
+    _Bool QAccessibleTableInterface::isColumnSelected(int,)const
+    0
+QtGui/qaccessible.h:614
+    _Bool QAccessibleTableInterface::isRowSelected(int,)const
+    0
+QtGui/qaccessible.h:620
+    void QAccessibleTableInterface::modelChange(class QAccessibleTableModelChangeEvent *,)
+    0
+QtWidgets/qwidget.h:629
+    void QWidget::focusInEvent(class QFocusEvent *,)
+    0
+QtWidgets/qwidget.h:630
+    void QWidget::focusOutEvent(class QFocusEvent *,)
+    0
+QtWidgets/qwidget.h:650
+    void QWidget::dragLeaveEvent(class QDragLeaveEvent *,)
+    0
+QtWidgets/qwidget.h:654
+    void QWidget::showEvent(class QShowEvent *,)
     0
 sc/inc/filter.hxx:82
     void ScFormatFilterPlugin::ScExportHTML(class SvStream &,const class rtl::OUString &,class ScDocument *,const class ScRange &,const unsigned short,_Bool,const class rtl::OUString &,class rtl::OUString &,const class rtl::OUString &,)
@@ -151,13 +199,13 @@ sc/inc/formulagroup.hxx:145
 sc/source/core/opencl/formulagroupcl.cxx:1069
     void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
     0
-sdext/source/pdfimport/inc/contentsink.hxx:150
+sdext/source/pdfimport/inc/contentsink.hxx:151
     void pdfi::ContentSink::drawMask(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,_Bool,)
     10
-sdext/source/pdfimport/inc/contentsink.hxx:160
+sdext/source/pdfimport/inc/contentsink.hxx:161
     void pdfi::ContentSink::drawColorMaskedImage(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,const class com::sun::star::uno::Sequence<class com::sun::star::uno::Any> &,)
     10
-sdext/source/pdfimport/inc/contentsink.hxx:164
+sdext/source/pdfimport/inc/contentsink.hxx:165
     void pdfi::ContentSink::drawMaskedImage(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,_Bool,)
     110
 sdext/source/pdfimport/inc/treevisiting.hxx:46
@@ -184,7 +232,7 @@ sdext/source/presenter/PresenterScrollBar.hxx:177
 sdext/source/presenter/PresenterScrollBar.hxx:179
     double sdext::presenter::PresenterScrollBar::GetMinor(const double,const double,)const
     10
-starmath/source/wordexportbase.hxx:37
+starmath/source/wordexportbase.hxx:38
     void SmWordExportBase::HandleText(const class SmNode *,int,)
     10
 sw/inc/calbck.hxx:144
@@ -199,10 +247,10 @@ sw/source/core/access/acccontext.hxx:352
 sw/source/core/inc/txmsrt.hxx:145
     void SwTOXSortTabBase::FillText(class SwTextNode &,const class SwIndex &,unsigned short,const class SwRootFrame *const,)const
     1100
-sw/source/filter/ww8/wrtww8.hxx:799
+sw/source/filter/ww8/wrtww8.hxx:797
     void MSWordExportBase::WriteHyperlinkData(const class sw::mark::IFieldmark &,)
     0
-sw/source/filter/ww8/wrtww8.hxx:864
+sw/source/filter/ww8/wrtww8.hxx:862
     void MSWordExportBase::OutputGrfNode(const class SwGrfNode &,)
     0
 vcl/inc/outdev.h:122
@@ -220,9 +268,6 @@ vcl/inc/salframe.hxx:204
 vcl/inc/salframe.hxx:247
     void SalFrame::BeginSetClipRegion(unsigned int,)
     0
-vcl/inc/salframe.hxx:264
-    void SalFrame::BeginSheet(class SalFrame *,)const
-    0
 vcl/inc/salgdiimpl.hxx:81
     void SalGraphicsImpl::SetXORMode(_Bool,_Bool,)
     10
@@ -241,13 +286,13 @@ vcl/inc/salgdiimpl.hxx:136
 vcl/inc/salgdiimpl.hxx:170
     _Bool SalGraphicsImpl::drawEPS(long,long,long,long,void *,unsigned int,)
     000000
-vcl/inc/salinst.hxx:92
+vcl/inc/salinst.hxx:93
     _Bool SalInstance::SVMainHook(int *,)
     0
-vcl/inc/salinst.hxx:125
+vcl/inc/salinst.hxx:126
     void SalInstance::GetPrinterQueueState(struct SalPrinterQueueInfo *,)
     0
-vcl/inc/salinst.hxx:185
+vcl/inc/salinst.hxx:186
     void SalInstance::AddToRecentDocumentList(const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &,)
     100
 vcl/inc/salmenu.hxx:71
diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx b/dbaccess/source/ui/control/dbtreelistbox.cxx
index 549a27c392e7..4fbb3485e263 100644
--- a/dbaccess/source/ui/control/dbtreelistbox.cxx
+++ b/dbaccess/source/ui/control/dbtreelistbox.cxx
@@ -551,10 +551,6 @@ VclPtr<PopupMenu> DBTreeListBox::CreateContextMenu()
     return pContextMenu;
 }
 
-void DBTreeListBox::ExecuteContextMenuAction( sal_uInt16 )
-{
-}
-
 IMPL_LINK( DBTreeListBox, MenuEventListener, VclMenuEvent&, rMenuEvent, void )
 {
     if ( rMenuEvent.GetId() == VclEventId::ObjectDying )
diff --git a/dbaccess/source/ui/inc/dbtreelistbox.hxx b/dbaccess/source/ui/inc/dbtreelistbox.hxx
index c1678108f1e5..f79abe8f5df7 100644
--- a/dbaccess/source/ui/inc/dbtreelistbox.hxx
+++ b/dbaccess/source/ui/inc/dbtreelistbox.hxx
@@ -109,7 +109,6 @@ namespace dbaui
         virtual bool    DoubleClickHdl() override;
 
         virtual VclPtr<PopupMenu> CreateContextMenu() override;
-        virtual void    ExecuteContextMenuAction( sal_uInt16 nSelectedPopupEntry ) override;
 
         void            SetEnterKeyHdl(const Link<DBTreeListBox*,void>& rNewHdl) {m_aEnterKeyHdl = rNewHdl;}
 
diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx
index 202df1206a19..41af57b75097 100644
--- a/include/vcl/treelistbox.hxx
+++ b/include/vcl/treelistbox.hxx
@@ -710,7 +710,6 @@ public:
     void            ShowFocusRect( const SvTreeListEntry* pEntry );
 
     virtual VclPtr<PopupMenu> CreateContextMenu();
-    virtual void    ExecuteContextMenuAction( sal_uInt16 nSelectedPopupEntry );
 
     void            EnableContextMenuHandling();
 
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index bf54f1dcc7ae..ce9cfeff5679 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -2950,9 +2950,7 @@ void SvImpLBox::Command( const CommandEvent& rCEvt )
             if (pPopup)
             {
                 // do action for selected entry in popup menu
-                sal_uInt16 nMenuAction = pPopup->Execute( m_pView, aPopupPos );
-                if ( nMenuAction )
-                    m_pView->ExecuteContextMenuAction( nMenuAction );
+                pPopup->Execute( m_pView, aPopupPos );
                 pPopup.disposeAndClear();
             }
         }
diff --git a/vcl/source/treelist/treelistbox.cxx b/vcl/source/treelist/treelistbox.cxx
index f52f1c86232b..f8a196ef29b4 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -3499,11 +3499,6 @@ VclPtr<PopupMenu> SvTreeListBox::CreateContextMenu()
     return nullptr;
 }
 
-void SvTreeListBox::ExecuteContextMenuAction( sal_uInt16 )
-{
-    SAL_INFO( "svtools.contnr", "SvTreeListBox::ExecuteContextMenuAction(): now there's happening nothing!" );
-}
-
 void SvTreeListBox::EnableContextMenuHandling()
 {
     assert(pImpl && "-SvTreeListBox::EnableContextMenuHandling(): No implementation!");