summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2018-11-10 12:51:57 +0300
committerMike Kaganski <mike.kaganski@collabora.com>2018-11-10 12:23:09 +0100
commit0b34a5dd39e177ba99cd21b639d67ac8123b8458 (patch)
tree6b1d80910864fbf397bdbe79b68090c45b7c47ed
parentea65a40cdf6ac4dba37f21ad9bf81184b6598b55 (diff)
tdf#120703 PVS: silence a V555
V555 The expression '(curpos - bufpos) > 0' will work as 'curpos != bufpos'. Change-Id: I432c10c9c5ecc99293ec3f03f6e1a660e1c47e28 Reviewed-on: https://gerrit.libreoffice.org/63236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-rw-r--r--sal/osl/w32/file.cxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx
index a5e6c640b8ed..1bc898eba4e4 100644
--- a/sal/osl/w32/file.cxx
+++ b/sal/osl/w32/file.cxx
@@ -475,7 +475,7 @@ oslFileError FileHandle_Impl::readLineAt(
if (curpos >= m_buflen)
{
/* buffer examined */
- if ((curpos - bufpos) > 0)
+ if (curpos > bufpos) // actually, curpos can't become less than bufpos, so != could do
{
/* flush buffer to sequence */
result = writeSequence_Impl(