diff options
| author | Pranam Lashkari <lpranam@collabora.com> | 2020-04-27 17:15:02 +0530 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2020-05-23 17:00:43 +0100 |
| commit | 12403a79bef7a41a88ca8142a2efce66b3c7fe7c (patch) | |
| tree | ed076162adf632e2520ce04150eadded4ecfb6e0 | |
| parent | 0bfde01ab34bb366bc3d1b34c3211dc74b66d266 (diff) | |
resolved clashing of two ids
Multiple SvxFillAttrBox objects having the same ID 'fillattr' caused
the problem in online making it hard to distinguish for different function
Change-Id: Ic5a29ea75fb442d7e495761faf4a10d6ab212829
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92976
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
| -rw-r--r-- | solenv/sanitizers/ui/svx.suppr | 2 | ||||
| -rw-r--r-- | svx/source/sidebar/area/AreaPropertyPanelBase.cxx | 2 | ||||
| -rw-r--r-- | svx/uiconfig/ui/sidebararea.ui | 10 |
3 files changed, 7 insertions, 7 deletions
diff --git a/solenv/sanitizers/ui/svx.suppr b/solenv/sanitizers/ui/svx.suppr index 976c2cff2b9c..5b9e46a74810 100644 --- a/solenv/sanitizers/ui/svx.suppr +++ b/solenv/sanitizers/ui/svx.suppr @@ -61,7 +61,7 @@ svx/uiconfig/ui/safemodedialog.ui://GtkLabel[@id='label1'] orphan-label svx/uiconfig/ui/safemodedialog.ui://GtkLabel[@id='label3'] orphan-label svx/uiconfig/ui/safemodedialog.ui://GtkLabel[@id='label4'] orphan-label svx/uiconfig/ui/sidebararea.ui://GtkLabel[@id='filllabel'] orphan-label -svx/uiconfig/ui/sidebararea.ui://svxlo-SvxFillAttrBox[@id='fillattr'] missing-label-for +svx/uiconfig/ui/sidebararea.ui://svxlo-SvxFillAttrBox[@id='fillattrhb'] missing-label-for svx/uiconfig/ui/sidebararea.ui://svxlo-SvxFillTypeBox[@id='fillstylearea'] missing-label-for svx/uiconfig/ui/sidebararea.ui://GtkLabel[@id='transparencylabel'] orphan-label svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='angle'] orphan-label diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx index 257442687df0..8cfc9c6d2459 100644 --- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx +++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx @@ -93,7 +93,7 @@ AreaPropertyPanelBase::AreaPropertyPanelBase( { get(mpColorTextFT, "filllabel"); get(mpLbFillType, "fillstylearea"); - get(mpLbFillAttr, "fillattr"); + get(mpLbFillAttr, "fillattrhb"); get(mpTrspTextFT, "transparencylabel"); get(mpToolBoxColor, "selectcolor"); get(mpLBTransType, "transtype"); diff --git a/svx/uiconfig/ui/sidebararea.ui b/svx/uiconfig/ui/sidebararea.ui index 68a58b46a872..a6b13886fdbd 100644 --- a/svx/uiconfig/ui/sidebararea.ui +++ b/svx/uiconfig/ui/sidebararea.ui @@ -80,16 +80,16 @@ </packing> </child> <child> - <object class="svxlo-SvxFillAttrBox" id="fillattr"> + <object class="svxlo-SvxFillAttrBox" id="fillattrhb"> <property name="can_focus">True</property> <property name="has_tooltip">True</property> - <property name="tooltip_text" translatable="yes" context="sidebararea|fillattr|tooltip_text">Select the effect to apply.</property> + <property name="tooltip_text" translatable="yes" context="sidebararea|fillattrhb|tooltip_text">Select the effect to apply.</property> <accessibility> <relation type="labelled-by" target="filllabel"/> </accessibility> <child internal-child="accessible"> - <object class="AtkObject" id="fillattr-atkobject"> - <property name="AtkObject::accessible-name" translatable="yes" context="sidebararea|fillattr-atkobject">Hatching/Bitmap</property> + <object class="AtkObject" id="fillattrhb-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="sidebararea|fillattrhb-atkobject">Hatching/Bitmap</property> </object> </child> </object> @@ -372,7 +372,7 @@ <property name="mode">both</property> <widgets> <widget name="selectcolor"/> - <widget name="fillattr"/> + <widget name="fillattrhb"/> </widgets> </object> <object class="GtkSizeGroup" id="sizegroup2"> |