loplugin:passstuffbyref in editeng

Change-Id: I015616d7a008692b63586cd5d2ae9cc5586ead4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 12 insertions, 12 deletions

diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx
index bdb33166d00b..b2f0b6c0b4f1 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1401,7 +1401,7 @@ bool EditEngine::HasText( const SvxSearchItem& rSearchItem )
     return getImpl().HasText(rSearchItem);
 }
 
-ScalingParameters EditEngine::getScalingParameters() const
+const ScalingParameters & EditEngine::getScalingParameters() const
 {
     return getImpl().getScalingParameters();
 }
diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx
index 856a53b792fe..d4b7ce6109af 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -1273,7 +1273,7 @@ public:
 
     void setScalingParameters(ScalingParameters const& rScalingParameters);
 
-    ScalingParameters getScalingParameters()
+    const ScalingParameters & getScalingParameters()
     {
         return maScalingParameters;
     }
diff --git a/editeng/source/items/CustomPropertyField.cxx b/editeng/source/items/CustomPropertyField.cxx
index eaad4c4c4db8..463f128ea2f1 100644
--- a/editeng/source/items/CustomPropertyField.cxx
+++ b/editeng/source/items/CustomPropertyField.cxx
@@ -48,21 +48,21 @@ MetaAction* CustomPropertyField::createBeginComment() const
     return new MetaCommentAction("FIELD_SEQ_BEGIN"_ostr);
 }
 
-OUString CustomPropertyField::GetFormatted(uno::Reference<document::XDocumentProperties> const & xDocumentProperties)
+const OUString & CustomPropertyField::GetFormatted(uno::Reference<document::XDocumentProperties> const & xDocumentProperties)
 {
     if (msName.isEmpty())
-        return OUString();
+        return EMPTY_OUSTRING;
     if (!xDocumentProperties.is())
-        return OUString();
+        return EMPTY_OUSTRING;
     uno::Reference<beans::XPropertyContainer> xPropertyContainer = xDocumentProperties->getUserDefinedProperties();
     if (!xPropertyContainer.is())
-        return OUString();
+        return EMPTY_OUSTRING;
     uno::Reference<beans::XPropertySet> xPropertySet(xPropertyContainer, uno::UNO_QUERY);
     if (!xPropertySet.is())
-        return OUString();
+        return EMPTY_OUSTRING;
     uno::Any aAny = xPropertySet->getPropertyValue(msName);
     if (!aAny.has<OUString>())
-        return OUString();
+        return EMPTY_OUSTRING;
     msCurrentPresentation = aAny.get<OUString>();
     return msCurrentPresentation;
 }
diff --git a/editeng/source/outliner/outlin2.cxx b/editeng/source/outliner/outlin2.cxx
index ccd07199a60f..6c9aeda64a4c 100644
--- a/editeng/source/outliner/outlin2.cxx
+++ b/editeng/source/outliner/outlin2.cxx
@@ -472,7 +472,7 @@ void Outliner::QuickFormatDoc()
     pEditEngine->QuickFormatDoc();
 }
 
-ScalingParameters Outliner::getScalingParameters() const
+const ScalingParameters & Outliner::getScalingParameters() const
 {
     return pEditEngine->getScalingParameters();
 }
diff --git a/include/editeng/CustomPropertyField.hxx b/include/editeng/CustomPropertyField.hxx
index 38f3119a04fa..9608ccb9c8bb 100644
--- a/include/editeng/CustomPropertyField.hxx
+++ b/include/editeng/CustomPropertyField.hxx
@@ -41,7 +41,7 @@ public:
 
     virtual MetaAction* createBeginComment() const override;
 
-    OUString GetFormatted(css::uno::Reference<css::document::XDocumentProperties> const & xDocumentProperties);
+    const OUString & GetFormatted(css::uno::Reference<css::document::XDocumentProperties> const & xDocumentProperties);
 
     OUString const & GetName() const
     {
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index 1fa3d17409cd..f78aefc5cffa 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -416,7 +416,7 @@ public:
     SAL_DLLPRIVATE void            QuickMarkToBeRepainted( sal_Int32 nPara );
 
     void setScalingParameters(ScalingParameters const& rScalingParameters);
-    ScalingParameters getScalingParameters() const;
+    const ScalingParameters & getScalingParameters() const;
 
     SAL_DLLPRIVATE void setRoundFontSizeToPt(bool bRound);
 
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 8c69eaf77719..2e3670a74617 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -924,7 +924,7 @@ public:
     bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder );
     SAL_DLLPRIVATE bool            IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder, bool* pbBulletPos );
 
-    ScalingParameters getScalingParameters() const;
+    const ScalingParameters & getScalingParameters() const;
     void setScalingParameters(ScalingParameters const& rScalingParameters);
     void resetScalingParameters()
     {