diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-03-22 10:26:04 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-03-22 14:42:58 +0100 |
| commit | 3c4089e80504dfc1a1bb53b478394df2f788cc85 (patch) | |
| tree | eff367165f92962216165321fcca24e047a4b81a | |
| parent | 497984bf711191f58a11c11dec05e6e3dcb18430 (diff) | |
cid#1474236 silence bogus Use after free
Change-Id: Ia46fb86c64d66b8489f45e369a901c5b9abf03ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112875
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | vcl/unx/gtk3/gtk3gtkinst.cxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx index ec8d970caad3..2b9463544c5d 100644 --- a/vcl/unx/gtk3/gtk3gtkinst.cxx +++ b/vcl/unx/gtk3/gtk3gtkinst.cxx @@ -1871,6 +1871,7 @@ namespace gtk_widget_set_halign(pReplacement, gtk_widget_get_halign(pWidget)); gtk_widget_set_valign(pReplacement, gtk_widget_get_valign(pWidget)); + // coverity[freed_arg : FALSE] - this does not free pWidget, it is reffed by pReplacement g_object_unref(pWidget); } @@ -1880,6 +1881,7 @@ namespace replaceWidget(pWidget, pReplacement); + // coverity[pass_freed_arg : FALSE] - pWidget is not freed here due to initial g_object_ref gtk_container_add(GTK_CONTAINER(pReplacement), pWidget); // coverity[freed_arg : FALSE] - this does not free pWidget, it is reffed by pReplacement @@ -6262,6 +6264,7 @@ private: std::swap(m_nStartTabCount, m_nEndTabCount); split_notebooks(); + // coverity[pass_freed_arg : FALSE] - m_pNotebook is not freed here gtk_notebook_set_current_page(m_pNotebook, nNewPage); enable_notify_events(); @@ -6389,6 +6392,7 @@ private: make_overflow_boxes(); // don't scroll the tabs anymore + // coverity[pass_freed_arg : FALSE] - m_pNotebook is not freed here gtk_notebook_set_scrollable(m_pNotebook, false); gtk_widget_freeze_child_notify(GTK_WIDGET(m_pNotebook)); |