diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-13 13:32:22 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-04-14 09:21:39 +0200 |
commit | 40f8d2566022140ca3f2d45d7cbd8b7ab51125ed (patch) | |
tree | 4a8bd6baf43f3789425ff8d7e988e7928942169f | |
parent | cb4015bb28dd7430efaaa523d04a155eb7e46305 (diff) |
loplugin:passstuffbyref in svx
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
55 files changed, 81 insertions, 81 deletions
diff --git a/include/svx/AccessibleControlShape.hxx b/include/svx/AccessibleControlShape.hxx index 6d33e35ae969..c419d22c1282 100644 --- a/include/svx/AccessibleControlShape.hxx +++ b/include/svx/AccessibleControlShape.hxx @@ -59,7 +59,7 @@ public: const AccessibleShapeTreeInfo& rShapeTreeInfo); virtual ~AccessibleControlShape( ); - css::uno::Reference< css::beans::XPropertySet > SAL_CALL GetControlModel( ) { return m_xControlModel;} ; + const css::uno::Reference< css::beans::XPropertySet >& SAL_CALL GetControlModel( ) { return m_xControlModel;} ; AccessibleControlShape* SAL_CALL GetLabeledByControlShape(); protected: //--- XAccessible ---------------------------------------- diff --git a/include/svx/AccessibleShape.hxx b/include/svx/AccessibleShape.hxx index a3abffbd37cc..af842a0dad75 100644 --- a/include/svx/AccessibleShape.hxx +++ b/include/svx/AccessibleShape.hxx @@ -376,7 +376,7 @@ public: //===== Misc ======================================================== - css::uno::Reference< css::drawing::XShape > + const css::uno::Reference< css::drawing::XShape >& GetXShape() { return mxShape; } /** set the index _nIndex at the accessible shape diff --git a/include/svx/AccessibleShapeTreeInfo.hxx b/include/svx/AccessibleShapeTreeInfo.hxx index 52a121001572..68430f647fc6 100644 --- a/include/svx/AccessibleShapeTreeInfo.hxx +++ b/include/svx/AccessibleShapeTreeInfo.hxx @@ -73,8 +73,8 @@ public: /** Deprecated. Don't use this method. */ - css::uno::Reference< - css::accessibility::XAccessibleComponent> + const css::uno::Reference< + css::accessibility::XAccessibleComponent>& GetDocumentWindow() const { return mxDocumentWindow;} /** Set a new broadcaster that sends events indicating shape changes. @@ -91,8 +91,8 @@ public: The returned reference may be empty if the broadcaster has not been set or has been set to an empty reference. */ - css::uno::Reference< - css::document::XEventBroadcaster> + const css::uno::Reference< + css::document::XEventBroadcaster>& GetModelBroadcaster() const { return mxModelBroadcaster;} /** Set the view that will be used to construct SvxTextEditSources which @@ -122,8 +122,8 @@ public: @return The reference to the currently set controller may be empty. */ - css::uno::Reference< - css::frame::XController> + const css::uno::Reference< + css::frame::XController>& GetController() const { return mxController;} /** Set the window that is used to construct SvxTextEditSources which in diff --git a/include/svx/EnhancedCustomShape2d.hxx b/include/svx/EnhancedCustomShape2d.hxx index c85f88856552..c1f5ea99eb63 100644 --- a/include/svx/EnhancedCustomShape2d.hxx +++ b/include/svx/EnhancedCustomShape2d.hxx @@ -185,7 +185,7 @@ class SVX_DLLPUBLIC EnhancedCustomShape2d : public SfxItemSet SdrObject* CreateObject( bool bLineGeometryNeededOnly ); void ApplyGluePoints( SdrObject* pObj ); Rectangle GetTextRect() const; - Rectangle GetLogicRect() const { return aLogicRect; } + const Rectangle& GetLogicRect() const { return aLogicRect; } sal_uInt32 GetHdlCount() const; bool GetHandlePosition( const sal_uInt32 nIndex, Point& rReturnPosition ) const; diff --git a/include/svx/SmartTagItem.hxx b/include/svx/SmartTagItem.hxx index 0cc025db9aca..bcfc8a9cd002 100644 --- a/include/svx/SmartTagItem.hxx +++ b/include/svx/SmartTagItem.hxx @@ -77,8 +77,8 @@ public: const css::uno::Reference<css::text::XTextRange>& GetTextRange() const { return mxRange; } const css::uno::Reference<css::frame::XController>& GetController() const { return mxController; } const css::lang::Locale& GetLocale() const { return maLocale; } - const OUString GetApplicationName() const { return maApplicationName; } - const OUString GetRangeText() const { return maRangeText; } + const OUString& GetApplicationName() const { return maApplicationName; } + const OUString& GetRangeText() const { return maRangeText; } }; #endif // INCLUDED_SVX_SMARTTAGITEM_HXX diff --git a/include/svx/SmartTagMgr.hxx b/include/svx/SmartTagMgr.hxx index 3167da114962..ae741ac48f6c 100644 --- a/include/svx/SmartTagMgr.hxx +++ b/include/svx/SmartTagMgr.hxx @@ -215,7 +215,7 @@ public: /** Returns the name of the application this instance has been created by. */ - const OUString GetApplicationName() const { return maApplicationName; } + const OUString& GetApplicationName() const { return maApplicationName; } // css::lang::XEventListener virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw(css::uno::RuntimeException, std::exception) override; diff --git a/include/svx/dlgctrl.hxx b/include/svx/dlgctrl.hxx index cbbcb8f44d42..23d108d587bb 100644 --- a/include/svx/dlgctrl.hxx +++ b/include/svx/dlgctrl.hxx @@ -98,7 +98,7 @@ protected: void MarkToResetSettings(bool bUpdateForeground, bool bUpdateBackground); RECT_POINT GetRPFromPoint( Point, bool bRTL = false ) const; - Point GetPointFromRP( RECT_POINT ) const; + const Point& GetPointFromRP( RECT_POINT ) const; void SetFocusRect(); Point SetActualRPWithoutInvalidate( RECT_POINT eNewRP ); // returns the last point diff --git a/include/svx/drawitem.hxx b/include/svx/drawitem.hxx index 3cbcc729654b..64e94e9b7faf 100644 --- a/include/svx/drawitem.hxx +++ b/include/svx/drawitem.hxx @@ -46,7 +46,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XColorListRef GetColorList() const { return pColorList; } + const XColorListRef& GetColorList() const { return pColorList; } }; class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxGradientListItem : public SfxPoolItem @@ -71,7 +71,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XGradientListRef GetGradientList() const { return pGradientList; } + const XGradientListRef& GetGradientList() const { return pGradientList; } }; class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxHatchListItem : public SfxPoolItem @@ -95,7 +95,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XHatchListRef GetHatchList() const { return pHatchList; } + const XHatchListRef& GetHatchList() const { return pHatchList; } }; class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxBitmapListItem : public SfxPoolItem @@ -120,7 +120,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XBitmapListRef GetBitmapList() const { return pBitmapList; } + const XBitmapListRef& GetBitmapList() const { return pBitmapList; } }; class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxDashListItem : public SfxPoolItem @@ -145,7 +145,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XDashListRef GetDashList() const { return pDashList; } + const XDashListRef& GetDashList() const { return pDashList; } }; class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxLineEndListItem : public SfxPoolItem @@ -170,7 +170,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - XLineEndListRef GetLineEndList() const { return pLineEndList; } + const XLineEndListRef& GetLineEndList() const { return pLineEndList; } }; #endif diff --git a/include/svx/fmsrcimp.hxx b/include/svx/fmsrcimp.hxx index 6e5ed194d0ff..2f1f9ebdc454 100644 --- a/include/svx/fmsrcimp.hxx +++ b/include/svx/fmsrcimp.hxx @@ -126,7 +126,7 @@ namespace svxform { css::uno::Reference< css::uno::XInterface > m_xControl; // attribute access public: - css::uno::Reference< css::uno::XInterface > getControl() const{ return m_xControl; } + const css::uno::Reference< css::uno::XInterface >& getControl() const{ return m_xControl; } public: ControlTextWrapper(const css::uno::Reference< css::uno::XInterface >& _xControl) { m_xControl = _xControl; } virtual ~ControlTextWrapper() { } diff --git a/include/svx/galleryitem.hxx b/include/svx/galleryitem.hxx index ecfe03f57a0c..988c4ef2074f 100644 --- a/include/svx/galleryitem.hxx +++ b/include/svx/galleryitem.hxx @@ -52,8 +52,8 @@ public: virtual ~SvxGalleryItem(); sal_Int8 GetType() const { return m_nType; } - const rtl::OUString GetURL() const { return m_aURL; } - const css::uno::Reference< css::graphic::XGraphic > GetGraphic() const { return m_xGraphic; } + const rtl::OUString& GetURL() const { return m_aURL; } + const css::uno::Reference< css::graphic::XGraphic >& GetGraphic() const { return m_xGraphic; } // pure virtual methods from SfxPoolItem virtual bool operator==( const SfxPoolItem& ) const override; diff --git a/include/svx/galtheme.hxx b/include/svx/galtheme.hxx index 6102248b0660..11e35a3c70b1 100644 --- a/include/svx/galtheme.hxx +++ b/include/svx/galtheme.hxx @@ -166,7 +166,7 @@ public: SAL_DLLPRIVATE void AbortActualize() { bAbortActualize = true; } SAL_DLLPRIVATE Gallery* GetParent() const { return pParent; } - SAL_DLLPRIVATE tools::SvRef<SotStorage> GetSvDrawStorage() const; + SAL_DLLPRIVATE const tools::SvRef<SotStorage>& GetSvDrawStorage() const; public: diff --git a/include/svx/gridctrl.hxx b/include/svx/gridctrl.hxx index f4540571063a..85c63469f5ee 100644 --- a/include/svx/gridctrl.hxx +++ b/include/svx/gridctrl.hxx @@ -494,7 +494,7 @@ public: */ void ForceHideScrollbars(); - css::uno::Reference< css::uno::XComponentContext > + const css::uno::Reference< css::uno::XComponentContext >& getContext() const { return m_xContext; } /// returns <TRUE/> if the text of the given cell can be copied into the clipboard diff --git a/include/svx/nbdtmg.hxx b/include/svx/nbdtmg.hxx index 55059bc56776..fddb962e260d 100644 --- a/include/svx/nbdtmg.hxx +++ b/include/svx/nbdtmg.hxx @@ -225,7 +225,7 @@ class SVX_DLLPUBLIC NBOTypeMgrBase // store the attributes passed from pSet void SetItems(const SfxItemSet* pArg) { pSet = pArg;StoreBulCharFmtName_impl();StoreMapUnit_impl();} protected: - OUString GetBulCharFmtName() { return aNumCharFmtName;} + const OUString& GetBulCharFmtName() { return aNumCharFmtName;} SfxMapUnit GetMapUnit() { return eCoreUnit;} protected: bool bIsLoading; diff --git a/include/svx/scene3d.hxx b/include/svx/scene3d.hxx index 70d77e8373f8..f8642e02b540 100644 --- a/include/svx/scene3d.hxx +++ b/include/svx/scene3d.hxx @@ -126,7 +126,7 @@ public: virtual E3dScene* GetScene() const override; void SetCamera(const Camera3D& rNewCamera); - Camera3D GetCamera() const { return aCamera; } + const Camera3D& GetCamera() const { return aCamera; } void removeAllNonSelectedObjects(); virtual E3dScene* Clone() const override; diff --git a/include/svx/sdr/overlay/overlaymanager.hxx b/include/svx/sdr/overlay/overlaymanager.hxx index f91571e79e7f..64199a2ec550 100644 --- a/include/svx/sdr/overlay/overlaymanager.hxx +++ b/include/svx/sdr/overlay/overlaymanager.hxx @@ -117,11 +117,11 @@ namespace sdr virtual void invalidateRange(const basegfx::B2DRange& rRange); // stripe support ColA - Color getStripeColorA() const { return maStripeColorA; } + const Color& getStripeColorA() const { return maStripeColorA; } void setStripeColorA(Color aNew= Color(COL_BLACK)); // stripe support ColB - Color getStripeColorB() const { return maStripeColorB; } + const Color& getStripeColorB() const { return maStripeColorB; } void setStripeColorB(Color aNew = Color(COL_WHITE)); // stripe support StripeLengthPixel diff --git a/include/svx/sdr/overlay/overlayobject.hxx b/include/svx/sdr/overlay/overlayobject.hxx index 6a4da0b11336..1130a6da65a5 100644 --- a/include/svx/sdr/overlay/overlayobject.hxx +++ b/include/svx/sdr/overlay/overlayobject.hxx @@ -144,7 +144,7 @@ namespace sdr const basegfx::B2DRange& getBaseRange() const; // access to baseColor - Color getBaseColor() const { return maBaseColor; } + const Color& getBaseColor() const { return maBaseColor; } void setBaseColor(Color aNew); // execute event from base class sdr::animation::Event. Default diff --git a/include/svx/sdr/overlay/overlaypolypolygon.hxx b/include/svx/sdr/overlay/overlaypolypolygon.hxx index a59cfe0b2a98..7cc20f481aee 100644 --- a/include/svx/sdr/overlay/overlaypolypolygon.hxx +++ b/include/svx/sdr/overlay/overlaypolypolygon.hxx @@ -44,7 +44,7 @@ namespace sdr virtual ~OverlayPolyPolygonStripedAndFilled(); // change geometry - basegfx::B2DPolyPolygon getLinePolyPolygon() const { return maLinePolyPolygon; } + const basegfx::B2DPolyPolygon& getLinePolyPolygon() const { return maLinePolyPolygon; } // react on stripe definition change virtual void stripeDefinitionHasChanged() override; diff --git a/include/svx/sidebar/AreaPropertyPanelBase.hxx b/include/svx/sidebar/AreaPropertyPanelBase.hxx index 4c67637756b7..e4ec0dfa2564 100644 --- a/include/svx/sidebar/AreaPropertyPanelBase.hxx +++ b/include/svx/sidebar/AreaPropertyPanelBase.hxx @@ -80,7 +80,7 @@ public: const static sal_Int32 DEFAULT_ENDVALUE; const static sal_Int32 DEFAULT_BORDER; - XGradient GetGradient (const css::awt::GradientStyle eStyle) const; + const XGradient& GetGradient (const css::awt::GradientStyle eStyle) const; void SetGradient (const XGradient& rGradient); sal_Int32 GetSelectedTransparencyTypeIndex() const; diff --git a/include/svx/svdedxv.hxx b/include/svx/svdedxv.hxx index 9ef93a14d382..519ba6eb5e2e 100644 --- a/include/svx/svdedxv.hxx +++ b/include/svx/svdedxv.hxx @@ -258,7 +258,7 @@ public: virtual void MarkListHasChanged() override; - rtl::Reference< sdr::SelectionController > getSelectionController() const { return mxSelectionController; } + const rtl::Reference< sdr::SelectionController >& getSelectionController() const { return mxSelectionController; } /** returns true if the shape identified by its inventor and identifier supports format paint brush operation */ static bool SupportsFormatPaintbrush( sal_uInt32 nObjectInventor, sal_uInt16 nObjectIdentifier ); diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx index 9214f5acd8ec..f93386efd757 100644 --- a/include/svx/svdhdl.hxx +++ b/include/svx/svdhdl.hxx @@ -270,7 +270,7 @@ public: bool IsUseLuminance() const { return bUseLuminance; } - Color GetColor() const { return aMarkerColor; } + const Color& GetColor() const { return aMarkerColor; } void SetColor(Color aNew, bool bCallLink = false); void SetSize(const Size& rNew); diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index 9525e0cb3328..350acefe74dc 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -536,7 +536,7 @@ public: // Accessor methods for Palettes, Lists and Tables // FIXME: this badly needs re-factoring... - XPropertyListRef GetPropertyList( XPropertyListType t ) const { return maProperties[ t ]; } + const XPropertyListRef& GetPropertyList( XPropertyListType t ) const { return maProperties[ t ]; } void SetPropertyList( XPropertyListRef p ) { maProperties[ p->Type() ] = p; } // friendlier helpers diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx index a73485a9b881..3b8c5b9848ae 100644 --- a/include/svx/svdobj.hxx +++ b/include/svx/svdobj.hxx @@ -369,7 +369,7 @@ public: const double* GetRelativeHeight() const; sal_Int16 GetRelativeHeightRelation() const; // evil calc grid/shape drawlayer syncing - Point GetGridOffset() const { return aGridOffset; } + const Point& GetGridOffset() const { return aGridOffset; } void SetGridOffset( const Point& rGridOffset ){ aGridOffset = rGridOffset; } protected: Rectangle ImpDragCalcRect(const SdrDragStat& rDrag) const; @@ -875,7 +875,7 @@ public: // access to the UNO representation of the shape virtual css::uno::Reference< css::uno::XInterface > getUnoShape(); - css::uno::WeakReference< css::uno::XInterface > getWeakUnoShape() const { return maWeakUnoShape; } + const css::uno::WeakReference< css::uno::XInterface >& getWeakUnoShape() const { return maWeakUnoShape; } static SdrObject* getSdrObjectFromXShape( const css::uno::Reference< css::uno::XInterface >& xInt ); @@ -929,7 +929,7 @@ public: // the following methods are used to control it; // usually this data makes no sense after the import is finished, since the object // might be resized - Rectangle GetBLIPSizeRectangle() const { return maBLIPSizeRectangle;} + const Rectangle& GetBLIPSizeRectangle() const { return maBLIPSizeRectangle;} void SetBLIPSizeRectangle( const Rectangle& aRect ); /// @see mbDoNotInsertIntoPageAutomatically diff --git a/include/svx/svdoole2.hxx b/include/svx/svdoole2.hxx index 00525e60bc9b..cd21df9241b4 100644 --- a/include/svx/svdoole2.hxx +++ b/include/svx/svdoole2.hxx @@ -93,7 +93,7 @@ public: // OLE object has got a separate PersistName member now; // !!! use ::SetPersistName( ... ) only, if you know what you do !!! - OUString GetPersistName() const; + const OUString& GetPersistName() const; void SetPersistName( const OUString& rPersistName ); // One can add an application name to a SdrOle2Obj, which can be queried for diff --git a/include/svx/svdouno.hxx b/include/svx/svdouno.hxx index 6e0e7b88a878..59af7fd0a593 100644 --- a/include/svx/svdouno.hxx +++ b/include/svx/svdouno.hxx @@ -88,7 +88,7 @@ public: virtual void SetContextWritingMode( const sal_Int16 _nContextWritingMode ) override; - css::uno::Reference< css::awt::XControlModel > GetUnoControlModel() const {return xUnoControlModel;} + const css::uno::Reference< css::awt::XControlModel >& GetUnoControlModel() const {return xUnoControlModel;} css::uno::Reference< css::awt::XControl > GetUnoControl(const SdrView& _rView, const OutputDevice& _rOut) const; /** Retrieves a temporary XControl instance for a given output device diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx index d6e1c713bc0c..f5b982117886 100644 --- a/include/svx/svdpagv.hxx +++ b/include/svx/svdpagv.hxx @@ -258,11 +258,11 @@ public: // #103834# Set background color for svx at SdrPageViews void SetApplicationBackgroundColor(Color aBackgroundColor); - Color GetApplicationBackgroundColor() const { return maBackgroundColor;} + const Color& GetApplicationBackgroundColor() const { return maBackgroundColor;} // #103911# Set/Get document color for svx at SdrPageViews void SetApplicationDocumentColor(Color aDocumentColor); - Color GetApplicationDocumentColor() const { return maDocumentColor;} + const Color& GetApplicationDocumentColor() const { return maDocumentColor;} }; diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx index a3d00a04ea1b..b270076cfec7 100644 --- a/include/svx/svdpntv.hxx +++ b/include/svx/svdpntv.hxx @@ -390,7 +390,7 @@ public: /// Draw Help line in fron of the objects or beging them bool IsHlplFront() const { return mbHlplFront ; } - Color GetGridColor() const { return maGridColor;} + const Color& GetGridColor() const { return maGridColor;} void SetPageVisible(bool bOn = true) { mbPageVisible=bOn; InvalidateAllWin(); } void SetPageShadowVisible(bool bOn = true) { mbPageShadowVisible=bOn; InvalidateAllWin(); } void SetPageBorderVisible(bool bOn = true) { mbPageBorderVisible=bOn; InvalidateAllWin(); } diff --git a/include/svx/svxgrahicitem.hxx b/include/svx/svxgrahicitem.hxx index 00e2f0d1c089..794f68ffaa4d 100644 --- a/include/svx/svxgrahicitem.hxx +++ b/include/svx/svxgrahicitem.hxx @@ -38,7 +38,7 @@ public: virtual bool operator==( const SfxPoolItem& ) const override; virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; - Graphic GetGraphic() const { return aGraphic; } + const Graphic& GetGraphic() const { return aGraphic; } }; diff --git a/include/svx/ucsubset.hxx b/include/svx/ucsubset.hxx index ccdc3d92f509..26464d934f38 100644 --- a/include/svx/ucsubset.hxx +++ b/include/svx/ucsubset.hxx @@ -45,7 +45,7 @@ public: sal_UCS4 GetRangeMin() const { return mnRangeMin;} sal_UCS4 GetRangeMax() const { return mnRangeMax;} - const OUString GetName() const { return maRangeName;} + const OUString& GetName() const { return maRangeName;} private: sal_UCS4 mnRangeMin; diff --git a/include/svx/unoshape.hxx b/include/svx/unoshape.hxx index be0b4b5b3195..08c377040891 100644 --- a/include/svx/unoshape.hxx +++ b/include/svx/unoshape.hxx @@ -896,7 +896,7 @@ public: SvxDummyShapeContainer( css::uno::Reference< css::drawing::XShapes > xWrappedObject ); virtual ~SvxDummyShapeContainer() throw(); - css::uno::Reference< css::drawing::XShapes > getWrappedShape() + const css::uno::Reference< css::drawing::XShapes >& getWrappedShape() { return m_xDummyObject; } }; diff --git a/include/svx/xbitmap.hxx b/include/svx/xbitmap.hxx index 7f514d190250..32a8e9fab11b 100644 --- a/include/svx/xbitmap.hxx +++ b/include/svx/xbitmap.hxx @@ -55,7 +55,7 @@ public: void SetBackgroundColor( const Color& rColor ) { aBckgrColor = rColor; bGraphicDirty = true; } Bitmap GetBitmap() const; - Color GetBackgroundColor() const { return aBckgrColor; } + const Color& GetBackgroundColor() const { return aBckgrColor; } }; #endif diff --git a/include/svx/xgrad.hxx b/include/svx/xgrad.hxx index 68cbae987ac3..c9dc407c11ef 100644 --- a/include/svx/xgrad.hxx +++ b/include/svx/xgrad.hxx @@ -63,9 +63,9 @@ public: void SetSteps(sal_uInt16 nSteps) { nStepCount = nSteps; } css::awt::GradientStyle GetGradientStyle() const { return eStyle; } - Color GetStartColor() const { return aStartColor; } - Color GetEndColor() const { return aEndColor; } - long GetAngle() const { return nAngle; } + const Color& GetStartColor() const { return aStartColor; } + const Color& GetEndColor() const { return aEndColor; } + long GetAngle() const { return nAngle; } sal_uInt16 GetBorder() const { return nBorder; } sal_uInt16 GetXOffset() const { return nOfsX; } sal_uInt16 GetYOffset() const { return nOfsY; } diff --git a/include/svx/xhatch.hxx b/include/svx/xhatch.hxx index 52010cd5f71f..cf97801b0787 100644 --- a/include/svx/xhatch.hxx +++ b/include/svx/xhatch.hxx @@ -49,7 +49,7 @@ public: void SetAngle(long nNewAngle) { nAngle = nNewAngle; } css::drawing::HatchStyle GetHatchStyle() const { return eStyle; } - Color GetColor() const { return aColor; } + const Color& GetColor() const { return aColor; } long GetDistance() const { return nDistance; } long GetAngle() const { return nAngle; } }; diff --git a/include/svx/xlnedit.hxx b/include/svx/xlnedit.hxx index 930408b5b45c..24c579fd2f2c 100644 --- a/include/svx/xlnedit.hxx +++ b/include/svx/xlnedit.hxx @@ -54,7 +54,7 @@ public: SfxMapUnit ePresMetric, OUString &rText, const IntlWrapper * = nullptr ) const override; - basegfx::B2DPolyPolygon GetLineEndValue() const { return maPolyPolygon;} + const basegfx::B2DPolyPolygon& GetLineEndValue() const { return maPolyPolygon;} void SetLineEndValue(const basegfx::B2DPolyPolygon& rPolyPolygon) { maPolyPolygon = rPolyPolygon; Detach(); } XLineEndItem* checkForUniqueItem( SdrModel* pModel ) const; diff --git a/include/svx/xlnstit.hxx b/include/svx/xlnstit.hxx index 58b9200a59f2..50bba7b9547d 100644 --- a/include/svx/xlnstit.hxx +++ b/include/svx/xlnstit.hxx @@ -54,7 +54,7 @@ public: SfxMapUnit ePresMetric, OUString &rText, const IntlWrapper * = nullptr ) const override; - basegfx::B2DPolyPolygon GetLineStartValue() const { return maPolyPolygon;} + const basegfx::B2DPolyPolygon& GetLineStartValue() const { return maPolyPolygon;} void SetLineStartValue(const basegfx::B2DPolyPolygon& rPolyPolygon) { maPolyPolygon = rPolyPolygon; Detach(); } XLineStartItem* checkForUniqueItem( SdrModel* pModel ) const; diff --git a/svx/inc/galbrws2.hxx b/svx/inc/galbrws2.hxx index 43ecd78bba7b..c0556f8081f2 100644 --- a/svx/inc/galbrws2.hxx +++ b/svx/inc/galbrws2.hxx @@ -160,7 +160,7 @@ public: bool KeyInput( const KeyEvent& rEvt, vcl::Window* pWindow ); static css::uno::Reference< css::frame::XFrame > GetFrame(); - css::uno::Reference< css::util::XURLTransformer > GetURLTransformer() const { return m_xTransformer; } + const css::uno::Reference< css::util::XURLTransformer >& GetURLTransformer() const { return m_xTransformer; } void Execute( sal_uInt16 nId ); void Dispatch( sal_uInt16 nId, diff --git a/svx/source/dialog/dlgctrl.cxx b/svx/source/dialog/dlgctrl.cxx index 69dbc1ed95e7..c80c8c930109 100644 --- a/svx/source/dialog/dlgctrl.cxx +++ b/svx/source/dialog/dlgctrl.cxx @@ -515,7 +515,7 @@ void SvxRectCtl::Paint(vcl::RenderContext& rRenderContext, const Rectangle&) // Convert RECT_POINT Point -Point SvxRectCtl::GetPointFromRP( RECT_POINT _eRP) const +const Point& SvxRectCtl::GetPointFromRP( RECT_POINT _eRP) const { switch( _eRP ) { diff --git a/svx/source/dialog/docrecovery.cxx b/svx/source/dialog/docrecovery.cxx index 08e9944b60d4..d1d997022e74 100644 --- a/svx/source/dialog/docrecovery.cxx +++ b/svx/source/dialog/docrecovery.cxx @@ -79,7 +79,7 @@ RecoveryCore::~RecoveryCore() } -css::uno::Reference< css::uno::XComponentContext > RecoveryCore::getComponentContext() +const css::uno::Reference< css::uno::XComponentContext >& RecoveryCore::getComponentContext() { return m_xContext; } @@ -1314,7 +1314,7 @@ bool BrokenRecoveryDialog::isExecutionNeeded() } -OUString BrokenRecoveryDialog::getSaveDirURL() +const OUString& BrokenRecoveryDialog::getSaveDirURL() { return m_sSavePath; } diff --git a/svx/source/dialog/imapwnd.hxx b/svx/source/dialog/imapwnd.hxx index a82775b98e78..ed25c721db5c 100644 --- a/svx/source/dialog/imapwnd.hxx +++ b/svx/source/dialog/imapwnd.hxx @@ -76,7 +76,7 @@ public: virtual SdrObjUserData* Clone( SdrObject * ) const override { return new IMapUserData( *this ); } - const IMapObjectPtr GetObject() const { return mpObj; } + const IMapObjectPtr& GetObject() const { return mpObj; } void ReplaceObject( const IMapObjectPtr& pNewIMapObject ) { mpObj = pNewIMapObject; } }; diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx index ab51d0a6c0fa..072eae04298c 100644 --- a/svx/source/form/formcontroller.cxx +++ b/svx/source/form/formcontroller.cxx @@ -433,7 +433,7 @@ class OParameterContinuation : public OInteraction< XInteractionSupplyParameters public: OParameterContinuation() { } - Sequence< PropertyValue > getValues() const { return m_aValues; } + const Sequence< PropertyValue >& getValues() const { return m_aValues; } // XInteractionSupplyParameters virtual void SAL_CALL setParameters( const Sequence< PropertyValue >& _rValues ) throw(RuntimeException, std::exception) override; diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx index 8f1cdb1c6d80..05037da5ee5e 100644 --- a/svx/source/gallery2/galtheme.cxx +++ b/svx/source/gallery2/galtheme.cxx @@ -1530,7 +1530,7 @@ bool GalleryTheme::IsReadOnly() const { return pThm->IsReadOnly(); } bool GalleryTheme::IsDefault() const { return pThm->IsDefault(); } bool GalleryTheme::IsModified() const { return pThm->IsModified(); } -tools::SvRef<SotStorage> GalleryTheme::GetSvDrawStorage() const +const tools::SvRef<SotStorage>& GalleryTheme::GetSvDrawStorage() const { return aSvDrawStorageRef; } diff --git a/svx/source/inc/datanavi.hxx b/svx/source/inc/datanavi.hxx index c22b00800d6a..1869711b5734 100644 --- a/svx/source/inc/datanavi.hxx +++ b/svx/source/inc/datanavi.hxx @@ -301,7 +301,7 @@ namespace svxform inline css::uno::Reference<css::beans::XPropertySet> GetBindingForNode( const css::uno::Reference<css::xml::dom::XNode> &xNode ) { return m_xUIHelper->getBindingForNode(xNode,true); } inline OUString GetServiceNameForNode( const css::uno::Reference<css::xml::dom::XNode> &xNode ) { return m_xUIHelper->getDefaultServiceNameForNode(xNode); } - inline XFormsUIHelper1_ref GetXFormsHelper() const { return m_xUIHelper; } + const XFormsUIHelper1_ref& GetXFormsHelper() const { return m_xUIHelper; } }; @@ -489,7 +489,7 @@ namespace svxform virtual ~AddConditionDialog(); virtual void dispose() override; - XFormsUIHelper1_ref GetUIHelper() const { return m_xUIHelper; } + const XFormsUIHelper1_ref& GetUIHelper() const { return m_xUIHelper; } OUString GetCondition() const { return m_pConditionED->GetText(); } void SetCondition(const OUString& _rCondition) { diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx index 62a624671035..31bfdfee0907 100644 --- a/svx/source/inc/docrecovery.hxx +++ b/svx/source/inc/docrecovery.hxx @@ -232,7 +232,7 @@ class RecoveryCore : public ::cppu::WeakImplHelper< css::frame::XStatusListener /** @short TODO */ - css::uno::Reference< css::uno::XComponentContext > getComponentContext(); + const css::uno::Reference< css::uno::XComponentContext >& getComponentContext(); /** @short TODO */ @@ -583,7 +583,7 @@ class BrokenRecoveryDialog : public ModalDialog /** @short TODO */ - OUString getSaveDirURL(); + const OUString& getSaveDirURL(); // helper diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx index f0ed25cfc09d..91353645b3bd 100644 --- a/svx/source/inc/filtnav.hxx +++ b/svx/source/inc/filtnav.hxx @@ -69,7 +69,7 @@ public: virtual ~FmFilterData(){} void SetText( const OUString& rText ){ m_aText = rText; } - OUString GetText() const { return m_aText; } + const OUString& GetText() const { return m_aText; } FmParentData* GetParent() const {return m_pParent;} virtual Image GetImage() const; diff --git a/svx/source/inc/fmexch.hxx b/svx/source/inc/fmexch.hxx index 182d5a7a85c2..c0cd1dc27416 100644 --- a/svx/source/inc/fmexch.hxx +++ b/svx/source/inc/fmexch.hxx @@ -183,10 +183,10 @@ namespace svxform // Aufrufer sicherstellen) const ListBoxEntrySet& selected() const { return m_aSelectedEntries; } - css::uno::Sequence< css::uno::Reference< css::uno::XInterface > > + const css::uno::Sequence< css::uno::Reference< css::uno::XInterface > >& hiddenControls() const { return m_aHiddenControlModels; } - css::uno::Reference< css::form::XForms > + const css::uno::Reference< css::form::XForms >& getFormsRoot() const { return m_xFormsRoot; } }; diff --git a/svx/source/inc/fmexpl.hxx b/svx/source/inc/fmexpl.hxx index d3b606aecb98..1059b262b8b5 100644 --- a/svx/source/inc/fmexpl.hxx +++ b/svx/source/inc/fmexpl.hxx @@ -110,7 +110,7 @@ public: virtual ~FmNavNameChangedHint(); FmEntryData* GetEntryData() const { return pEntryData; } - OUString GetNewName() const { return aNewName; } + const OUString& GetNewName() const { return aNewName; } }; @@ -163,7 +163,7 @@ public: const Image& GetNormalImage() const { return m_aNormalImage; } - OUString GetText() const { return aText; } + const OUString& GetText() const { return aText; } FmEntryData* GetParent() const { return pParent; } FmEntryDataList* GetChildList() const { return pChildList; } diff --git a/svx/source/inc/fmitems.hxx b/svx/source/inc/fmitems.hxx index 7e3dbd3b128f..c04445f81115 100644 --- a/svx/source/inc/fmitems.hxx +++ b/svx/source/inc/fmitems.hxx @@ -44,7 +44,7 @@ public: virtual SfxPoolItem* Create(SvStream &, sal_uInt16) const override; virtual SvStream& Store(SvStream &, sal_uInt16 nItemVersion ) const override; - const css::uno::Reference< css::uno::XInterface > GetInterface() const { return xInterface; } + const css::uno::Reference< css::uno::XInterface >& GetInterface() const { return xInterface; } }; inline FmInterfaceItem& FmInterfaceItem::operator=( const FmInterfaceItem &rCpy ) diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx index 8de87da53967..196526237c6f 100644 --- a/svx/source/inc/fmshimp.hxx +++ b/svx/source/inc/fmshimp.hxx @@ -382,7 +382,7 @@ public: SAL_DLLPRIVATE bool setCurrentSelectionFromMark(const SdrMarkList& rMarkList); /// returns the currently selected form, or the form which all currently selected controls belong to, or <NULL/> - SAL_DLLPRIVATE css::uno::Reference< css::form::XForm > + SAL_DLLPRIVATE const css::uno::Reference< css::form::XForm >& getCurrentForm() const { return m_xCurrentForm; } SAL_DLLPRIVATE void forgetCurrentForm(); /// returns whether the last known marking contained only controls @@ -556,7 +556,7 @@ class SearchableControlIterator : public ::comphelper::IndexAccessIterator // der aktuelle Wert der ControlSource-css::beans::Property public: - OUString getCurrentValue() const { return m_sCurrentValue; } + const OUString& getCurrentValue() const { return m_sCurrentValue; } public: SearchableControlIterator(css::uno::Reference< css::uno::XInterface> xStartingPoint); diff --git a/svx/source/inc/fmvwimp.hxx b/svx/source/inc/fmvwimp.hxx index 475a47651d4a..32d4459db349 100644 --- a/svx/source/inc/fmvwimp.hxx +++ b/svx/source/inc/fmvwimp.hxx @@ -121,7 +121,7 @@ protected: void setController( const css::uno::Reference< css::form::XForm >& xForm, const css::uno::Reference< css::form::runtime::XFormController >& _rxParentController ); - css::uno::Reference< css::awt::XControlContainer > getControlContainer() const { return m_xControlContainer; } + const css::uno::Reference< css::awt::XControlContainer >& getControlContainer() const { return m_xControlContainer; } void updateTabOrder( const css::uno::Reference< css::form::XForm >& _rxForm ); void dispose(); vcl::Window* getWindow() const {return m_pWindow;} diff --git a/svx/source/inc/svdoutlinercache.hxx b/svx/source/inc/svdoutlinercache.hxx index 03572fc29389..39bb5d85ce3c 100644 --- a/svx/source/inc/svdoutlinercache.hxx +++ b/svx/source/inc/svdoutlinercache.hxx @@ -42,7 +42,7 @@ public: SdrOutliner* createOutliner( sal_uInt16 nOutlinerMode ); void disposeOutliner( SdrOutliner* pOutliner ); - std::vector<SdrOutliner*> GetActiveOutliners() const + const std::vector<SdrOutliner*>& GetActiveOutliners() const { return maActiveOutliners; } diff --git a/svx/source/inc/tabwin.hxx b/svx/source/inc/tabwin.hxx index ab224a428b97..e042fc746040 100644 --- a/svx/source/inc/tabwin.hxx +++ b/svx/source/inc/tabwin.hxx @@ -94,7 +94,7 @@ public: void FillInfo( SfxChildWinInfo& rInfo ) const override; const OUString& GetDatabaseName() const { return m_aDatabaseName; } - ::dbtools::SharedConnection GetConnection() const { return m_aConnection; } + const ::dbtools::SharedConnection& GetConnection() const { return m_aConnection; } const OUString& GetObjectName() const { return m_aObjectName; } sal_Int32 GetObjectType() const { return m_nObjectType; } diff --git a/svx/source/sdr/attribute/sdrformtextattribute.cxx b/svx/source/sdr/attribute/sdrformtextattribute.cxx index 5c8330e0597d..ac34ebc32817 100644 --- a/svx/source/sdr/attribute/sdrformtextattribute.cxx +++ b/svx/source/sdr/attribute/sdrformtextattribute.cxx @@ -233,7 +233,7 @@ namespace drawinglayer XFormTextStyle getFormTextStyle() const { return meFormTextStyle; } XFormTextAdjust getFormTextAdjust() const { return meFormTextAdjust; } XFormTextShadow getFormTextShadow() const { return meFormTextShadow; } - Color getFormTextShdwColor() const { return maFormTextShdwColor; } + const Color& getFormTextShdwColor() const { return maFormTextShdwColor; } const SdrFormTextOutlineAttribute& getOutline() const { return maOutline; } const SdrFormTextOutlineAttribute& getShadowOutline() const { return maShadowOutline; } bool getFormTextMirror() const { return mbFormTextMirror; } diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx index 836821b64579..cbb4f7a75622 100644 --- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx +++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx @@ -1257,7 +1257,7 @@ IMPL_LINK_NOARG_TYPED(AreaPropertyPanelBase, ModifyTransparentHdl_Impl, Edit&, v setFillTransparence(aLinearItem); } -XGradient AreaPropertyPanelBase::GetGradient (const css::awt::GradientStyle eStyle) const +const XGradient& AreaPropertyPanelBase::GetGradient (const css::awt::GradientStyle eStyle) const { switch (eStyle) { diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx index a2bd48eda579..2ebf0effe434 100644 --- a/svx/source/svdraw/svdograf.cxx +++ b/svx/source/svdraw/svdograf.cxx @@ -124,7 +124,7 @@ public: void UpdateAsynchron(); void RemoveGraphicUpdater(); - OUString getReferer() const { return rGrafObj.aReferer; } + const OUString& getReferer() const { return rGrafObj.aReferer; } }; class SdrGraphicUpdater : public ::osl::Thread diff --git a/svx/source/svdraw/svdoole2.cxx b/svx/source/svdraw/svdoole2.cxx index bfcd7d5853cc..0b8116e212e1 100644 --- a/svx/source/svdraw/svdoole2.cxx +++ b/svx/source/svdraw/svdoole2.cxx @@ -127,8 +127,8 @@ public: m_aScaleHeight = aScaleHeight; } - Fraction GetScaleWidth() const { return m_aScaleWidth; } - Fraction GetScaleHeight() const { return m_aScaleHeight; } + const Fraction& GetScaleWidth() const { return m_aScaleWidth; } + const Fraction& GetScaleHeight() const { return m_aScaleHeight; } void setWindow(const uno::Reference< awt::XWindow >& _xWindow); @@ -1558,7 +1558,7 @@ void SdrOle2Obj::AbandonObject() } -OUString SdrOle2Obj::GetPersistName() const +const OUString& SdrOle2Obj::GetPersistName() const { return mpImpl->aPersistName; } diff --git a/svx/source/table/accessiblecell.hxx b/svx/source/table/accessiblecell.hxx index 0aa17a227b47..0279b6a96fbb 100644 --- a/svx/source/table/accessiblecell.hxx +++ b/svx/source/table/accessiblecell.hxx @@ -72,7 +72,7 @@ public: virtual css::uno::Reference< css::accessibility::XAccessibleStateSet> SAL_CALL getAccessibleStateSet() throw(css::uno::RuntimeException, std::exception) override; virtual sal_Int32 SAL_CALL getAccessibleIndexInParent() throw(css::uno::RuntimeException, std::exception) override; virtual OUString SAL_CALL getAccessibleName() throw (css::uno::RuntimeException, std::exception) override; - sdr::table::CellRef getCellRef() { return mxCell;} + const sdr::table::CellRef& getCellRef() { return mxCell;} void UpdateChildren(); static OUString getCellName( sal_Int32 nCol, sal_Int32 nRow ); |