diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-04-04 11:21:13 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-04-04 13:41:03 +0200 |
| commit | 41581fe7d782f261c19594c89875666f99c91af1 (patch) | |
| tree | a99770234d8675d0eab0b8b80c2db764ba9f1639 | |
| parent | 76fbdc6638824d2509d29a4993e5e5805bac65b0 (diff) | |
fix 'tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify'
I messed up in
commit 9c5fda14fff397d5d503f749ad019791d7e4ef83
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed Mar 6 16:20:41 2024 +0200
tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify
and forgot to actually use the new SfxHintId::StyleSheetModifiedExtended
I created in the constructor of the SfxStyleSheetHint class
Change-Id: Ica661a156d72c8a4b8ad415b6f45fe5d3458ba26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165787
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | include/svl/hint.hxx | 4 | ||||
| -rw-r--r-- | svl/source/items/style.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx index 860ea4219c56..e8971934c7d4 100644 --- a/include/svl/hint.hxx +++ b/include/svl/hint.hxx @@ -103,8 +103,8 @@ enum class SfxHintId { // SFX stylesheet StyleSheetCreated, // new - StyleSheetModified, // changed - StyleSheetModifiedExtended, // changed, but using the SfxStyleSheetModifiedHint, not the SfxStyleSheetHint + StyleSheetModified, // changed (used by the SfxStyleSheetHint class) + StyleSheetModifiedExtended, // changed (used by the SfxStyleSheetModifiedHint class) StyleSheetChanged, // erased and re-created (replaced) StyleSheetErased, // erased StyleSheetInDestruction, // in the process of being destructed diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx index 0f208ad1cf26..bcd90faeaef4 100644 --- a/svl/source/items/style.cxx +++ b/svl/source/items/style.cxx @@ -66,7 +66,7 @@ SfxStyleSheetModifiedHint::SfxStyleSheetModifiedHint OUString aOldName, SfxStyleSheetBase& rStyleSheet // Remains with the caller ) -: SfxStyleSheetHint( SfxHintId::StyleSheetModified, rStyleSheet ), +: SfxStyleSheetHint( SfxHintId::StyleSheetModifiedExtended, rStyleSheet ), aName(std::move( aOldName )) {} |