diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-26 11:17:57 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-27 14:50:11 +0200 |
| commit | 4b995afda324fb4e85991c723b63a2703f33669e (patch) | |
| tree | e39254286f88067ecedab49381cf6fc1700ab7ee | |
| parent | 1c53f4c0774c3696af9d927651ec625c36567555 (diff) | |
loplugin:virtualdead in svl
Change-Id: Idbb5d0a633f12d5813561a2ad8aed46ec6d67c48
Reviewed-on: https://gerrit.libreoffice.org/79639
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | compilerplugins/clang/virtualdead.results | 6 | ||||
| -rw-r--r-- | framework/source/fwe/helper/undomanagerhelper.cxx | 6 | ||||
| -rw-r--r-- | include/svl/undo.hxx | 1 | ||||
| -rw-r--r-- | svl/source/undo/undo.cxx | 8 |
4 files changed, 0 insertions, 21 deletions
diff --git a/compilerplugins/clang/virtualdead.results b/compilerplugins/clang/virtualdead.results index b8b5fa873949..bd25262008c9 100644 --- a/compilerplugins/clang/virtualdead.results +++ b/compilerplugins/clang/virtualdead.results @@ -91,12 +91,6 @@ include/svl/svdde.hxx:239 include/svl/svdde.hxx:241 _Bool DdeTopic::MakeItem(const class rtl::OUString &,) 0 -include/svl/svdde.hxx:244 - _Bool DdeTopic::StartAdviseLoop() - 0 -include/svl/undo.hxx:168 - void SfxUndoListener::undoManagerDying() - empty include/svtools/unoevent.hxx:199 unsigned short SvEventDescriptor::getMacroItemWhich()const 108 diff --git a/framework/source/fwe/helper/undomanagerhelper.cxx b/framework/source/fwe/helper/undomanagerhelper.cxx index 411d32ed7b67..080b70eef4c6 100644 --- a/framework/source/fwe/helper/undomanagerhelper.cxx +++ b/framework/source/fwe/helper/undomanagerhelper.cxx @@ -248,7 +248,6 @@ namespace framework virtual void listActionEntered( const OUString& i_comment ) override; virtual void listActionLeft( const OUString& i_comment ) override; virtual void listActionCancelled() override; - virtual void undoManagerDying() override; // public operations void disposing(); @@ -826,11 +825,6 @@ namespace framework notify( OUString(), &XUndoManagerListener::cancelledContext ); } - void UndoManagerHelper_Impl::undoManagerDying() - { - // TODO: do we need to care? Or is this the responsibility of our owner? - } - //= UndoManagerHelper UndoManagerHelper::UndoManagerHelper( IUndoManagerImplementation& i_undoManagerImpl ) diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx index 22e180570268..272139802398 100644 --- a/include/svl/undo.hxx +++ b/include/svl/undo.hxx @@ -165,7 +165,6 @@ public: virtual void listActionEntered( const OUString& i_comment ) = 0; virtual void listActionLeft( const OUString& i_comment ) = 0; virtual void listActionCancelled() = 0; - virtual void undoManagerDying() = 0; protected: ~SfxUndoListener() {} diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx index e3c78895a8fe..5d84ae1e0378 100644 --- a/svl/source/undo/undo.cxx +++ b/svl/source/undo/undo.cxx @@ -345,14 +345,6 @@ SfxUndoManager::SfxUndoManager( size_t nMaxUndoActionCount ) SfxUndoManager::~SfxUndoManager() { - UndoListeners aListenersCopy; - { - UndoManagerGuard aGuard( *m_xData ); - aListenersCopy = m_xData->aListeners; - } - - ::std::for_each( aListenersCopy.begin(), aListenersCopy.end(), - NotifyUndoListener( &SfxUndoListener::undoManagerDying ) ); } |