diff options
author | Noel Grandin <noel@peralex.com> | 2015-08-12 15:09:44 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-08-14 10:52:46 +0200 |
commit | 4c6d1a2636941c559d78fcac36125ba1374330f9 (patch) | |
tree | d651b23ce2b95f320d37a4d4c3fb2d1ccf0de916 | |
parent | 860130783830fc39ea49a3c76f70ab79b4f31f92 (diff) |
loplugin: defaultparams
Change-Id: I81537289a40bdc30bd8d896dc5364f0989205e39
36 files changed, 170 insertions, 170 deletions
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx index 2bb91d542dd9..e3ce1d4808eb 100644 --- a/cui/source/customize/cfg.cxx +++ b/cui/source/customize/cfg.cxx @@ -1138,7 +1138,7 @@ bool MenuSaveInData::LoadSubMenus( } else { - pEntry->SetMain( true ); + pEntry->SetMain(); } subMenuTitle += stripHotKey( aLabel ); @@ -1682,13 +1682,13 @@ void SvxConfigPage::Reset( const SfxItemSet* ) { if ( pDocData && pDocData->HasURL( m_aURLToSelect ) ) { - m_pSaveInListBox->SelectEntryPos( nPos, true ); + m_pSaveInListBox->SelectEntryPos( nPos ); pCurrentSaveInData = pDocData; bURLToSelectFound = true; } else if ( pModuleData && pModuleData->HasURL( m_aURLToSelect ) ) { - m_pSaveInListBox->SelectEntryPos( 0, true ); + m_pSaveInListBox->SelectEntryPos( 0 ); pCurrentSaveInData = pModuleData; bURLToSelectFound = true; } @@ -1700,12 +1700,12 @@ void SvxConfigPage::Reset( const SfxItemSet* ) // it the SaveIn listbox, otherwise select the module data if ( pDocData != NULL && pDocData->HasSettings() ) { - m_pSaveInListBox->SelectEntryPos( nPos, true ); + m_pSaveInListBox->SelectEntryPos( nPos ); pCurrentSaveInData = pDocData; } else { - m_pSaveInListBox->SelectEntryPos( 0, true ); + m_pSaveInListBox->SelectEntryPos( 0 ); pCurrentSaveInData = pModuleData; } } @@ -1916,7 +1916,7 @@ void SvxConfigPage::ReloadTopLevelListBox( SvxConfigEntry* pToSelect ) nSelectionPos = nSelectionPos < m_pTopLevelListBox->GetEntryCount() ? nSelectionPos : m_pTopLevelListBox->GetEntryCount() - 1; - m_pTopLevelListBox->SelectEntryPos( nSelectionPos, true ); + m_pTopLevelListBox->SelectEntryPos( nSelectionPos ); m_pTopLevelListBox->GetSelectHdl().Call( this ); } @@ -1985,7 +1985,7 @@ SvTreeListEntry* SvxConfigPage::AddFunction( SvxConfigEntry* pNewEntryData = new SvxConfigEntry( aDisplayName, aURL, false ); - pNewEntryData->SetUserDefined( true ); + pNewEntryData->SetUserDefined(); // check that this function is not already in the menu SvxConfigEntry* pParent = GetTopLevelSelection(); @@ -2065,7 +2065,7 @@ SvTreeListEntry* SvxConfigPage::InsertEntry( m_pContentsListBox->Select( pNewEntry ); m_pContentsListBox->MakeVisible( pNewEntry ); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } return pNewEntry; @@ -2197,7 +2197,7 @@ bool SvxConfigPage::MoveEntryData( // insert the source entry at the position after the target pEntries->insert( ++iter, pSourceData ); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); return true; } @@ -2259,7 +2259,7 @@ void SvxMenuConfigPage::Init() ReloadTopLevelListBox(); - m_pTopLevelListBox->SelectEntryPos(0, true); + m_pTopLevelListBox->SelectEntryPos(0); m_pTopLevelListBox->GetSelectHdl().Call(this); } @@ -2298,7 +2298,7 @@ void SvxMenuConfigPage::UpdateButtonStates() m_pMoveUpButton->Enable( false ); m_pMoveDownButton->Enable( false ); - pPopup->EnableItem( ID_BEGIN_GROUP, true ); + pPopup->EnableItem( ID_BEGIN_GROUP ); pPopup->EnableItem( ID_RENAME, false ); pPopup->EnableItem( ID_DELETE, false ); @@ -2318,7 +2318,7 @@ void SvxMenuConfigPage::UpdateButtonStates() if ( pEntryData->IsSeparator() ) { - pPopup->EnableItem( ID_DELETE, true ); + pPopup->EnableItem( ID_DELETE ); pPopup->EnableItem( ID_BEGIN_GROUP, false ); pPopup->EnableItem( ID_RENAME, false ); @@ -2326,9 +2326,9 @@ void SvxMenuConfigPage::UpdateButtonStates() } else { - pPopup->EnableItem( ID_BEGIN_GROUP, true ); - pPopup->EnableItem( ID_DELETE, true ); - pPopup->EnableItem( ID_RENAME, true ); + pPopup->EnableItem( ID_BEGIN_GROUP ); + pPopup->EnableItem( ID_DELETE ); + pPopup->EnableItem( ID_RENAME ); m_pDescriptionField->SetText(pEntryData->GetHelpText()); } @@ -2346,7 +2346,7 @@ void SvxMenuConfigPage::DeleteSelectedTopLevel() ReloadTopLevelListBox(); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified( ); } bool SvxMenuConfigPage::DeleteSelectedContent() @@ -2377,7 +2377,7 @@ bool SvxMenuConfigPage::DeleteSelectedContent() // delete data for menu entry delete pMenuEntry; - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); return true; } @@ -2453,7 +2453,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, MenuSelectHdl, MenuButton *, pButton, void ) ReloadTopLevelListBox(); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } } else if (sIdent == "move") @@ -2470,7 +2470,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, MenuSelectHdl, MenuButton *, pButton, void ) ReloadTopLevelListBox( pDialog->GetSelectedEntry() ); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } } } @@ -2492,19 +2492,19 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, EntrySelectHdl, MenuButton *, pButton, void SvxConfigEntry* pNewEntryData = new SvxConfigEntry( aNewName, aNewName, true ); - pNewEntryData->SetUserDefined( true ); + pNewEntryData->SetUserDefined(); InsertEntry( pNewEntryData ); ReloadTopLevelListBox(); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } } else if (sIdent == "addseparator") { SvxConfigEntry* pNewEntryData = new SvxConfigEntry; - pNewEntryData->SetUserDefined( true ); + pNewEntryData->SetUserDefined(); InsertEntry( pNewEntryData ); } else if (sIdent == "moddelete") @@ -2530,7 +2530,7 @@ IMPL_LINK_TYPED( SvxMenuConfigPage, EntrySelectHdl, MenuButton *, pButton, void pEntry->SetName( aNewName ); m_pContentsListBox->SetEntryText( pActEntry, aNewName ); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } } else @@ -2565,7 +2565,7 @@ IMPL_LINK( SvxMenuConfigPage, NewMenuHdl, Button *, pButton ) { GetSaveInData()->SetEntries( pDialog->GetEntries() ); ReloadTopLevelListBox( pDialog->GetSelectedEntry() ); - GetSaveInData()->SetModified( true ); + GetSaveInData()->SetModified(); } return 0; @@ -2652,8 +2652,8 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog( SvxConfigEntry* pNewEntryData = new SvxConfigEntry( newname, newurl, true ); - pNewEntryData->SetUserDefined( true ); - pNewEntryData->SetMain( true ); + pNewEntryData->SetUserDefined(); + pNewEntryData->SetMain(); pNewMenuEntry = m_pMenuListBox->InsertEntry( stripHotKey( pNewEntryData->GetName() ) ); @@ -2989,11 +2989,11 @@ void SvxToolbarConfigPage::DeleteSelectedTopLevel() // subtract one from the entry count if ( nSelectionPos != m_pTopLevelListBox->GetEntryCount() - 1 ) { - m_pTopLevelListBox->SelectEntryPos( nSelectionPos + 1, true ); + m_pTopLevelListBox->SelectEntryPos( nSelectionPos + 1 ); } else { - m_pTopLevelListBox->SelectEntryPos( nSelectionPos - 1, true ); + m_pTopLevelListBox->SelectEntryPos( nSelectionPos - 1 ); } m_pTopLevelListBox->GetSelectHdl().Call( this ); @@ -3263,7 +3263,7 @@ IMPL_LINK_TYPED( SvxToolbarConfigPage, EntrySelectHdl, MenuButton *, pButton, vo case ID_BEGIN_GROUP: { SvxConfigEntry* pNewEntryData = new SvxConfigEntry; - pNewEntryData->SetUserDefined( true ); + pNewEntryData->SetUserDefined(); SvTreeListEntry* pNewLBEntry = InsertEntry( pNewEntryData ); @@ -3465,7 +3465,7 @@ void SvxToolbarConfigPage::Init() m_aURLToSelect += "standardbar"; } - m_pTopLevelListBox->SelectEntryPos(nPos, true); + m_pTopLevelListBox->SelectEntryPos(nPos); m_pTopLevelListBox->GetSelectHdl().Call(this); } @@ -3754,7 +3754,7 @@ SvxEntries* ToolbarSaveInData::GetEntries() SvxConfigEntry* pEntry = new SvxConfigEntry( uiname, url, true ); - pEntry->SetMain( true ); + pEntry->SetMain(); pEntry->SetStyle( GetSystemStyle( url ) ); @@ -3764,7 +3764,7 @@ SvxEntries* ToolbarSaveInData::GetEntries() OUString custom(CUSTOM_TOOLBAR_STR); if ( systemname.startsWith( custom ) ) { - pEntry->SetUserDefined( true ); + pEntry->SetUserDefined(); } else { @@ -3842,12 +3842,12 @@ SvxEntries* ToolbarSaveInData::GetEntries() SvxConfigEntry* pEntry = new SvxConfigEntry( uiname, url, true, true ); - pEntry->SetMain( true ); + pEntry->SetMain(); pEntry->SetStyle( GetSystemStyle( url ) ); if ( systemname.startsWith( custom ) ) { - pEntry->SetUserDefined( true ); + pEntry->SetUserDefined(); } else { @@ -4162,7 +4162,7 @@ void ToolbarSaveInData::RestoreToolbar( SvxConfigEntry* pToolbar ) if ( IsDocConfig() ) { xToolbarSettings = GetParentConfigManager()->getSettings( url, sal_False ); - pToolbar->SetParentData( true ); + pToolbar->SetParentData(); } else xToolbarSettings = GetConfigManager()->getSettings( url, sal_False ); @@ -4313,22 +4313,22 @@ void SvxToolbarConfigPage::UpdateButtonStates() SvxConfigEntry* pEntryData = static_cast<SvxConfigEntry*>(selection->GetUserData()); if ( pEntryData->IsSeparator() ) - pPopup->EnableItem( ID_DELETE, true ); + pPopup->EnableItem( ID_DELETE ); else { - pPopup->EnableItem( ID_BEGIN_GROUP, true ); - pPopup->EnableItem( ID_DELETE, true ); - pPopup->EnableItem( ID_RENAME, true ); - pPopup->EnableItem( ID_ICON_ONLY, true ); - pPopup->EnableItem( ID_ICON_AND_TEXT, true ); - pPopup->EnableItem( ID_TEXT_ONLY, true ); - pPopup->EnableItem( ID_CHANGE_SYMBOL, true ); + pPopup->EnableItem( ID_BEGIN_GROUP ); + pPopup->EnableItem( ID_DELETE ); + pPopup->EnableItem( ID_RENAME ); + pPopup->EnableItem( ID_ICON_ONLY ); + pPopup->EnableItem( ID_ICON_AND_TEXT ); + pPopup->EnableItem( ID_TEXT_ONLY ); + pPopup->EnableItem( ID_CHANGE_SYMBOL ); if ( !pEntryData->IsUserDefined() ) - pPopup->EnableItem( ID_DEFAULT_COMMAND, true ); + pPopup->EnableItem( ID_DEFAULT_COMMAND ); if ( pEntryData->IsIconModified() ) - pPopup->EnableItem( ID_RESET_SYMBOL, true ); + pPopup->EnableItem( ID_RESET_SYMBOL ); m_pDescriptionField->SetText(pEntryData->GetHelpText()); } @@ -4449,7 +4449,7 @@ IMPL_LINK( SvxToolbarConfigPage, NewToolbarHdl, Button *, pButton ) } pNameDialog->m_pSaveInListBox->SelectEntryPos( - m_pSaveInListBox->GetSelectEntryPos(), true ); + m_pSaveInListBox->GetSelectEntryPos() ); if ( pNameDialog->Execute() == RET_OK ) { @@ -4462,24 +4462,24 @@ IMPL_LINK( SvxToolbarConfigPage, NewToolbarHdl, Button *, pButton ) if ( GetSaveInData() != pData ) { - m_pSaveInListBox->SelectEntryPos( nInsertPos, true ); + m_pSaveInListBox->SelectEntryPos( nInsertPos ); m_pSaveInListBox->GetSelectHdl().Call(this); } SvxConfigEntry* pToolbar = new SvxConfigEntry( aNewName, aNewURL, true ); - pToolbar->SetUserDefined( true ); - pToolbar->SetMain( true ); + pToolbar->SetUserDefined(); + pToolbar->SetMain(); pData->CreateToolbar( pToolbar ); nInsertPos = m_pTopLevelListBox->InsertEntry( pToolbar->GetName() ); m_pTopLevelListBox->SetEntryData( nInsertPos, pToolbar ); - m_pTopLevelListBox->SelectEntryPos( nInsertPos, true ); + m_pTopLevelListBox->SelectEntryPos( nInsertPos ); m_pTopLevelListBox->GetSelectHdl().Call(this); - pData->SetModified( true ); + pData->SetModified(); } return 0; diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx index 7d0b3ade090d..03c4be85376c 100644 --- a/cui/source/customize/cfgutil.cxx +++ b/cui/source/customize/cfgutil.cxx @@ -590,7 +590,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference< css::uno::XComponent OUString aTitle(pImp->m_sDlgMacros); SvTreeListEntry *pNewEntry = InsertEntry( aTitle, NULL ); pNewEntry->SetUserData( pInfo ); - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); aArr.push_back( pInfo ); } else @@ -676,7 +676,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference< css::uno::XComponent { if ( grandchildren[m]->getType() == browse::BrowseNodeTypes::CONTAINER ) { - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); m = grandchildren.getLength(); } } @@ -699,7 +699,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference< css::uno::XComponent SfxGroupInfo_Impl *pInfo = new SfxGroupInfo_Impl( SfxCfgKind::GROUP_STYLES, 0, 0 ); // TODO last parameter should contain user data aArr.push_back( pInfo ); pEntry->SetUserData( pInfo ); - pEntry->EnableChildrenOnDemand( true ); + pEntry->EnableChildrenOnDemand(); } MakeVisible( GetEntry( 0,0 ) ); @@ -752,7 +752,7 @@ Image SfxConfigGroupListBox::GetImage( } if( !factoryURL.isEmpty() ) { - aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL), false ); + aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL) ); } else { @@ -1073,7 +1073,7 @@ void SfxConfigGroupListBox::RequestingChildren( SvTreeListEntry *pEntry ) { if ( grandchildren[m]->getType() == browse::BrowseNodeTypes::CONTAINER ) { - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); m = grandchildren.getLength(); } } diff --git a/cui/source/customize/eventdlg.cxx b/cui/source/customize/eventdlg.cxx index cab1e2622610..4b7d8f8c65db 100644 --- a/cui/source/customize/eventdlg.cxx +++ b/cui/source/customize/eventdlg.cxx @@ -88,7 +88,7 @@ SvxEventConfigPage::SvxEventConfigPage(vcl::Window *pParent, const SfxItemSet& r nPos = m_pSaveInListBox->InsertEntry( utl::ConfigManager::getProductName() ); m_pSaveInListBox->SetEntryData( nPos, new bool(true) ); - m_pSaveInListBox->SelectEntryPos( nPos, true ); + m_pSaveInListBox->SelectEntryPos( nPos ); } void SvxEventConfigPage::LateInit( const uno::Reference< frame::XFrame >& _rxFrame ) @@ -157,7 +157,7 @@ void SvxEventConfigPage::ImplInitDocument() sal_uInt16 nPos = m_pSaveInListBox->InsertEntry( aTitle ); m_pSaveInListBox->SetEntryData( nPos, new bool(false) ); - m_pSaveInListBox->SelectEntryPos( nPos, true ); + m_pSaveInListBox->SelectEntryPos( nPos ); bAppConfig = false; } diff --git a/cui/source/customize/selector.cxx b/cui/source/customize/selector.cxx index 99b17e2984fa..8a5f26979f2f 100644 --- a/cui/source/customize/selector.cxx +++ b/cui/source/customize/selector.cxx @@ -386,7 +386,7 @@ void SvxConfigGroupListBox::fillScriptList( const Reference< browse::XBrowseNode * way to determine if a basic lib had children * without having to ask for them (which forces * the library to be loaded */ - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); } else { @@ -399,7 +399,7 @@ void SvxConfigGroupListBox::fillScriptList( const Reference< browse::XBrowseNode { if ( grandchildren[m]->getType() == browse::BrowseNodeTypes::CONTAINER ) { - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); break; } } @@ -532,7 +532,7 @@ void SvxConfigGroupListBox::Init(bool bShowSlots, const Reference< frame::XFrame SvTreeListEntry *pNewEntry = InsertEntry( aTitle, NULL ); pNewEntry->SetUserData( pInfo ); - pNewEntry->EnableChildrenOnDemand( true ); + pNewEntry->EnableChildrenOnDemand(); aArr.push_back( pInfo ); } else @@ -587,7 +587,7 @@ Image SvxConfigGroupListBox::GetImage( } if( !factoryURL.isEmpty() ) { - aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL), false ); + aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL) ); } else { @@ -987,7 +987,7 @@ IMPL_LINK( SvxScriptSelectorDialog, ClickHdl, Button *, pButton ) // run from Tools/Configure and we should not close it, just hide it if ( !m_bShowSlots ) { - EndDialog( RET_CANCEL ); + EndDialog(); } else { diff --git a/cui/source/dialogs/cuifmsearch.cxx b/cui/source/dialogs/cuifmsearch.cxx index dedad530db94..14994118b9dd 100644 --- a/cui/source/dialogs/cuifmsearch.cxx +++ b/cui/source/dialogs/cuifmsearch.cxx @@ -792,14 +792,14 @@ void FmSearchDialog::LoadParams() if (aParams.bAllFields) { m_prbSingleField->Check(false); - m_prbAllFields->Check(true); + m_prbAllFields->Check(); LINK(this, FmSearchDialog, OnClickedFieldRadios).Call(m_prbAllFields); // OnClickedFieldRadios also calls to RebuildUsedFields } else { m_prbAllFields->Check(false); - m_prbSingleField->Check(true); + m_prbSingleField->Check(); LINK(this, FmSearchDialog, OnClickedFieldRadios).Call(m_prbSingleField); } @@ -837,7 +837,7 @@ void FmSearchDialog::LoadParams() pToCheck = m_pSoundsLikeCJK; if (pToCheck) { - pToCheck->Check(true); + pToCheck->Check(); LINK(this, FmSearchDialog, OnCheckBoxToggled).Call(pToCheck); } @@ -854,9 +854,9 @@ void FmSearchDialog::LoadParams() m_prbSearchForNotNull->Check(false); switch (aParams.nSearchForType) { - case 1: m_prbSearchForNull->Check(true); break; - case 2: m_prbSearchForNotNull->Check(true); break; - default: m_prbSearchForText->Check(true); break; + case 1: m_prbSearchForNull->Check(); break; + case 2: m_prbSearchForNotNull->Check(); break; + default: m_prbSearchForText->Check(); break; } LINK(this, FmSearchDialog, OnClickedFieldRadios).Call(m_prbSearchForText); } diff --git a/cui/source/dialogs/hangulhanjadlg.cxx b/cui/source/dialogs/hangulhanjadlg.cxx index c6ceba7bf335..2ab8c27021ca 100644 --- a/cui/source/dialogs/hangulhanjadlg.cxx +++ b/cui/source/dialogs/hangulhanjadlg.cxx @@ -860,7 +860,7 @@ namespace svx { CheckBox *pBox = _ePrimaryConversionDirection == HHC::eHangulToHanja? m_pHangulOnly : m_pHanjaOnly; - pBox->Check( true ); + pBox->Check(); OnConversionDirectionClicked( pBox ); } } diff --git a/cui/source/dialogs/hyphen.cxx b/cui/source/dialogs/hyphen.cxx index a605af4841dc..82d14bdb9ce6 100644 --- a/cui/source/dialogs/hyphen.cxx +++ b/cui/source/dialogs/hyphen.cxx @@ -405,7 +405,7 @@ IMPL_LINK_NOARG(SvxHyphenWordDialog, CancelHdl_Impl) { m_bBusy = true; m_pHyphWrapper->SpellEnd(); - EndDialog( RET_CANCEL ); + EndDialog(); m_bBusy = false; } return 0; diff --git a/cui/source/dialogs/iconcdlg.cxx b/cui/source/dialogs/iconcdlg.cxx index da604982f671..d6505423d66d 100644 --- a/cui/source/dialogs/iconcdlg.cxx +++ b/cui/source/dialogs/iconcdlg.cxx @@ -97,7 +97,7 @@ void IconChoicePage::ImplInitSettings() vcl::Window* pParent = GetParent(); if ( pParent->IsChildTransparentModeEnabled() && !IsControlBackground() ) { - EnableChildTransparentMode( true ); + EnableChildTransparentMode(); SetParentClipMode( ParentClipMode::NoClip ); SetPaintTransparent( true ); SetBackground(); @@ -186,7 +186,7 @@ IconChoiceDialog::IconChoiceDialog ( vcl::Window* pParent, const OUString& rID, SetCtrlStyle(); m_pIconCtrl->SetClickHdl ( LINK ( this, IconChoiceDialog , ChosePageHdl_Impl ) ); m_pIconCtrl->Show(); - m_pIconCtrl->SetChoiceWithCursor ( true ); + m_pIconCtrl->SetChoiceWithCursor(); m_pIconCtrl->SetSelectionMode( SINGLE_SELECTION ); m_pIconCtrl->SetHelpId( HID_ICCDIALOG_CHOICECTRL ); diff --git a/cui/source/dialogs/insdlg.cxx b/cui/source/dialogs/insdlg.cxx index 8c267f035251..1a5a0f338d9f 100644 --- a/cui/source/dialogs/insdlg.cxx +++ b/cui/source/dialogs/insdlg.cxx @@ -183,7 +183,7 @@ SvInsertOleDlg::SvInsertOleDlg Link<> aLink( LINK( this, SvInsertOleDlg, RadioHdl ) ); m_pRbNewObject->SetClickHdl( aLink ); m_pRbObjectFromfile->SetClickHdl( aLink ); - m_pRbNewObject->Check( true ); + m_pRbNewObject->Check(); RadioHdl( NULL ); } @@ -590,7 +590,7 @@ short SfxInsertFloatingFrameDialog::Execute() if ( nSize == SIZE_NOT_SET ) { - m_pCBMarginWidthDefault->Check( true ); + m_pCBMarginWidthDefault->Check(); m_pNMMarginWidth->SetText( OUString::number(DEFAULT_MARGIN_WIDTH) ); m_pFTMarginWidth->Enable( false ); m_pNMMarginWidth->Enable( false ); @@ -603,7 +603,7 @@ short SfxInsertFloatingFrameDialog::Execute() if ( nSize == SIZE_NOT_SET ) { - m_pCBMarginHeightDefault->Check( true ); + m_pCBMarginHeightDefault->Check(); m_pNMMarginHeight->SetText( OUString::number(DEFAULT_MARGIN_HEIGHT) ); m_pFTMarginHeight->Enable( false ); m_pNMMarginHeight->Enable( false ); diff --git a/cui/source/dialogs/multipat.cxx b/cui/source/dialogs/multipat.cxx index b8b5b04a7202..ba91c93353ce 100644 --- a/cui/source/dialogs/multipat.cxx +++ b/cui/source/dialogs/multipat.cxx @@ -121,7 +121,7 @@ IMPL_LINK_NOARG(SvxPathSelectDialog, AddHdl_Impl) } else { - sal_uInt16 nPos = m_pPathLB->InsertEntry( sInsPath, LISTBOX_APPEND ); + sal_uInt16 nPos = m_pPathLB->InsertEntry( sInsPath ); m_pPathLB->SetEntryData( nPos, new OUString( aURL ) ); } @@ -349,9 +349,9 @@ void SvxPathSelectDialog::SetPath(const OUString& rPath) ::utl::LocalFileHelper::ConvertURLToSystemPath( sPath, sSystemPath ); if ( bIsSystemPath ) - nPos = m_pPathLB->InsertEntry( sSystemPath, LISTBOX_APPEND ); + nPos = m_pPathLB->InsertEntry( sSystemPath ); else - nPos = m_pPathLB->InsertEntry( sPath, LISTBOX_APPEND ); + nPos = m_pPathLB->InsertEntry( sPath ); m_pPathLB->SetEntryData( nPos, new OUString( sPath ) ); } diff --git a/cui/source/dialogs/postdlg.cxx b/cui/source/dialogs/postdlg.cxx index 0db4949f73c2..6355f2c78807 100644 --- a/cui/source/dialogs/postdlg.cxx +++ b/cui/source/dialogs/postdlg.cxx @@ -202,7 +202,7 @@ IMPL_LINK_NOARG(SvxPostItDialog, Stamp) } aStr += rLocaleWrapper.getDate(aDate); aStr += ", "; - aStr += rLocaleWrapper.getTime(aTime, false, false); + aStr += rLocaleWrapper.getTime(aTime, false); aStr += " ----\n"; aStr = convertLineEnd(aStr, GetSystemLineEnd()); diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx index 8a4d6bb6de84..971ff3afa2c4 100644 --- a/cui/source/dialogs/scriptdlg.cxx +++ b/cui/source/dialogs/scriptdlg.cxx @@ -350,7 +350,7 @@ SvTreeListEntry * SFTreeListBox::insertEntry( SvTreeListEntry * p; if( nBitmap == RID_CUIIMG_DOC && !factoryURL.isEmpty() ) { - Image aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL), false ); + Image aImage = SvFileInformationManager::GetFileImage( INetURLObject(factoryURL) ); p = InsertEntry( rText, aImage, aImage, pParent, bChildrenOnDemand, TREELIST_APPEND, aUserData.release()); // XXX possible leak @@ -655,7 +655,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton ) if ( pButton == m_pCloseButton ) { StoreCurrentSelection(); - EndDialog( 0 ); + EndDialog(); } if ( pButton == m_pEditButton || pButton == m_pCreateButton || @@ -757,7 +757,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton ) } } StoreCurrentSelection(); - EndDialog( 0 ); + EndDialog(); } else if ( pButton == m_pEditButton ) { @@ -765,7 +765,7 @@ IMPL_LINK( SvxScriptOrgDialog, ButtonHdl, Button *, pButton ) if ( xInv.is() ) { StoreCurrentSelection(); - EndDialog( 0 ); + EndDialog(); Sequence< Any > args(0); Sequence< Any > outArgs( 0 ); Sequence< sal_Int16 > outIndex; diff --git a/cui/source/dialogs/zoom.cxx b/cui/source/dialogs/zoom.cxx index 85dc0d2881ec..059b5624ed93 100644 --- a/cui/source/dialogs/zoom.cxx +++ b/cui/source/dialogs/zoom.cxx @@ -463,7 +463,7 @@ IMPL_LINK(SvxZoomDialog, OKHdl, Button*, pButton) } else { - EndDialog( RET_CANCEL ); + EndDialog(); } return 0; } diff --git a/cui/source/options/certpath.cxx b/cui/source/options/certpath.cxx index 10c2ebc1bf90..89a4930942a8 100644 --- a/cui/source/options/certpath.cxx +++ b/cui/source/options/certpath.cxx @@ -174,7 +174,7 @@ IMPL_LINK( CertPathDialog, CheckHdl_Impl, SvSimpleTable *, pList ) void CertPathDialog::HandleCheckEntry( SvTreeListEntry* _pEntry ) { - m_pCertPathList->Select( _pEntry, true ); + m_pCertPathList->Select( _pEntry ); SvButtonState eState = m_pCertPathList->GetCheckButtonState( _pEntry ); if (SV_BUTTON_CHECKED == eState) diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx index 7874a065a23e..848625204ca8 100644 --- a/cui/source/options/fontsubs.cxx +++ b/cui/source/options/fontsubs.cxx @@ -180,7 +180,7 @@ bool SvxFontSubstTabPage::FillItemSet( SfxItemSet* ) SubstitutionStruct aAdd; aAdd.sFont = SvTabListBox::GetEntryText(pEntry, 0); aAdd.sReplaceBy = SvTabListBox::GetEntryText(pEntry, 1); - aAdd.bReplaceAlways = SvxFontSubstCheckListBox::IsChecked(pEntry, 0); + aAdd.bReplaceAlways = SvxFontSubstCheckListBox::IsChecked(pEntry); aAdd.bReplaceOnScreenOnly = SvxFontSubstCheckListBox::IsChecked(pEntry, 1); pConfig->AddSubstitution(aAdd); pEntry = m_pCheckLB->Next(pEntry); @@ -459,7 +459,7 @@ void SvxFontSubstCheckListBox::KeyInput( const KeyEvent& rKEvt ) else { sal_uInt16 nCheck = IsChecked(nSelPos, 1) ? 1 : 0; - if(IsChecked(nSelPos, 0)) + if(IsChecked(nSelPos)) nCheck += 2; nCheck--; nCheck &= 3; diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx index 81d9a39266fc..31d4b4308659 100644 --- a/cui/source/options/optasian.cxx +++ b/cui/source/options/optasian.cxx @@ -284,9 +284,9 @@ void SvxAsianLayoutPage::Reset( const SfxItemSet* ) m_pHintFT->Enable(false); } if(bKernWesternText) - m_pCharKerningRB->Check(true); + m_pCharKerningRB->Check(); else - m_pCharPunctKerningRB->Check(true); + m_pCharPunctKerningRB->Check(); switch(nCompress) { case 0 : m_pNoCompressionRB->Check(); break; diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx index 9098a795dbc0..999aeecdea2b 100644 --- a/cui/source/options/optcolor.cxx +++ b/cui/source/options/optcolor.cxx @@ -569,7 +569,7 @@ void ColorConfigWindow_Impl::CreateEntries() aCheckBox->SetText(sSampleText); aFixedText->SetText(sSampleText); Size aCheckSize(aCheckBox->CalcMinimumSize(0x7fffffff)); - Size aFixedSize(aFixedText->CalcMinimumSize(0x7fffffff)); + Size aFixedSize(aFixedText->CalcMinimumSize()); nCheckBoxLabelOffset = aCheckSize.Width() - aFixedSize.Width(); } diff --git a/cui/source/options/optctl.cxx b/cui/source/options/optctl.cxx index 652bba938bf9..4cc080630f75 100644 --- a/cui/source/options/optctl.cxx +++ b/cui/source/options/optctl.cxx @@ -32,8 +32,8 @@ IMPL_LINK_NOARG(SvxCTLOptionsPage, SequenceCheckingCB_Hdl) // #i48117#: by default restricted and type&replace have to be switched on if(bIsSequenceChecking) { - m_pTypeReplaceCB->Check( true ); - m_pRestrictedCB->Check( true ); + m_pTypeReplaceCB->Check(); + m_pRestrictedCB->Check(); } return 0; } diff --git a/cui/source/options/optdict.cxx b/cui/source/options/optdict.cxx index 3a0bd9ebfaa7..7026e5f3664f 100644 --- a/cui/source/options/optdict.cxx +++ b/cui/source/options/optdict.cxx @@ -188,7 +188,7 @@ IMPL_LINK_NOARG(SvxNewDictionaryDialog, OKHdl_Impl) ErrorHandler::HandleError( *new StringErrorInfo( ERRCODE_SVX_LINGU_DICT_NOTWRITEABLE, sDict ) ); - EndDialog( RET_CANCEL ); + EndDialog(); } if (xDicList.is() && xNewDic.is()) diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx index 5ede579184e7..af543b331743 100644 --- a/cui/source/options/optfltr.cxx +++ b/cui/source/options/optfltr.cxx @@ -319,9 +319,9 @@ void OfaMSFilterTabPage2::Reset( const SfxItemSet* ) m_pCheckLB->SetUpdateMode( true ); if (rOpt.IsCharBackground2Highlighting()) - aHighlightingRB->Check(true); + aHighlightingRB->Check(); else - aShadingRB->Check(true); + aShadingRB->Check(); aHighlightingRB->SaveValue(); } diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index bcdcd41547c9..3ed38ddeff13 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cxx @@ -1104,7 +1104,7 @@ OfaLanguagesTabPage::OfaLanguagesTabPage(vcl::Window* pParent, const SfxItemSet& m_pComplexLanguageLB->SetLanguageList( SvxLanguageListFlags::CTL | SvxLanguageListFlags::ONLY_KNOWN, true, false, true ); m_pComplexLanguageLB->InsertDefaultLanguage( css::i18n::ScriptType::COMPLEX ); - m_pLocaleSettingLB->SetLanguageList( SvxLanguageListFlags::ALL | SvxLanguageListFlags::ONLY_KNOWN, false, false, false); + m_pLocaleSettingLB->SetLanguageList( SvxLanguageListFlags::ALL | SvxLanguageListFlags::ONLY_KNOWN, false, false); m_pLocaleSettingLB->InsertSystemLanguage( ); const NfCurrencyTable& rCurrTab = SvNumberFormatter::GetTheCurrencyTable(); @@ -1603,7 +1603,7 @@ void OfaLanguagesTabPage::Reset( const SfxItemSet* rSet ) { m_pWesternLanguageLB->GrabFocus(); m_pCurrentDocCB->Enable(true); - m_pCurrentDocCB->Check(true); + m_pCurrentDocCB->Check(); } } @@ -1639,7 +1639,7 @@ namespace void lcl_checkLanguageCheckBox(CheckBox* _rCB,bool _bNewValue,bool _bOldValue) { if ( _bNewValue ) - _rCB->Check(true); + _rCB->Check(); else _rCB->Check( _bOldValue ); // #i15082# do not call SaveValue() in running dialog... diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx index 61b1870227f8..59bee66ad0a7 100644 --- a/cui/source/options/optinet2.cxx +++ b/cui/source/options/optinet2.cxx @@ -689,7 +689,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl) if ( xMasterPasswd->changeMasterPassword( Reference< task::XInteractionHandler >() ) ) { m_pMasterPasswordPB->Enable( true ); - m_pMasterPasswordCB->Check( true ); + m_pMasterPasswordCB->Check(); m_pMasterPasswordCB->Enable( true ); m_pMasterPasswordFT->Enable( true ); m_pShowConnectionsPB->Enable( true ); @@ -708,7 +708,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl) if( RET_YES == nRet ) { xMasterPasswd->allowPersistentStoring( sal_False ); - m_pMasterPasswordCB->Check( true ); + m_pMasterPasswordCB->Check(); m_pMasterPasswordPB->Enable( false ); m_pMasterPasswordCB->Enable( false ); m_pMasterPasswordFT->Enable( false ); @@ -716,7 +716,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, SavePasswordHdl) } else { - m_pSavePasswordsCB->Check( true ); + m_pSavePasswordsCB->Check(); m_pMasterPasswordPB->Enable( true ); m_pShowConnectionsPB->Enable( true ); } @@ -776,7 +776,7 @@ IMPL_LINK_NOARG(SvxSecurityTabPage, MasterPasswordCBHdl) } else { - m_pMasterPasswordCB->Check( true ); + m_pMasterPasswordCB->Check(); m_pMasterPasswordPB->Enable( true ); m_pShowConnectionsPB->Enable( true ); } @@ -876,7 +876,7 @@ void SvxSecurityTabPage::InitControls() m_pMasterPasswordPB->Enable( false ); m_pMasterPasswordCB->Enable( false ); - m_pMasterPasswordCB->Check( true ); + m_pMasterPasswordCB->Check(); m_pMasterPasswordFT->Enable( false ); m_pShowConnectionsPB->Enable( false ); @@ -890,14 +890,14 @@ void SvxSecurityTabPage::InitControls() { m_pMasterPasswordCB->Enable( true ); m_pShowConnectionsPB->Enable( true ); - m_pSavePasswordsCB->Check( true ); + m_pSavePasswordsCB->Check(); if ( xMasterPasswd->isDefaultMasterPasswordUsed() ) m_pMasterPasswordCB->Check( false ); else { m_pMasterPasswordPB->Enable( true ); - m_pMasterPasswordCB->Check( true ); + m_pMasterPasswordCB->Check(); m_pMasterPasswordFT->Enable( true ); } } diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx index 14c2a22563d3..6001535501d1 100644 --- a/cui/source/options/optjava.cxx +++ b/cui/source/options/optjava.cxx @@ -555,7 +555,7 @@ void SvxJavaOptionsPage::AddJRE( JavaInfo* _pInfo ) void SvxJavaOptionsPage::HandleCheckEntry( SvTreeListEntry* _pEntry ) { - m_pJavaList->Select( _pEntry, true ); + m_pJavaList->Select( _pEntry ); SvButtonState eState = m_pJavaList->GetCheckButtonState( _pEntry ); if ( SV_BUTTON_CHECKED == eState ) @@ -1001,7 +1001,7 @@ IMPL_LINK_NOARG(SvxJavaClassPathDlg, AddArchiveHdl_Impl) OUString sFile = aURL.getFSysPath( INetURLObject::FSYS_DETECT ); if ( !IsPathDuplicate( sURL ) ) { - sal_Int32 nPos = m_pPathList->InsertEntry( sFile, SvFileInformationManager::GetImage( aURL, false ) ); + sal_Int32 nPos = m_pPathList->InsertEntry( sFile, SvFileInformationManager::GetImage( aURL ) ); m_pPathList->SelectEntryPos( nPos ); } else @@ -1038,7 +1038,7 @@ IMPL_LINK_NOARG(SvxJavaClassPathDlg, AddPathHdl_Impl) OUString sNewFolder = aURL.getFSysPath( INetURLObject::FSYS_DETECT ); if ( !IsPathDuplicate( sFolderURL ) ) { - sal_Int32 nPos = m_pPathList->InsertEntry( sNewFolder, SvFileInformationManager::GetImage( aURL, false ) ); + sal_Int32 nPos = m_pPathList->InsertEntry( sNewFolder, SvFileInformationManager::GetImage( aURL ) ); m_pPathList->SelectEntryPos( nPos ); } else @@ -1134,7 +1134,7 @@ void SvxJavaClassPathDlg::SetClassPath( const OUString& _rPath ) OUString sToken = _rPath.getToken( 0, CLASSPATH_DELIMITER, nIdx ); INetURLObject aURL( sToken, INetURLObject::FSYS_DETECT ); OUString sPath = aURL.getFSysPath( INetURLObject::FSYS_DETECT ); - m_pPathList->InsertEntry( sPath, SvFileInformationManager::GetImage( aURL, false ) ); + m_pPathList->InsertEntry( sPath, SvFileInformationManager::GetImage( aURL ) ); } // select first entry m_pPathList->SelectEntryPos(0); diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx index 5e550a22b3ce..8c0c5941026a 100644 --- a/cui/source/options/personalization.cxx +++ b/cui/source/options/personalization.cxx @@ -203,7 +203,7 @@ IMPL_LINK( SelectPersonaDialog, ActionCancel, PushButton*, /* pButton */ ) if( m_rSearchThread.is() ) m_rSearchThread->StopExecution(); - EndDialog( RET_CANCEL ); + EndDialog(); return 0; } @@ -417,7 +417,7 @@ void SvxPersonalizationTabPage::LoadDefaultImages() aStream.ReadLine( aLine ); OUString aPersonaSetting( OStringToOUString( aLine, RTL_TEXTENCODING_UTF8 ) ); OUString aPreviewFile; - sal_Int32 nNewIndex = aPersonaSetting.indexOf( ';', 0 ); + sal_Int32 nNewIndex = aPersonaSetting.indexOf( ';' ); if( nNewIndex < 0 ) break; aPreviewFile = aPersonaSetting.copy( 0, nNewIndex ); @@ -518,7 +518,7 @@ IMPL_LINK( SvxPersonalizationTabPage, SelectInstalledPersona, ListBox*, ) m_pExtensionPersonaPreview->Show(); sal_Int32 nSelectedPos = m_pPersonaList->GetSelectEntryPos(); OUString aSettings = m_vExtensionPersonaSettings[nSelectedPos]; - sal_Int32 nIndex = aSettings.indexOf( ';', 0 ); + sal_Int32 nIndex = aSettings.indexOf( ';' ); OUString aPreviewFile = aSettings.copy( 0, nIndex ); m_aPersonaSettings = aSettings.copy( nIndex + 1 ); diff --git a/cui/source/options/radiobtnbox.cxx b/cui/source/options/radiobtnbox.cxx index 500617bedf28..1f1a422d9c84 100644 --- a/cui/source/options/radiobtnbox.cxx +++ b/cui/source/options/radiobtnbox.cxx @@ -62,7 +62,7 @@ void SvxRadioButtonListBox::KeyInput( const KeyEvent& rKEvt ) void SvxRadioButtonListBox::HandleEntryChecked( SvTreeListEntry* _pEntry ) { - Select( _pEntry, true ); + Select( _pEntry ); SvButtonState eState = GetCheckButtonState( _pEntry ); if ( SV_BUTTON_CHECKED == eState ) diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx index 303ecba50b49..3cb968246754 100644 --- a/cui/source/options/treeopt.cxx +++ b/cui/source/options/treeopt.cxx @@ -793,7 +793,7 @@ void OfaTreeOptionsDialog::InitTreeAndHandler() WB_CLIPCHILDREN | WB_HSCROLL | WB_FORCE_MAKEVISIBLE | WB_QUICK_SEARCH ); pTreeLB->SetSpaceBetweenEntries( 0 ); pTreeLB->SetSelectionMode( SINGLE_SELECTION ); - pTreeLB->SetSublistOpenWithLeftRight( true ); + pTreeLB->SetSublistOpenWithLeftRight(); pTreeLB->SetExpandedHdl( LINK( this, OfaTreeOptionsDialog, ExpandedHdl_Impl ) ); pTreeLB->SetSelectHdl( LINK( this, OfaTreeOptionsDialog, ShowPageHdl_Impl ) ); pBackPB->SetClickHdl( LINK( this, OfaTreeOptionsDialog, BackHdl_Impl ) ); diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index 3af51b13ae91..57ab3849edf1 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -164,7 +164,7 @@ static bool lcl_FindEntry( ListBox& rLB, const OUString& rEntry, { if( 0 == rCmpClass.compareString(rEntry, rLB.GetEntry(i) )) { - rLB.SelectEntryPos(i, true); + rLB.SelectEntryPos(i); return true; } } @@ -525,25 +525,25 @@ bool OfaSwAutoFmtOptionsPage::FillItemSet( SfxItemSet* ) SvxSwAutoFormatFlags *pOpt = &pAutoCorrect->GetSwFlags(); long nFlags = pAutoCorrect->GetFlags(); - bool bCheck = m_pCheckLB->IsChecked(USE_REPLACE_TABLE, CBCOL_FIRST); + bool bCheck = m_pCheckLB->IsChecked(USE_REPLACE_TABLE); bModified |= pOpt->bAutoCorrect != bCheck; pOpt->bAutoCorrect = bCheck; pAutoCorrect->SetAutoCorrFlag(Autocorrect, m_pCheckLB->IsChecked(USE_REPLACE_TABLE, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(CORR_UPPER, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(CORR_UPPER); bModified |= pOpt->bCapitalStartWord != bCheck; pOpt->bCapitalStartWord = bCheck; pAutoCorrect->SetAutoCorrFlag(CapitalStartWord, m_pCheckLB->IsChecked(CORR_UPPER, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(BEGIN_UPPER, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(BEGIN_UPPER); bModified |= pOpt->bCapitalStartSentence != bCheck; pOpt->bCapitalStartSentence = bCheck; pAutoCorrect->SetAutoCorrFlag(CapitalStartSentence, m_pCheckLB->IsChecked(BEGIN_UPPER, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(BOLD_UNDERLINE, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(BOLD_UNDERLINE); bModified |= pOpt->bChgWeightUnderl != bCheck; pOpt->bChgWeightUnderl = bCheck; pAutoCorrect->SetAutoCorrFlag(ChgWeightUnderl, @@ -555,21 +555,21 @@ bool OfaSwAutoFmtOptionsPage::FillItemSet( SfxItemSet* ) pAutoCorrect->SetAutoCorrFlag(CorrectCapsLock, m_pCheckLB->IsChecked(CORRECT_CAPS_LOCK, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(DETECT_URL, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(DETECT_URL); bModified |= pOpt->bSetINetAttr != bCheck; pOpt->bSetINetAttr = bCheck; pAutoCorrect->SetAutoCorrFlag(SetINetAttr, m_pCheckLB->IsChecked(DETECT_URL, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(DEL_EMPTY_NODE, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(DEL_EMPTY_NODE); bModified |= pOpt->bDelEmptyNode != bCheck; pOpt->bDelEmptyNode = bCheck; - bCheck = m_pCheckLB->IsChecked(REPLACE_USER_COLL, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(REPLACE_USER_COLL); bModified |= pOpt->bChgUserColl != bCheck; pOpt->bChgUserColl = bCheck; - bCheck = m_pCheckLB->IsChecked(REPLACE_BULLETS, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(REPLACE_BULLETS); bModified |= pOpt->bChgEnumNum != bCheck; pOpt->bChgEnumNum = bCheck; bModified |= aBulletFont != pOpt->aBulletFont; @@ -582,7 +582,7 @@ bool OfaSwAutoFmtOptionsPage::FillItemSet( SfxItemSet* ) pOpt->aByInputBulletFont = aByInputBulletFont; pOpt->cByInputBullet = sByInputBulletChar[0]; - bCheck = m_pCheckLB->IsChecked(MERGE_SINGLE_LINE_PARA, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(MERGE_SINGLE_LINE_PARA); bModified |= pOpt->bRightMargin != bCheck; pOpt->bRightMargin = bCheck; bModified |= nPercent != pOpt->nRightMargin; @@ -604,20 +604,20 @@ bool OfaSwAutoFmtOptionsPage::FillItemSet( SfxItemSet* ) bModified |= pOpt->bReplaceStyles != bCheck; pOpt->bReplaceStyles = bCheck; - bCheck = m_pCheckLB->IsChecked(REPLACE_DASHES, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(REPLACE_DASHES); bModified |= pOpt->bChgToEnEmDash != bCheck; pOpt->bChgToEnEmDash = bCheck; pAutoCorrect->SetAutoCorrFlag(ChgToEnEmDash, m_pCheckLB->IsChecked(REPLACE_DASHES, CBCOL_SECOND)); - bCheck = m_pCheckLB->IsChecked(DEL_SPACES_AT_STT_END, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(DEL_SPACES_AT_STT_END); bModified |= pOpt->bAFormatDelSpacesAtSttEnd != bCheck; pOpt->bAFormatDelSpacesAtSttEnd = bCheck; bCheck = m_pCheckLB->IsChecked(DEL_SPACES_AT_STT_END, CBCOL_SECOND); bModified |= pOpt->bAFormatByInpDelSpacesAtSttEnd != bCheck; pOpt->bAFormatByInpDelSpacesAtSttEnd = bCheck; - bCheck = m_pCheckLB->IsChecked(DEL_SPACES_BETWEEN_LINES, CBCOL_FIRST); + bCheck = m_pCheckLB->IsChecked(DEL_SPACES_BETWEEN_LINES); bModified |= pOpt->bAFormatDelSpacesBetweenLines != bCheck; pOpt->bAFormatDelSpacesBetweenLines = bCheck; bCheck = m_pCheckLB->IsChecked(DEL_SPACES_BETWEEN_LINES, CBCOL_SECOND); @@ -852,7 +852,7 @@ void OfaACorrCheckListBox::KeyInput( const KeyEvent& rKEvt ) else { sal_uInt16 nCheck = IsChecked(nSelPos, 1) ? 1 : 0; - if(IsChecked(nSelPos, 0)) + if(IsChecked(nSelPos)) nCheck += 2; nCheck--; nCheck &= 3; @@ -1108,7 +1108,7 @@ void OfaAutocorrReplacePage::RefillReplaceBox(bool bFromReset, } SfxViewShell* pViewShell = SfxViewShell::Current(); - if( pViewShell && pViewShell->HasSelection( true ) ) + if( pViewShell && pViewShell->HasSelection() ) { bHasSelectionText = true; const OUString sSelection( pViewShell->GetSelectionText() ); @@ -1928,13 +1928,13 @@ bool OfaQuoteTabPage::FillItemSet( SfxItemSet* ) { SvxSwAutoFormatFlags *pOpt = &pAutoCorrect->GetSwFlags(); - bool bCheck = m_pSwCheckLB->IsChecked(ADD_NONBRK_SPACE, CBCOL_FIRST); + bool bCheck = m_pSwCheckLB->IsChecked(ADD_NONBRK_SPACE); bModified |= pOpt->bAddNonBrkSpace != bCheck; pOpt->bAddNonBrkSpace = bCheck; pAutoCorrect->SetAutoCorrFlag(AddNonBrkSpace, m_pSwCheckLB->IsChecked(ADD_NONBRK_SPACE, CBCOL_SECOND)); - bCheck = m_pSwCheckLB->IsChecked(REPLACE_1ST, CBCOL_FIRST); + bCheck = m_pSwCheckLB->IsChecked(REPLACE_1ST); bModified |= pOpt->bChgOrdinalNumber != bCheck; pOpt->bChgOrdinalNumber = bCheck; pAutoCorrect->SetAutoCorrFlag(ChgOrdinalNumber, diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx index 70b602de1c48..e5841f02e6e9 100644 --- a/cui/source/tabpages/backgrnd.cxx +++ b/cui/source/tabpages/backgrnd.cxx @@ -618,7 +618,7 @@ void SvxBackgroundTabPage::ResetFromWallpaperItem( const SfxItemSet& rSet ) // We now have always a link to the background bLinkOnly = true; - m_pBtnLink->Check( true ); + m_pBtnLink->Check(); m_pBtnLink->Show( false ); } @@ -1255,7 +1255,7 @@ IMPL_LINK_NOARG(SvxBackgroundTabPage, BrowseHdl_Impl) // activate preview, so that the user sees which // graphic he has chosen if ( !m_pBtnLink->IsChecked() && !m_pBtnPreview->IsChecked() ) - m_pBtnPreview->Check( true ); + m_pBtnPreview->Check(); // timer-delayed loading of the graphic pPageImpl->pLoadIdle->Start(); } @@ -1470,7 +1470,7 @@ void SvxBackgroundTabPage::FillControls_Impl( const SvxBrushItem& rBgdAttr, DBG_ASSERT( aObj.GetProtocol() != INetProtocol::NotValid, "Invalid URL!" ); #endif aBgdGraphicPath = aStrLink; - m_pBtnLink->Check( true ); + m_pBtnLink->Check(); m_pBtnLink->Enable(); } else diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx index f61e89b7a8e2..b9cdb4517f5b 100644 --- a/cui/source/tabpages/border.cxx +++ b/cui/source/tabpages/border.cxx @@ -700,7 +700,7 @@ bool SvxBorderTabPage::FillItemSet( SfxItemSet* rCoreAttrs ) aBoxItem.SetDistance(pOldBoxItem->GetDistance(SvxBoxItemLine::TOP ), SvxBoxItemLine::TOP); aBoxItem.SetDistance(pOldBoxItem->GetDistance(SvxBoxItemLine::BOTTOM), SvxBoxItemLine::BOTTOM); } - aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true ); + aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE ); } else aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, false ); diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index cb9b8be5a27c..4d822c0afc3b 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -1262,7 +1262,7 @@ namespace { void enableRelativeMode( SvxCharNamePage* _pPage, FontSizeBox* _pFontSizeLB, sal_uInt16 _nHeightWhich ) { - _pFontSizeLB->EnableRelativeMode( 5, 995, 5 ); // min 5%, max 995%, step 5 + _pFontSizeLB->EnableRelativeMode( 5, 995 ); // min 5%, max 995%, step 5 const SvxFontHeightItem& rHeightItem = static_cast<const SvxFontHeightItem&>(_pPage->GetItemSet().GetParent()->Get( _nHeightWhich )); @@ -1273,7 +1273,7 @@ namespace // based on the current height: // - negative until minimum of 2 pt // - positive until maximum of 999 pt - _pFontSizeLB->EnablePtRelativeMode( sal::static_int_cast< short >(-(nCurHeight - 20)), (9999 - nCurHeight), 10 ); + _pFontSizeLB->EnablePtRelativeMode( sal::static_int_cast< short >(-(nCurHeight - 20)), (9999 - nCurHeight) ); } } @@ -3035,7 +3035,7 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet ) if ( nEsc > 0 ) { nFac = 1; - m_pHighPosBtn->Check( true ); + m_pHighPosBtn->Check(); if ( nEsc == DFLT_ESC_AUTO_SUPER ) { nEsc = DFLT_ESC_SUPER; @@ -3045,7 +3045,7 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet ) else { nFac = -1; - m_pLowPosBtn->Check( true ); + m_pLowPosBtn->Check(); if ( nEsc == DFLT_ESC_AUTO_SUB ) { nEsc = DFLT_ESC_SUB; @@ -3067,8 +3067,8 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet ) } else { - m_pNormalPosBtn->Check( true ); - m_pHighLowRB->Check( true ); + m_pNormalPosBtn->Check(); + m_pHighLowRB->Check(); PositionHdl_Impl( NULL ); } //the height has to be set after the handler is called to keep the value also if the escapement is zero @@ -3175,13 +3175,13 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet ) const SvxCharRotateItem& rItem = static_cast<const SvxCharRotateItem&>( rSet->Get( nWhich )); if (rItem.IsBottomToTop()) - m_p90degRB->Check( true ); + m_p90degRB->Check(); else if (rItem.IsTopToBotton()) - m_p270degRB->Check( true ); + m_p270degRB->Check(); else { DBG_ASSERT( 0 == rItem.GetValue(), "incorrect value" ); - m_p0degRB->Check( true ); + m_p0degRB->Check(); } m_pFitToLineCB->Check( rItem.IsFitToLine() ); } @@ -3194,7 +3194,7 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet ) m_p270degRB->Check( false ); } else - m_p0degRB->Check( true ); + m_p0degRB->Check(); m_pFitToLineCB->Check( false ); } diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx index 01e9d53ef63e..4b6e643a932d 100644 --- a/cui/source/tabpages/numpages.cxx +++ b/cui/source/tabpages/numpages.cxx @@ -313,7 +313,7 @@ void SvxSingleNumPickTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } } @@ -480,7 +480,7 @@ void SvxBulletPickTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } @@ -686,7 +686,7 @@ void SvxNumPickTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } @@ -948,7 +948,7 @@ void SvxBitmapPickTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } @@ -1363,14 +1363,14 @@ void SvxNumOptionsTabPage::ActivatePage(const SfxItemSet& rSet) m_pLevelLB->SetUpdateMode(false); m_pLevelLB->SetNoSelection(); if(bModified) - m_pLevelLB->SelectEntryPos( 0, true); + m_pLevelLB->SelectEntryPos( 0 ); else m_pLevelLB->SelectEntryPos( pActNum->GetLevelCount(), nActNumLvl == SAL_MAX_UINT16); if(nActNumLvl != SAL_MAX_UINT16) for(sal_uInt16 i = 0; i < pActNum->GetLevelCount(); i++) { if(nActNumLvl & nMask) - m_pLevelLB->SelectEntryPos( i, true); + m_pLevelLB->SelectEntryPos( i ); nMask <<= 1 ; } m_pLevelLB->SetUpdateMode(true); @@ -1411,7 +1411,7 @@ void SvxNumOptionsTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } @@ -1443,17 +1443,17 @@ void SvxNumOptionsTabPage::Reset( const SfxItemSet* rSet ) m_pLevelLB->SetNoSelection(); if(nActNumLvl == SAL_MAX_UINT16 && !bModified) { - m_pLevelLB->SelectEntryPos( 0, true); + m_pLevelLB->SelectEntryPos( 0 ); } else if (nActNumLvl == SAL_MAX_UINT16) { - m_pLevelLB->SelectEntryPos( pSaveNum->GetLevelCount(), true); + m_pLevelLB->SelectEntryPos( pSaveNum->GetLevelCount() ); } else for(sal_uInt16 i = 0; i < pSaveNum->GetLevelCount(); i++) { if(nActNumLvl & nMask) - m_pLevelLB->SelectEntryPos( i, true); + m_pLevelLB->SelectEntryPos( i ); nMask <<= 1 ; } m_pLevelLB->SetUpdateMode(true); @@ -3136,14 +3136,14 @@ void SvxNumPositionTabPage::ActivatePage(const SfxItemSet& rSet) m_pLevelLB->SetUpdateMode(false); m_pLevelLB->SetNoSelection(); if(bModified) - m_pLevelLB->SelectEntryPos( 0, true); + m_pLevelLB->SelectEntryPos( 0 ); else m_pLevelLB->SelectEntryPos( pActNum->GetLevelCount(), nActNumLvl == SAL_MAX_UINT16); if(nActNumLvl != SAL_MAX_UINT16) for(sal_uInt16 i = 0; i < pActNum->GetLevelCount(); i++) { if(nActNumLvl & nMask) - m_pLevelLB->SelectEntryPos( i, true); + m_pLevelLB->SelectEntryPos( i ); nMask <<= 1 ; } m_pRelativeCB->Enable(nActNumLvl != 1); @@ -3195,7 +3195,7 @@ void SvxNumPositionTabPage::Reset( const SfxItemSet* rSet ) if( eState != SfxItemState::SET ) { - pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId, true ) ); + pItem = &static_cast< const SvxNumBulletItem& >( rSet->Get( nNumItemId ) ); eState = SfxItemState::SET; } @@ -3226,18 +3226,18 @@ void SvxNumPositionTabPage::Reset( const SfxItemSet* rSet ) m_pLevelLB->SetNoSelection(); if(nActNumLvl == SAL_MAX_UINT16 && !bModified) { - m_pLevelLB->SelectEntryPos( 0, true); + m_pLevelLB->SelectEntryPos( 0 ); } else if (nActNumLvl == SAL_MAX_UINT16) { - m_pLevelLB->SelectEntryPos( pSaveNum->GetLevelCount(), true); + m_pLevelLB->SelectEntryPos( pSaveNum->GetLevelCount() ); } else { for(sal_uInt16 i = 0; i < pSaveNum->GetLevelCount(); i++) { if(nActNumLvl & nMask) - m_pLevelLB->SelectEntryPos( i, true); + m_pLevelLB->SelectEntryPos( i ); nMask <<= 1; } } diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx index 111dac960a4b..1b13d74fbd30 100644 --- a/cui/source/tabpages/paragrph.cxx +++ b/cui/source/tabpages/paragrph.cxx @@ -1289,8 +1289,8 @@ IMPL_LINK_NOARG(SvxParaAlignTabPage, TextDirectionHdl_Impl) switch ( eDir ) { // check the default alignment for this text direction - case FRMDIR_HORI_LEFT_TOP : m_pLeft->Check( true ); break; - case FRMDIR_HORI_RIGHT_TOP : m_pRight->Check( true ); break; + case FRMDIR_HORI_LEFT_TOP : m_pLeft->Check(); break; + case FRMDIR_HORI_RIGHT_TOP : m_pRight->Check(); break; case FRMDIR_ENVIRONMENT : /* do nothing */ break; default: { @@ -1636,7 +1636,7 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet* rSet ) } else if ( SfxItemState::DONTCARE == eItemState ) { - m_pApplyCollBtn->EnableTriState( true ); + m_pApplyCollBtn->EnableTriState(); m_pApplyCollBtn->SetState( TRISTATE_INDET ); m_pApplyCollBox->SetNoSelection(); } diff --git a/cui/source/tabpages/tabarea.cxx b/cui/source/tabpages/tabarea.cxx index 1bdaa179baf2..13f031668f36 100644 --- a/cui/source/tabpages/tabarea.cxx +++ b/cui/source/tabpages/tabarea.cxx @@ -227,7 +227,7 @@ IMPL_LINK_NOARG(SvxAreaTabDialog, CancelHdlImpl) { SavePalettes(); - EndDialog( RET_CANCEL ); + EndDialog(); return 0; } diff --git a/cui/source/tabpages/tabline.cxx b/cui/source/tabpages/tabline.cxx index 6049c8cdd1df..2e96f608f10e 100644 --- a/cui/source/tabpages/tabline.cxx +++ b/cui/source/tabpages/tabline.cxx @@ -187,7 +187,7 @@ IMPL_LINK_NOARG(SvxLineTabDialog, CancelHdlImpl) { SavePalettes(); - EndDialog( RET_CANCEL ); + EndDialog(); return 0; } diff --git a/cui/source/tabpages/tabstpge.cxx b/cui/source/tabpages/tabstpge.cxx index eb0ab81702e0..73f8ae4d64c9 100644 --- a/cui/source/tabpages/tabstpge.cxx +++ b/cui/source/tabpages/tabstpge.cxx @@ -395,8 +395,8 @@ void SvxTabulatorTabPage::InitTabPos_Impl( sal_uInt16 nTabPos ) nTabPos = 0; // Switch off all RadioButtons for a start - m_pLeftTab->Check( true ); - m_pNoFillChar->Check( true ); + m_pLeftTab->Check(); + m_pNoFillChar->Check(); if( m_pTabBox->GetEntryCount() > 0 ) { diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx index 2145e1c47679..753bb9249a47 100644 --- a/cui/source/tabpages/tpline.cxx +++ b/cui/source/tabpages/tpline.cxx @@ -212,7 +212,7 @@ SvxLineTabPage::SvxLineTabPage m_pSymbolHeightMF->SetModifyHdl(LINK(this, SvxLineTabPage, SizeHdl_Impl)); m_pSymbolRatioCB->SetClickHdl(LINK(this, SvxLineTabPage, RatioHdl_Impl)); - m_pSymbolRatioCB->Check(true); + m_pSymbolRatioCB->Check(); ShowSymbolControls(false); nActLineWidth = -1; |