diff options
author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2018-02-11 11:02:42 +0100 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-02-12 08:03:12 +0100 |
commit | 4f759834d37c78874eb30d5f3010fe41062532ed (patch) | |
tree | 4bc915f62288fdb17eae370e13e22255d4bbc74f | |
parent | e3546db362e9dfed94572d164359a0fc1eae742f (diff) |
cppcheck useInitializationList
unique_ptr don't need explicit nullptr initialization, same
goes for VclPtr in ImpEditEngine.
Change-Id: Id8f3163c2719bee6ee2724cae98449d564be5535
Reviewed-on: https://gerrit.libreoffice.org/49559
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r-- | connectivity/source/drivers/macab/MacabRecord.cxx | 1 | ||||
-rw-r--r-- | editeng/source/editeng/impedit.cxx | 3 | ||||
-rw-r--r-- | editeng/source/editeng/impedit2.cxx | 6 | ||||
-rw-r--r-- | linguistic/source/spelldsp.cxx | 2 | ||||
-rw-r--r-- | svtools/source/contnr/imivctl2.cxx | 1 | ||||
-rw-r--r-- | writerfilter/source/dmapper/TrackChangesHandler.cxx | 4 |
6 files changed, 2 insertions, 15 deletions
diff --git a/connectivity/source/drivers/macab/MacabRecord.cxx b/connectivity/source/drivers/macab/MacabRecord.cxx index 0df2588bf67d..89a5094c48e0 100644 --- a/connectivity/source/drivers/macab/MacabRecord.cxx +++ b/connectivity/source/drivers/macab/MacabRecord.cxx @@ -37,7 +37,6 @@ using namespace ::dbtools; MacabRecord::MacabRecord() { size = 0; - fields = nullptr; } diff --git a/editeng/source/editeng/impedit.cxx b/editeng/source/editeng/impedit.cxx index a7b0cfb1b272..5e4ce991659c 100644 --- a/editeng/source/editeng/impedit.cxx +++ b/editeng/source/editeng/impedit.cxx @@ -71,14 +71,11 @@ ImpEditView::ImpEditView( EditView* pView, EditEngine* pEng, vcl::Window* pWindo pEditView = pView; pEditEngine = pEng; pOutWin = pWindow; - pPointer = nullptr; - pBackgroundColor = nullptr; mpViewShell = nullptr; mpOtherShell = nullptr; nScrollDiffX = 0; nExtraCursorFlags = GetCursorFlags::NONE; nCursorBidiLevel = CURSOR_BIDILEVEL_DONTKNOW; - pCursor = nullptr; bReadOnly = false; bClickedInSelection = false; eSelectionMode = EESelectionMode::Std; diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index a72dfd647f3e..7f0aa10007f3 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -111,18 +111,12 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool* pItemPool ) : mbNbspRunNext(false) { pEditEngine = pEE; - pRefDev = nullptr; - pVirtDev = nullptr; pActiveView = nullptr; - pSpellInfo = nullptr; pConvInfo = nullptr; pTextObjectPool = nullptr; - mpIMEInfos = nullptr; pStylePool = nullptr; pUndoManager = nullptr; pUndoMarkSelection = nullptr; - pTextRanger = nullptr; - pCTLOptions = nullptr; nCurTextHeight = 0; nCurTextHeightNTP = 0; diff --git a/linguistic/source/spelldsp.cxx b/linguistic/source/spelldsp.cxx index 6cd6c8003233..d792ba390033 100644 --- a/linguistic/source/spelldsp.cxx +++ b/linguistic/source/spelldsp.cxx @@ -178,8 +178,6 @@ bool SvcListHasLanguage( SpellCheckerDispatcher::SpellCheckerDispatcher( LngSvcMgr &rLngSvcMgr ) : m_rMgr (rLngSvcMgr) { - m_pCache = nullptr; - m_pCharClass = nullptr; } diff --git a/svtools/source/contnr/imivctl2.cxx b/svtools/source/contnr/imivctl2.cxx index 9d88972b64a0..e8ea911c1506 100644 --- a/svtools/source/contnr/imivctl2.cxx +++ b/svtools/source/contnr/imivctl2.cxx @@ -476,7 +476,6 @@ void IcnCursor_Impl::SetDeltas() IcnGridMap_Impl::IcnGridMap_Impl(SvxIconChoiceCtrl_Impl* pView) { _pView = pView; - _pGridMap = nullptr; _nGridCols = 0; _nGridRows = 0; } diff --git a/writerfilter/source/dmapper/TrackChangesHandler.cxx b/writerfilter/source/dmapper/TrackChangesHandler.cxx index 18bf9ff15c11..b5a7fc3c3d31 100644 --- a/writerfilter/source/dmapper/TrackChangesHandler.cxx +++ b/writerfilter/source/dmapper/TrackChangesHandler.cxx @@ -21,9 +21,9 @@ using namespace oox; TrackChangesHandler::TrackChangesHandler( sal_Int32 nToken ) : -LoggedProperties("TrackChangesHandler") + LoggedProperties("TrackChangesHandler"), + m_pRedlineParams(std::make_shared<RedlineParams>()) { - m_pRedlineParams = std::make_shared<RedlineParams>( ); m_pRedlineParams->m_nToken = nToken; } |