summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2021-02-28 19:14:24 +0000
committerCaolán McNamara <caolanm@redhat.com>2021-02-28 21:33:45 +0100
commit56e0bb77f8506abf9eb16f6a4ceff432190c81c4 (patch)
tree5efbec5f7a4b6e6e14d61b44157a12bc9590a71c
parent1b20f21ad8b476938af31f8f6a7926d2b1de0c97 (diff)
remove unnecessary MouseButtonDown forward
I don't see how this scenario can happen, and if it does, why we would want to send a MouseDown to the filter list. This hunk appears in the "initial import". There is a "On OS/2 when clicking next to the Popup menu..." comment on a different popup in this file so maybe there was some workaround for some condition that no longer happens. Change-Id: I15b4d57259047a20822685a00e1bf5b00aa21a3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r--sc/source/ui/view/gridwin.cxx14
1 files changed, 0 insertions, 14 deletions
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 0fe1c7d357b5..e17a03de5971 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1806,7 +1806,6 @@ void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt, MouseEventSta
// Scenario selection comes from MouseButtonDown:
// The next MouseMove on the FilterBox is like a ButtonDown
nMouseStatus = SC_GM_FILTER;
-
return;
}
@@ -2413,19 +2412,6 @@ void ScGridWindow::MouseMove( const MouseEvent& rMEvt )
return;
}
- if (nMouseStatus == SC_GM_FILTER && mpFilterBox)
- {
- Point aRelPos = mpFilterBox->ScreenToOutputPixel( OutputToScreenPixel( rMEvt.GetPosPixel() ) );
- if ( tools::Rectangle(Point(), mpFilterBox->GetOutputSizePixel()).IsInside(aRelPos) )
- {
- nButtonDown = 0;
- nMouseStatus = SC_GM_NONE;
- ReleaseMouse();
- mpFilterBox->MouseButtonDown( MouseEvent( aRelPos, 1, MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT ) );
- return;
- }
- }
-
bool bFormulaMode = pScMod->IsFormulaMode(); // next click -> reference
if (bEEMouse && mrViewData.HasEditView( eWhich ))