diff options
| author | Kohei Yoshida <kohei.yoshida@collabora.com> | 2014-08-15 09:39:19 -0400 |
|---|---|---|
| committer | Kohei Yoshida <kohei.yoshida@collabora.com> | 2014-08-18 11:15:18 -0400 |
| commit | 5cc38c1bf60dc851ec908f7a9eac4c6e70e849f7 (patch) | |
| tree | 7bcd99e5a07cef82115fe8f2553d4f8eb42021ed | |
| parent | 7ecc633bfe4bda3e0647b411ad7d1e6a3357c908 (diff) | |
Nested conditional !(cond1 && cond2 && cond3) is harder on human brain.
Change-Id: I1c10c7f0f85607a826ec06ffce12de761af3921a
| -rw-r--r-- | chart2/source/view/charttypes/PieChart.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx index 32542d21a5d6..1f524151c1b2 100644 --- a/chart2/source/view/charttypes/PieChart.cxx +++ b/chart2/source/view/charttypes/PieChart.cxx @@ -391,8 +391,8 @@ void PieChart::createShapes() // No series to plot. return; - OSL_ENSURE(m_pShapeFactory&&m_xLogicTarget.is()&&m_xFinalTarget.is(),"PieChart is not proper initialized"); - if(!(m_pShapeFactory&&m_xLogicTarget.is()&&m_xFinalTarget.is())) + OSL_ENSURE(m_pShapeFactory && m_xLogicTarget.is() && m_xFinalTarget.is(), "PieChart is not properly initialized."); + if (!m_pShapeFactory || !m_xLogicTarget.is() || !m_xFinalTarget.is()) return; //the text labels should be always on top of the other series shapes |