diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-08 09:13:09 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-08 17:10:27 +0200 |
commit | 5cd87f195624e2381489084a37dcd43fea24c7b0 (patch) | |
tree | 28f7722e16d6052103a7ecc7468f7980db6285e1 | |
parent | 953d8429c9c92ced2e3cb1222cadc29b6f1ef550 (diff) |
loplugin:moveparam in vcl
Change-Id: I6dea009e1031174ecb3d4371e91c9c6d26c6e514
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123245
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r-- | include/vcl/IContext.hxx | 4 | ||||
-rw-r--r-- | include/vcl/filter/pdfdocument.hxx | 2 | ||||
-rw-r--r-- | include/vcl/toolkit/throbber.hxx | 2 | ||||
-rw-r--r-- | toolkit/source/awt/animatedimagespeer.cxx | 2 | ||||
-rw-r--r-- | vcl/source/control/throbber.cxx | 6 | ||||
-rw-r--r-- | vcl/source/filter/eps/eps.cxx | 10 | ||||
-rw-r--r-- | vcl/source/filter/ipdf/pdfdocument.cxx | 4 | ||||
-rw-r--r-- | vcl/source/window/builder.cxx | 4 | ||||
-rw-r--r-- | xmlsecurity/source/helper/pdfsignaturehelper.cxx | 2 |
9 files changed, 18 insertions, 18 deletions
diff --git a/include/vcl/IContext.hxx b/include/vcl/IContext.hxx index 05823d190ed7..d595d8771089 100644 --- a/include/vcl/IContext.hxx +++ b/include/vcl/IContext.hxx @@ -22,9 +22,9 @@ protected: IContext() { maContext.push_back(vcl::EnumContext::Context::Any); } public: - void SetContext(const std::vector<vcl::EnumContext::Context>& aContext) + void SetContext(std::vector<vcl::EnumContext::Context>&& aContext) { - maContext = aContext; + maContext = std::move(aContext); } bool HasContext(const vcl::EnumContext::Context eContext) const diff --git a/include/vcl/filter/pdfdocument.hxx b/include/vcl/filter/pdfdocument.hxx index aae3b5a1f893..aa0e8c67ea66 100644 --- a/include/vcl/filter/pdfdocument.hxx +++ b/include/vcl/filter/pdfdocument.hxx @@ -576,7 +576,7 @@ public: //@{ /// Read elements from the start of the stream till its end. bool Read(SvStream& rStream); - void SetSignatureLine(const std::vector<sal_Int8>& rSignatureLine); + void SetSignatureLine(std::vector<sal_Int8>&& rSignatureLine); void SetSignaturePage(size_t nPage); /// Sign the read document with xCertificate in the edit buffer. bool Sign(const css::uno::Reference<css::security::XCertificate>& xCertificate, diff --git a/include/vcl/toolkit/throbber.hxx b/include/vcl/toolkit/throbber.hxx index bdbbb020889c..287e1e58d949 100644 --- a/include/vcl/toolkit/throbber.hxx +++ b/include/vcl/toolkit/throbber.hxx @@ -60,7 +60,7 @@ public: void stop(); bool isRunning() const; - void setImageList( ::std::vector< Image > const& i_images ); + void setImageList( ::std::vector< Image > && i_images ); // default images static ::std::vector< OUString > diff --git a/toolkit/source/awt/animatedimagespeer.cxx b/toolkit/source/awt/animatedimagespeer.cxx index d7ba97e24590..d6dc140f6f28 100644 --- a/toolkit/source/awt/animatedimagespeer.cxx +++ b/toolkit/source/awt/animatedimagespeer.cxx @@ -440,7 +440,7 @@ namespace toolkit aImages[ imageIndex++ ] = Image(rCachedImage.xGraphic); } } - pThrobber->setImageList( aImages ); + pThrobber->setImageList( std::move(aImages) ); } catch( const Exception& ) { diff --git a/vcl/source/control/throbber.cxx b/vcl/source/control/throbber.cxx index d1c769a3bcd3..e1faeb7c7af1 100644 --- a/vcl/source/control/throbber.cxx +++ b/vcl/source/control/throbber.cxx @@ -141,7 +141,7 @@ void Throbber::initImages() } if ( nPreferredSet < aImageSets.size() ) - setImageList( aImageSets[nPreferredSet] ); + setImageList( std::vector(aImageSets[nPreferredSet]) ); } catch( const Exception& ) { @@ -163,11 +163,11 @@ bool Throbber::isRunning() const return maWaitTimer.IsActive(); } -void Throbber::setImageList( ::std::vector< Image > const& i_images ) +void Throbber::setImageList( ::std::vector< Image > && i_images ) { SAL_WARN_IF( i_images.size()>=SAL_MAX_INT32, "vcl.control", "Throbber::setImageList: too many images!" ); - maImageList = i_images; + maImageList = std::move(i_images); const Image aInitialImage( !maImageList.empty() ? maImageList[ 0 ] : Image() ); SetImage( aInitialImage ); diff --git a/vcl/source/filter/eps/eps.cxx b/vcl/source/filter/eps/eps.cxx index 5f9765ddce57..74a746154397 100644 --- a/vcl/source/filter/eps/eps.cxx +++ b/vcl/source/filter/eps/eps.cxx @@ -189,7 +189,7 @@ private: void ImplAddPath( const tools::Polygon & rPolygon ); void ImplWriteLineInfo( double fLineWidth, double fMiterLimit, SvtGraphicStroke::CapType eLineCap, - SvtGraphicStroke::JoinType eJoinType, SvtGraphicStroke::DashArray const & rDashArray ); + SvtGraphicStroke::JoinType eJoinType, SvtGraphicStroke::DashArray && rDashArray ); void ImplWriteLineInfo( const LineInfo& rLineInfo ); void ImplRect( const tools::Rectangle & rRectangle ); void ImplRectFill ( const tools::Rectangle & rRectangle ); @@ -1253,7 +1253,7 @@ void PSWriter::ImplWriteActions( const GDIMetaFile& rMtf, VirtualDevice& rVDev ) if ( bSkipSequence ) { ImplWriteLineInfo( fStrokeWidth, aStroke.getMiterLimit(), - aStroke.getCapType(), eJT, l_aDashArray ); + aStroke.getCapType(), eJT, std::move(l_aDashArray) ); ImplPolyLine( aPath ); } } @@ -2257,7 +2257,7 @@ double PSWriter::ImplGetScaling( const MapMode& rMapMode ) void PSWriter::ImplWriteLineInfo( double fLWidth, double fMLimit, SvtGraphicStroke::CapType eLCap, SvtGraphicStroke::JoinType eJoin, - SvtGraphicStroke::DashArray const & rLDash ) + SvtGraphicStroke::DashArray && rLDash ) { if ( fLineWidth != fLWidth ) { @@ -2288,7 +2288,7 @@ void PSWriter::ImplWriteLineInfo( double fLWidth, double fMLimit, } if ( aDashArray != rLDash ) { - aDashArray = rLDash; + aDashArray = std::move(rLDash); sal_uInt32 j, i = aDashArray.size(); ImplWriteLine( "[", PS_SPACE ); for ( j = 0; j < i; j++ ) @@ -2342,7 +2342,7 @@ void PSWriter::ImplWriteLineInfo( const LineInfo& rLineInfo ) } } - ImplWriteLineInfo( fLWidth, fMiterLimit, aCapType, aJoinType, l_aDashArray ); + ImplWriteLineInfo( fLWidth, fMiterLimit, aCapType, aJoinType, std::move(l_aDashArray) ); } void PSWriter::ImplWriteLong(sal_Int32 nNumber, NMode nMode) diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx b/vcl/source/filter/ipdf/pdfdocument.cxx index 7e1a25e54e7b..4b045c63319e 100644 --- a/vcl/source/filter/ipdf/pdfdocument.cxx +++ b/vcl/source/filter/ipdf/pdfdocument.cxx @@ -93,9 +93,9 @@ bool PDFDocument::writeBuffer(const void* pBuffer, sal_uInt64 nBytes) return nWritten == nBytes; } -void PDFDocument::SetSignatureLine(const std::vector<sal_Int8>& rSignatureLine) +void PDFDocument::SetSignatureLine(std::vector<sal_Int8>&& rSignatureLine) { - m_aSignatureLine = rSignatureLine; + m_aSignatureLine = std::move(rSignatureLine); } void PDFDocument::SetSignaturePage(size_t nPage) { m_nSignaturePage = nPage; } diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index 8d927e0edd1c..190c0e0bcad1 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -2601,7 +2601,7 @@ void VclBuilder::handleTabChild(vcl::Window *pParent, xmlreader::XmlReader &read if (!context.empty()) { TabPage* pPage = pTabControl->GetTabPage(nPageId); - pPage->SetContext(context); + pPage->SetContext(std::move(context)); } for (auto const& prop : aAtkProperties) @@ -3643,7 +3643,7 @@ VclPtr<vcl::Window> VclBuilder::handleObject(vcl::Window *pParent, stringmap *pA vcl::IContext* pContextControl = dynamic_cast<vcl::IContext*>(pCurrentChild.get()); SAL_WARN_IF(!pContextControl, "vcl", "context set for not supported item"); if (pContextControl) - pContextControl->SetContext(aContext); + pContextControl->SetContext(std::move(aContext)); } } else diff --git a/xmlsecurity/source/helper/pdfsignaturehelper.cxx b/xmlsecurity/source/helper/pdfsignaturehelper.cxx index 24047a30cd1b..31740779de1c 100644 --- a/xmlsecurity/source/helper/pdfsignaturehelper.cxx +++ b/xmlsecurity/source/helper/pdfsignaturehelper.cxx @@ -562,7 +562,7 @@ bool PDFSignatureHelper::Sign(const uno::Reference<frame::XModel>& xModel, } if (!aSignatureLineShape.empty()) { - aDocument.SetSignatureLine(aSignatureLineShape); + aDocument.SetSignatureLine(std::move(aSignatureLineShape)); } if (!aDocument.Sign(m_xCertificate, m_aDescription, bAdES)) |