diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2025-02-04 19:30:47 +0100 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2025-02-05 08:38:03 +0100 |
| commit | 69c0b537bfa05a6193e212105d166c26492124f6 (patch) | |
| tree | 3c441cd2bcb26dafca3145c0d4804aab1863d3e6 | |
| parent | 9b9d6a99e1509a03648fd6af0310e44c3fba5b14 (diff) | |
browsebox a11y: Drop incorrect parent-relative pos conversion
The only thing that changes when parent-relative coordinates
(and not screen coordinates) are used is that the origin
of the rectangle is different, which is already handled below.
Passing bRelToBrowser=false to BrowseBox::GetFieldRectPixel
is incorrect and resulted in the position for BrowseBox
headers cells being incorrectly reported on the a11y layer
when parent-relative coordinates are used.
This was observed with an upcoming commit to let
AccessibleBrowseBoxBase derive from OAccessibleComponentHelper
and could be seen e.g. with the table seen in the
Base window that shows up when selecting
"Create Table in Design View..." in the "Tables" tab after
creating a new database. (Highlighted position for
those was wrong in Accerciser when selected in the
a11y tree view there when using the qt6 VCL plugin.)
Change-Id: I4c68748db0f09787037ac1ef023febaf01d1156e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181145
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
| -rw-r--r-- | svtools/source/brwbox/brwbox2.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svtools/source/brwbox/brwbox2.cxx b/svtools/source/brwbox/brwbox2.cxx index c02069fea856..f613bdcb26e4 100644 --- a/svtools/source/brwbox/brwbox2.cxx +++ b/svtools/source/brwbox/brwbox2.cxx @@ -1993,7 +1993,7 @@ tools::Rectangle BrowseBox::GetFieldRectPixel( sal_Int32 _nRowId, sal_uInt16 _nC if ( !_bOnScreen ) pParent = GetAccessibleParentWindow(); - tools::Rectangle aRect = GetFieldRectPixel(_nRowId,_nColId,_bOnScreen); + tools::Rectangle aRect = GetFieldRectPixel(_nRowId, _nColId, true); Point aTopLeft = aRect.TopLeft(); if (pParent) |