loplugin: defaultparams

Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74

18 files changed, 33 insertions, 36 deletions

diff --git a/desktop/source/deployment/registry/package/dp_package.cxx b/desktop/source/deployment/registry/package/dp_package.cxx
index ae19ed3f7a62..d9ae1e0a1b95 100644
--- a/desktop/source/deployment/registry/package/dp_package.cxx
+++ b/desktop/source/deployment/registry/package/dp_package.cxx
@@ -1087,9 +1087,7 @@ void BackendImpl::PackageImpl::exportTo(
     {
         // transfer every item of folder into zip:
         Reference<sdbc::XResultSet> xResultSet(
-            sourceContent.createCursor(
-                Sequence<OUString>(),
-                ::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
+            sourceContent.createCursor( Sequence<OUString>() ) );
         ProgressLevel progress( xCmdEnv, OUString() );
         while (xResultSet->next())
         {
@@ -1590,8 +1588,7 @@ void BackendImpl::PackageImpl::scanLegacyBundle(
     OUString ar [] = { OUString("Title"), OUString("IsFolder") };
     Reference<sdbc::XResultSet> xResultSet(
         ucbContent.createCursor(
-            Sequence<OUString>( ar, ARLEN(ar) ),
-            ::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
+            Sequence<OUString>( ar, ARLEN(ar) ) ) );
     while (xResultSet->next())
     {
         checkAborted( abortChannel );
diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index 3d004f410b3f..6b64d25df25c 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -203,7 +203,7 @@ void SAL_CALL SplashScreen::start(const OUString&, sal_Int32 nRange)
         _bProgressEnd = false;
         SolarMutexGuard aSolarGuard;
         if ( _eBitmapMode == BM_FULLSCREEN )
-            pWindow->ShowFullScreenMode( true );
+            pWindow->ShowFullScreenMode();
         pWindow->Show();
         pWindow->Redraw();
     }
@@ -229,7 +229,7 @@ void SAL_CALL SplashScreen::reset()
     if (_bVisible && !_bProgressEnd )
     {
         if ( _eBitmapMode == BM_FULLSCREEN )
-            pWindow->ShowFullScreenMode( true );
+            pWindow->ShowFullScreenMode();
         pWindow->Show();
         updateStatus();
     }
@@ -246,7 +246,7 @@ void SAL_CALL SplashScreen::setText(const OUString& rText)
         if (_bVisible && !_bProgressEnd)
         {
             if ( _eBitmapMode == BM_FULLSCREEN )
-                pWindow->ShowFullScreenMode( true );
+                pWindow->ShowFullScreenMode();
             pWindow->Show();
             updateStatus();
         }
@@ -261,7 +261,7 @@ void SAL_CALL SplashScreen::setValue(sal_Int32 nValue)
     SolarMutexGuard aSolarGuard;
     if (_bVisible && !_bProgressEnd) {
         if ( _eBitmapMode == BM_FULLSCREEN )
-            pWindow->ShowFullScreenMode( true );
+            pWindow->ShowFullScreenMode();
         pWindow->Show();
         if (nValue >= _iMax)
             _iProgress = _iMax;
diff --git a/embeddedobj/source/msole/olepersist.cxx b/embeddedobj/source/msole/olepersist.cxx
index 2b1995b371fc..4c9e7d6dac1f 100644
--- a/embeddedobj/source/msole/olepersist.cxx
+++ b/embeddedobj/source/msole/olepersist.cxx
@@ -746,7 +746,7 @@ uno::Reference< io::XStream > OleEmbeddedObject::TryToRetrieveCachedVisualRepres
 #endif
                                 }
 
-                                xResult = TryToRetrieveCachedVisualRepresentation_Impl( xStream, false );
+                                xResult = TryToRetrieveCachedVisualRepresentation_Impl( xStream );
                             }
                         }
                     }
diff --git a/extensions/source/abpilot/abpfinalpage.cxx b/extensions/source/abpilot/abpfinalpage.cxx
index 12dbd49bc8f8..6c85546e8b5d 100644
--- a/extensions/source/abpilot/abpfinalpage.cxx
+++ b/extensions/source/abpilot/abpfinalpage.cxx
@@ -60,9 +60,9 @@ namespace abp
         m_pName->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
         m_pLocation->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
         m_pRegisterName->SetClickHdl( LINK( this, FinalPage, OnRegister ) );
-        m_pRegisterName->Check(true);
+        m_pRegisterName->Check();
         m_pEmbed->SetClickHdl( LINK( this, FinalPage, OnEmbed ) );
-        m_pEmbed->Check(true);
+        m_pEmbed->Check();
         OnEmbed(m_pEmbed);
     }
 
diff --git a/extensions/source/bibliography/toolbar.cxx b/extensions/source/bibliography/toolbar.cxx
index 65952f08f24c..56aeb13b1b76 100644
--- a/extensions/source/bibliography/toolbar.cxx
+++ b/extensions/source/bibliography/toolbar.cxx
@@ -107,7 +107,7 @@ void BibTBListBoxListener::statusChanged(const ::com::sun::star::frame::FeatureS
                 aEntry = pStringArray[i];
                 pToolBar->InsertSourceEntry(aEntry);
             }
-            pToolBar->UpdateSourceList(true);
+            pToolBar->UpdateSourceList();
         }
 
         pToolBar->SelectSourceEntry(rEvt.FeatureDescriptor);
diff --git a/extensions/source/dbpilots/gridwizard.cxx b/extensions/source/dbpilots/gridwizard.cxx
index 58515c13f73b..9b550424c2e2 100644
--- a/extensions/source/dbpilots/gridwizard.cxx
+++ b/extensions/source/dbpilots/gridwizard.cxx
@@ -65,7 +65,7 @@ namespace dbp
         // if we do not need the data source selection page ...
         if (!needDatasourceSelection())
         {   // ... skip it!
-            skip(1);
+            skip();
             m_bHadDataSelection = false;
         }
     }
diff --git a/extensions/source/dbpilots/groupboxwiz.cxx b/extensions/source/dbpilots/groupboxwiz.cxx
index e6bc4d9d6339..8cfd5cfd49fd 100644
--- a/extensions/source/dbpilots/groupboxwiz.cxx
+++ b/extensions/source/dbpilots/groupboxwiz.cxx
@@ -267,7 +267,7 @@ namespace dbp
         if (bMoveLeft)
         {
             while (m_pExistingRadios->GetSelectEntryCount())
-                m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos(0));
+                m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos());
         }
         else
         {
diff --git a/extensions/source/dbpilots/listcombowizard.cxx b/extensions/source/dbpilots/listcombowizard.cxx
index 7feea7d7024d..62c84053025f 100644
--- a/extensions/source/dbpilots/listcombowizard.cxx
+++ b/extensions/source/dbpilots/listcombowizard.cxx
@@ -61,7 +61,7 @@ namespace dbp
         // if we do not need the data source selection page ...
         if (!needDatasourceSelection())
         {   // ... skip it!
-            skip(1);
+            skip();
             m_bHadDataSelection = false;
         }
     }
diff --git a/extensions/source/plugin/unx/npnapi.cxx b/extensions/source/plugin/unx/npnapi.cxx
index 5d222af5368b..1129fc8ea3b9 100644
--- a/extensions/source/plugin/unx/npnapi.cxx
+++ b/extensions/source/plugin/unx/npnapi.cxx
@@ -524,7 +524,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*, /*pMediator*/ )
 {
     MediatorMessage* pMessage;
     CommandAtoms nCommand;
-    while( (pMessage = GetNextMessage( false )) )
+    while( (pMessage = GetNextMessage()) )
     {
         nCommand = (CommandAtoms)pMessage->GetUINT32();
         SAL_INFO(
diff --git a/extensions/source/plugin/unx/nppapi.cxx b/extensions/source/plugin/unx/nppapi.cxx
index 2ea3af174350..e55b14b3d35c 100644
--- a/extensions/source/plugin/unx/nppapi.cxx
+++ b/extensions/source/plugin/unx/nppapi.cxx
@@ -94,7 +94,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*, /*pMediator*/ )
 
     MediatorMessage* pMessage;
     CommandAtoms nCommand;
-    while( (pMessage = GetNextMessage( false )) )
+    while( (pMessage = GetNextMessage()) )
     {
         nCommand = (CommandAtoms)pMessage->GetUINT32();
         SAL_INFO("extensions.plugin", GetCommandName(nCommand));
diff --git a/extensions/source/plugin/unx/sysplug.cxx b/extensions/source/plugin/unx/sysplug.cxx
index e8a1af9b5539..87b58856b7f3 100644
--- a/extensions/source/plugin/unx/sysplug.cxx
+++ b/extensions/source/plugin/unx/sysplug.cxx
@@ -103,7 +103,7 @@ UnxPluginComm::UnxPluginComm(
 
     m_nCommPID = pid;
     // wait for pluginapp.bin to start up
-    if( ! WaitForMessage( 5000 ) )
+    if( ! WaitForMessage() )
     {
         SAL_WARN(
             "extensions.plugin",
diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx
index fddd0ec58b67..011d80c848cf 100644
--- a/extensions/source/propctrlr/browserlistbox.cxx
+++ b/extensions/source/propctrlr/browserlistbox.cxx
@@ -1187,7 +1187,7 @@ namespace pcr
                     vcl::Window *pWindow = rLine.pLine->getControlWindow();
                     Edit* pControlWindowAsEdit = dynamic_cast<Edit*>(pWindow);
                     if (pControlWindowAsEdit)
-                        pControlWindowAsEdit->SetReadOnly(true);
+                        pControlWindowAsEdit->SetReadOnly();
                     else
                         pWindow->Enable(false);
                 }
diff --git a/extensions/source/propctrlr/eformshelper.hxx b/extensions/source/propctrlr/eformshelper.hxx
index a607e918f4c4..b3c819aefa24 100644
--- a/extensions/source/propctrlr/eformshelper.hxx
+++ b/extensions/source/propctrlr/eformshelper.hxx
@@ -109,7 +109,7 @@ namespace pcr
 
         /** checks whether the control model can be bound to any XSD data type
         */
-        bool    canBindToAnyDataType() const { return canBindToDataType( -1 ); }
+        bool    canBindToAnyDataType() const { return canBindToDataType(); }
 
         /** checks whether the control model is a source for list entries, as supplied by XML data bindings
         */
diff --git a/extensions/source/propctrlr/selectlabeldialog.cxx b/extensions/source/propctrlr/selectlabeldialog.cxx
index e9acfb12bd54..cc842f9bca9e 100644
--- a/extensions/source/propctrlr/selectlabeldialog.cxx
+++ b/extensions/source/propctrlr/selectlabeldialog.cxx
@@ -123,19 +123,19 @@ namespace pcr
         if (m_pInitialSelection)
         {
             m_pControlTree->MakeVisible(m_pInitialSelection, true);
-            m_pControlTree->Select(m_pInitialSelection, true);
+            m_pControlTree->Select(m_pInitialSelection);
         }
         else
         {
             m_pControlTree->MakeVisible(m_pControlTree->First(), true);
             if (m_pControlTree->FirstSelected())
                 m_pControlTree->Select(m_pControlTree->FirstSelected(), false);
-            m_pNoAssignment->Check(true);
+            m_pNoAssignment->Check();
         }
 
         if (!m_bHaveAssignableControl)
         {   // no controls which can be assigned
-            m_pNoAssignment->Check(true);
+            m_pNoAssignment->Check();
             m_pNoAssignment->Enable(false);
         }
 
diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx
index ed4d1df0bf0f..bdd97c67464c 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -693,7 +693,7 @@ namespace pcr
         getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
         if ( ( nWinStyle & WB_READONLY ) != 0 )
         {
-            getTypedControlWindow()->SetReadOnly( true );
+            getTypedControlWindow()->SetReadOnly();
             getTypedControlWindow()->Enable( true );
         }
     }
@@ -802,7 +802,7 @@ namespace pcr
         getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
         if ( ( nWinStyle & WB_READONLY ) != 0 )
         {
-            getTypedControlWindow()->SetReadOnly( true );
+            getTypedControlWindow()->SetReadOnly();
             getTypedControlWindow()->Enable( true );
         }
     }
diff --git a/extensions/source/propctrlr/usercontrol.cxx b/extensions/source/propctrlr/usercontrol.cxx
index 0c42e18dee02..43f09b42e978 100644
--- a/extensions/source/propctrlr/usercontrol.cxx
+++ b/extensions/source/propctrlr/usercontrol.cxx
@@ -72,13 +72,13 @@ namespace pcr
             TreatAsNumber( true );
 
             SvNumberFormatter* pFormatter = pSupplier->GetNumberFormatter();
-            SetFormatter( pFormatter, true );
+            SetFormatter( pFormatter );
             SetValue( 1234.56789 );
         }
         else
         {
             TreatAsNumber( false );
-            SetFormatter( NULL, true );
+            SetFormatter( NULL );
             SetText( "" );
         }
     }
@@ -218,7 +218,7 @@ namespace pcr
 
             SvNumberFormatter* pFormatter = rDesc.pSupplier->GetNumberFormatter();
             if (pFormatter != getTypedControlWindow()->GetFormatter())
-                getTypedControlWindow()->SetFormatter(pFormatter, true);
+                getTypedControlWindow()->SetFormatter(pFormatter);
             getTypedControlWindow()->SetFormatKey(rDesc.nKey);
 
             const SvNumberformat* pEntry = getTypedControlWindow()->GetFormatter()->GetEntry(getTypedControlWindow()->GetFormatKey());
@@ -251,7 +251,7 @@ namespace pcr
         if ( bFallback )
         {
             getTypedControlWindow()->TreatAsNumber(false);
-            getTypedControlWindow()->SetFormatter(NULL, true);
+            getTypedControlWindow()->SetFormatter(NULL);
             getTypedControlWindow()->SetText("");
             m_nLastDecimalDigits = 0;
         }
diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx
index cde72244d725..c5ff202aa7ba 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -562,24 +562,24 @@ bool Sane::Start( BitmapTransporter& rBitmap )
     double fTLx, fTLy, fResl = 0.0;
     int nOption;
     if( ( nOption = GetOptionByName( "tl-x" ) ) != -1   &&
-        GetOptionValue( nOption, fTLx, 0 )              &&
+        GetOptionValue( nOption, fTLx )              &&
         GetOptionUnit( nOption ) == SANE_UNIT_MM )
     {
         double fBRx;
         if( ( nOption = GetOptionByName( "br-x" ) ) != -1   &&
-            GetOptionValue( nOption, fBRx, 0 )              &&
+            GetOptionValue( nOption, fBRx )              &&
             GetOptionUnit( nOption ) == SANE_UNIT_MM )
         {
             nWidthMM = (int)fabs(fBRx - fTLx);
         }
     }
     if( ( nOption = GetOptionByName( "tl-y" ) ) != -1   &&
-        GetOptionValue( nOption, fTLy, 0 )              &&
+        GetOptionValue( nOption, fTLy )              &&
         GetOptionUnit( nOption ) == SANE_UNIT_MM )
     {
         double fBRy;
         if( ( nOption = GetOptionByName( "br-y" ) ) != -1   &&
-            GetOptionValue( nOption, fBRy, 0 )              &&
+            GetOptionValue( nOption, fBRy )              &&
             GetOptionUnit( nOption ) == SANE_UNIT_MM )
         {
             nHeightMM = (int)fabs(fBRy - fTLy);
diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx
index 30b3778b3f9a..f17bbe8b63d1 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -471,7 +471,7 @@ void SaneDlg::InitFields()
         bSuccess = false;
         if( nOption != -1 )
         {
-            bSuccess = mrSane.GetOptionValue( nOption, fValue, 0 );
+            bSuccess = mrSane.GetOptionValue( nOption, fValue );
             if( bSuccess )
             {
                 if( mrSane.GetOptionUnit( nOption ) == SANE_UNIT_MM )
@@ -677,7 +677,7 @@ IMPL_LINK( SaneDlg, ClickBtnHdl, Button*, pButton )
     else if( pButton == mpCancelButton )
     {
         mrSane.Close();
-        EndDialog( 0 );
+        EndDialog();
     }
     return 0;
 }