diff options
author | Noel Grandin <noel@peralex.com> | 2014-12-18 11:20:47 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-01-05 09:58:50 +0200 |
commit | 82257e9087dc405fdc45cba7d6867be53b5ec9b3 (patch) | |
tree | 0336b6046645b669ac76d1a7f0a393102ab18f55 | |
parent | 08e8bd4eaf19df693fe0b17c91e8fb566b1f82f9 (diff) |
java: static fields that should be instance fields
found by FindBugs.
Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
-rw-r--r-- | qadevOOo/runner/base/java_fat_service.java | 2 | ||||
-rw-r--r-- | qadevOOo/runner/helper/OfficeProvider.java | 8 | ||||
-rw-r--r-- | qadevOOo/tests/java/mod/_acceptor/uno/Acceptor.java | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/qadevOOo/runner/base/java_fat_service.java b/qadevOOo/runner/base/java_fat_service.java index 27ae90a7368c..485eec707edb 100644 --- a/qadevOOo/runner/base/java_fat_service.java +++ b/qadevOOo/runner/base/java_fat_service.java @@ -40,7 +40,7 @@ import stats.Summarizer; */ public class java_fat_service implements TestBase { - static protected boolean debug = false; + protected boolean debug = false; protected LogWriter log = null; public boolean executeTest(lib.TestParameters param) { diff --git a/qadevOOo/runner/helper/OfficeProvider.java b/qadevOOo/runner/helper/OfficeProvider.java index 4be6c27b68ef..4496fec9d43f 100644 --- a/qadevOOo/runner/helper/OfficeProvider.java +++ b/qadevOOo/runner/helper/OfficeProvider.java @@ -49,7 +49,7 @@ import util.utils; public class OfficeProvider implements AppProvider { - private static boolean debug = false; + private boolean debug = false; /** * copy the user layer to a safe place, usually to $TMP/user_backup$USER @@ -312,7 +312,7 @@ public class OfficeProvider implements AppProvider * @throws com.sun.star.connection.NoConnectException * @throws Exception */ - private static XMultiServiceFactory connect(String connectStr) + private XMultiServiceFactory connect(String connectStr) throws com.sun.star.uno.Exception, com.sun.star.uno.RuntimeException, com.sun.star.connection.NoConnectException, @@ -690,7 +690,7 @@ public class OfficeProvider implements AppProvider * @param msf the <CODE>MultiServiceFactory</CODE> * @param param the <CODE>TestParameters</CODE> */ - private static void makeAppExecCommand(XMultiServiceFactory msf, TestParameters param) + private void makeAppExecCommand(XMultiServiceFactory msf, TestParameters param) { debug = param.getBool(PropertyName.DEBUG_IS_ACTIVE); @@ -733,7 +733,7 @@ public class OfficeProvider implements AppProvider param.put(util.PropertyName.APP_EXECUTION_COMMAND, command); } - private static void dbg(String message) + private void dbg(String message) { if (debug) { diff --git a/qadevOOo/tests/java/mod/_acceptor/uno/Acceptor.java b/qadevOOo/tests/java/mod/_acceptor/uno/Acceptor.java index a8239a9fd4bd..1431c2e97f11 100644 --- a/qadevOOo/tests/java/mod/_acceptor/uno/Acceptor.java +++ b/qadevOOo/tests/java/mod/_acceptor/uno/Acceptor.java @@ -41,7 +41,7 @@ public class Acceptor extends TestCase { */ protected static final int basePort = 10000; private int curPort ; - private static String sOfficeHost = null ; + private String sOfficeHost = null ; /** * Retrieves host name where StarOffice is started from test |