diff options
author | Julien Nabet <serval2412@yahoo.fr> | 2020-03-25 23:28:47 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2020-03-26 14:24:07 +0100 |
commit | 83ae778d2e7350a15db2f8fbfde7521ab905d0aa (patch) | |
tree | 6fddd7aec135b75af9a4bf5ce105ec6e0b0ee20a | |
parent | dbf6468764879ef05fc2492b82a31299668c27b4 (diff) |
tdf#131571: fix crash when clicking the "Text direction from top to bottom"
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=159006
cause of invalidation of pOLV here:
https://bugs.documentfoundation.org/show_bug.cgi?id=131571#c4
Change-Id: Ibf79e1fa4ebe94470afb2042cdc007bc05010b28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r-- | sd/source/ui/view/drtxtob1.cxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sd/source/ui/view/drtxtob1.cxx b/sd/source/ui/view/drtxtob1.cxx index 3c8f188abff5..24c05c105a42 100644 --- a/sd/source/ui/view/drtxtob1.cxx +++ b/sd/source/ui/view/drtxtob1.cxx @@ -416,6 +416,9 @@ void TextObjectBar::Execute( SfxRequest &rReq ) case SID_TEXTDIRECTION_TOP_TO_BOTTOM: { mpView->SdrEndTextEdit(); + // tdf#131571: SdrEndTextEdit invalidates pTextEditOutlinerView, the pointer retrieved for pOLV + // so reinitialize pOLV + pOLV=mpView->GetTextEditOutlinerView(); SfxItemSet aAttr( mpView->GetDoc().GetPool(), svl::Items<SDRATTR_TEXTDIRECTION, SDRATTR_TEXTDIRECTION>{} ); aAttr.Put( SvxWritingModeItem( nSlot == SID_TEXTDIRECTION_LEFT_TO_RIGHT ? |