diff options
author | Caolán McNamara <caolanm@redhat.com> | 2021-03-05 10:53:54 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2021-03-05 16:28:28 +0100 |
commit | 89b377e51c06178af77b671a10caa78daf08eac1 (patch) | |
tree | 09493f680cf2f742764eb4c158dd09ca19285846 | |
parent | a2c761ac3f047cc9e10a01298bebb46dc0026efe (diff) |
updateMotionPathTags is already called from the ctor
#3 0x00007fffd0fe1939 in sd::CustomAnimationList::Select() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:981
#4 0x00007fffd0fe4f62 in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:864
#5 0x00007fffd0fe353b in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:639
#6 0x00007fffd0ff5f4b in sd::CustomAnimationPane::onChangeCurrentPage() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:1664
#7 0x00007fffd0ff4321 in sd::CustomAnimationPane::initialize() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:208
#8 0x00007fffd0ff527b in sd::CustomAnimationPane::CustomAnimationPane(vcl::Window*, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x391e9c0, pParent=0x391a3e0, rBase=..., rxFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x166a030)
at sd/source/ui/animations/CustomAnimationPane.cxx:156
so don't recall it on StateChangedType::Visible StateChange
Change-Id: I311d97ad69b295669e7c31e18f669ae6b123b7d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112004
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r-- | sd/source/ui/animations/CustomAnimationPane.cxx | 8 | ||||
-rw-r--r-- | sd/source/ui/inc/CustomAnimationPane.hxx | 1 |
2 files changed, 0 insertions, 9 deletions
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx index 825a88b9bab8..6b6aff20dd1f 100644 --- a/sd/source/ui/animations/CustomAnimationPane.cxx +++ b/sd/source/ui/animations/CustomAnimationPane.cxx @@ -268,14 +268,6 @@ void CustomAnimationPane::addUndo() } } -void CustomAnimationPane::StateChanged( StateChangedType nStateChange ) -{ - Control::StateChanged( nStateChange ); - - if( nStateChange == StateChangedType::Visible ) - updateMotionPathTags(); -} - void CustomAnimationPane::KeyInput( const KeyEvent& rKEvt ) { if (mxCustomAnimationList) diff --git a/sd/source/ui/inc/CustomAnimationPane.hxx b/sd/source/ui/inc/CustomAnimationPane.hxx index 5d156884a919..d07e76a7c3f2 100644 --- a/sd/source/ui/inc/CustomAnimationPane.hxx +++ b/sd/source/ui/inc/CustomAnimationPane.hxx @@ -71,7 +71,6 @@ public: void remove( CustomAnimationEffectPtr const & pEffect ); // Control - virtual void StateChanged( StateChangedType nStateChange ) override; virtual void KeyInput( const KeyEvent& rKEvt ) override; // ICustomAnimationListController |