summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolan.mcnamara@collabora.com>2024-12-01 16:08:57 +0000
committerCaolán McNamara <caolan.mcnamara@collabora.com>2024-12-01 19:20:55 +0100
commit90248dca6bbe4a33f3d91a3cd5d7bd7d904ef8ce (patch)
treecc3cfa39554816d2ca4cf6524ab44c1ff15955b7
parent1c8d7d826fcbf234e9a327188dd0962339270e41 (diff)
cid#1608083 Overflowed constant
Change-Id: I1aaa2ca5711b932676621ee37b00fd0683593214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
-rw-r--r--filter/source/msfilter/svdfppt.cxx9
1 files changed, 8 insertions, 1 deletions
diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 676f66b57cef..bea4a2aec8e5 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4857,7 +4857,14 @@ void PPTStyleTextPropReader::ReadParaProps(SvStream& rIn, const DffRecordHeader&
std::min(sal_uInt16(8),
aParaPropSet.mxParaSet->mnDepth);
- nCharCount--;
+ if (nCharCount > 0)
+ --nCharCount;
+ else
+ {
+ SAL_WARN("filter.ms", "Suspicious 0 CharCount");
+ // will clip to legal length in later check in this loop
+ nCharCount = std::numeric_limits<sal_uInt32>::max();
+ }
rIn.ReadUInt32( nMask );
aSet.mnAttrSet = nMask & 0x207df7;