summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBogdan Buzea <buzea.bogdan@libreoffice.org>2024-10-21 08:17:46 +0200
committerDavid Gilbert <freedesktop@treblig.org>2024-11-03 13:18:56 +0100
commit937167cbc30f7f9b26e444eb03bc7dbda0464ff9 (patch)
tree42ba2ec1c5a4cf60a9329cf3ad4357cb4f0babea
parent7455410b07183a843566d3ad8e8f66c564cd0a73 (diff)
tdf#163486: PVS: Identical branches
V1037 Two or more case-branches perform the same actions. Check lines: 8172, 8405, 8484 Change-Id: I85ff9c6258fc855323c1ee814b981b3453db7651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175275 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
-rw-r--r--sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx22
1 files changed, 2 insertions, 20 deletions
diff --git a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
index c2b4e3782d36..4503f6ef5273 100644
--- a/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
+++ b/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
@@ -8161,6 +8161,8 @@ void DomainMapper_Impl::CloseFieldCommand()
case FIELD_INFO : break;
case FIELD_INCLUDEPICTURE: break;
case FIELD_KEYWORDS :
+ case FIELD_SUBJECT :
+ case FIELD_TITLE :
{
if (!sFirstParam.isEmpty())
{
@@ -8393,16 +8395,6 @@ void DomainMapper_Impl::CloseFieldCommand()
handleFieldSet(pContext, xFieldInterface);
break;
case FIELD_SKIPIF : break;
- case FIELD_SUBJECT :
- {
- if (!sFirstParam.isEmpty())
- {
- xFieldInterface->setPropertyValue(
- getPropertyName( PROP_IS_FIXED ), uno::Any( true ));
- //PROP_CURRENT_PRESENTATION is set later anyway
- }
- }
- break;
case FIELD_SYMBOL:
{
FieldContextPtr pOuter = GetParentFieldContext(m_aFieldStack);
@@ -8472,16 +8464,6 @@ void DomainMapper_Impl::CloseFieldCommand()
SetNumberFormat( pContext->GetCommand(), xFieldInterface );
}
break;
- case FIELD_TITLE :
- {
- if (!sFirstParam.isEmpty())
- {
- xFieldInterface->setPropertyValue(
- getPropertyName( PROP_IS_FIXED ), uno::Any( true ));
- //PROP_CURRENT_PRESENTATION is set later anyway
- }
- }
- break;
case FIELD_USERADDRESS : //todo: user address collects street, city ...
break;
case FIELD_INDEX: