summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Weghorn <m.weghorn@posteo.de>2025-01-28 08:53:42 +0100
committerMichael Weghorn <m.weghorn@posteo.de>2025-01-29 08:25:08 +0100
commitb3a60c9d07a80f7e70fafaca7561b7fa5df36ecb (patch)
tree47fee1e0c95ea83a1001a514027be449872dd5fa
parent0267279ae8c2145cfedc1497634a869fb79e300e (diff)
uno grid a11y: Drop duplicate check whether alive
TableControl_Impl::commitTableEvent and TableControl_Impl::impl_commitAccessibleEvent check whether the accessible is alive before doing anything, so there's no need to do that manually before calling those methods in addition. Change-Id: Ie940653a994fe92eefd367d0816ba03c95d409a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180817 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
-rw-r--r--toolkit/source/controls/table/tablecontrol_impl.cxx29
1 files changed, 9 insertions, 20 deletions
diff --git a/toolkit/source/controls/table/tablecontrol_impl.cxx b/toolkit/source/controls/table/tablecontrol_impl.cxx
index f6dc5c161f5f..f4e47156a926 100644
--- a/toolkit/source/controls/table/tablecontrol_impl.cxx
+++ b/toolkit/source/controls/table/tablecontrol_impl.cxx
@@ -321,12 +321,10 @@ namespace svt::table
impl_ni_relayout();
// notify A1YY events
- if ( impl_isAccessibleAlive() )
- {
- impl_commitAccessibleEvent( AccessibleEventId::TABLE_MODEL_CHANGED,
- Any( AccessibleTableModelChange( AccessibleTableModelChangeType::ROWS_INSERTED, i_first, i_last, -1, -1 ) )
- );
- }
+ impl_commitAccessibleEvent(
+ AccessibleEventId::TABLE_MODEL_CHANGED,
+ Any(AccessibleTableModelChange(AccessibleTableModelChangeType::ROWS_INSERTED, i_first,
+ i_last, -1, -1)));
// schedule repaint
invalidateRowRange( i_first, ROW_INVALID );
@@ -389,20 +387,11 @@ namespace svt::table
impl_ni_relayout();
// notify A11Y events
- if ( impl_isAccessibleAlive() )
- {
- commitTableEvent(
- AccessibleEventId::TABLE_MODEL_CHANGED,
- Any( AccessibleTableModelChange(
- AccessibleTableModelChangeType::ROWS_REMOVED,
- firstRemovedRow,
- lastRemovedRow,
- -1,
- -1
- ) ),
- Any()
- );
- }
+ commitTableEvent(
+ AccessibleEventId::TABLE_MODEL_CHANGED,
+ Any(AccessibleTableModelChange(AccessibleTableModelChangeType::ROWS_REMOVED,
+ firstRemovedRow, lastRemovedRow, -1, -1)),
+ Any());
// schedule a repaint
invalidateRowRange( firstRemovedRow, ROW_INVALID );