clang-tidy modernize-pass-by-value in basegfx

Change-Id: I1ec34b2f0e9869a82894795f1d6351189ae92d9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 19 insertions, 13 deletions

diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
index ddec57374649..b548939f3eed 100644
--- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
+++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
@@ -28,6 +28,7 @@
 #include <basegfx/polygon/b2dpolypolygontools.hxx>
 #include <basegfx/curve/b2dcubicbezier.hxx>
 #include <sal/log.hxx>
+#include <utility>
 #include <vector>
 #include <algorithm>
 
@@ -513,8 +514,8 @@ namespace basegfx
                 impSolve();
             }
 
-            explicit solver(const B2DPolyPolygon& rOriginal, size_t* pPointLimit = nullptr)
-            :   maOriginal(rOriginal),
+            explicit solver(B2DPolyPolygon aOriginal, size_t* pPointLimit = nullptr)
+            :   maOriginal(std::move(aOriginal)),
                 mbIsCurve(false),
                 mbChanged(false)
             {
diff --git a/basegfx/source/tools/b2dclipstate.cxx b/basegfx/source/tools/b2dclipstate.cxx
index 7b8309e0de1c..126235699b4b 100644
--- a/basegfx/source/tools/b2dclipstate.cxx
+++ b/basegfx/source/tools/b2dclipstate.cxx
@@ -26,6 +26,7 @@
 #include <basegfx/polygon/b2dpolypolygon.hxx>
 #include <basegfx/polygon/b2dpolypolygontools.hxx>
 #include <basegfx/polygon/b2dpolypolygoncutter.hxx>
+#include <utility>
 
 
 namespace basegfx::utils
@@ -39,8 +40,8 @@ namespace basegfx::utils
             mePendingOps(UNION)
         {}
 
-        explicit ImplB2DClipState( const B2DPolyPolygon& rPoly ) :
-            maClipPoly(rPoly),
+        explicit ImplB2DClipState( B2DPolyPolygon aPoly ) :
+            maClipPoly(std::move(aPoly)),
             mePendingOps(UNION)
         {}
 
diff --git a/basegfx/source/tools/unopolypolygon.cxx b/basegfx/source/tools/unopolypolygon.cxx
index ce61a5d3451b..76341e6ea532 100644
--- a/basegfx/source/tools/unopolypolygon.cxx
+++ b/basegfx/source/tools/unopolypolygon.cxx
@@ -28,13 +28,14 @@
 #include <basegfx/utils/unopolypolygon.hxx>
 #include <basegfx/matrix/b2dhommatrixtools.hxx>
 #include <cppuhelper/supportsservice.hxx>
+#include <utility>
 
 using namespace ::com::sun::star;
 
 namespace basegfx::unotools
 {
-    UnoPolyPolygon::UnoPolyPolygon( const B2DPolyPolygon& rPolyPoly ) :
-        maPolyPoly( rPolyPoly ),
+    UnoPolyPolygon::UnoPolyPolygon( B2DPolyPolygon aPolyPoly ) :
+        maPolyPoly(std::move( aPolyPoly )),
         meFillRule( rendering::FillRule_EVEN_ODD )
     {
         // or else races will haunt us.
diff --git a/include/basegfx/DrawCommands.hxx b/include/basegfx/DrawCommands.hxx
index fef43689b4a9..14d3ad2459cf 100644
--- a/include/basegfx/DrawCommands.hxx
+++ b/include/basegfx/DrawCommands.hxx
@@ -11,6 +11,7 @@
 #define INCLUDED_BASEGFX_DRAWCOMMANDS_H
 
 #include <memory>
+#include <utility>
 #include <vector>
 
 #include <basegfx/color/bcolor.hxx>
@@ -141,9 +142,9 @@ public:
     std::shared_ptr<basegfx::BColor> mpStrokeColor;
     std::shared_ptr<GradientInfo> mpFillGradient;
 
-    DrawPath(basegfx::B2DPolyPolygon const& rPolyPolygon)
+    DrawPath(basegfx::B2DPolyPolygon aPolyPolygon)
         : DrawBase(DrawCommandType::Path)
-        , maPolyPolygon(rPolyPolygon)
+        , maPolyPolygon(std::move(aPolyPolygon))
         , mnStrokeWidth(1.0)
         , mnOpacity(1.0)
     {
diff --git a/include/basegfx/matrix/b2dhommatrixtools.hxx b/include/basegfx/matrix/b2dhommatrixtools.hxx
index 10a0fe0df717..9b81f33d2a44 100644
--- a/include/basegfx/matrix/b2dhommatrixtools.hxx
+++ b/include/basegfx/matrix/b2dhommatrixtools.hxx
@@ -24,6 +24,7 @@
 #include <basegfx/vector/b2dvector.hxx>
 #include <basegfx/point/b2dpoint.hxx>
 #include <basegfx/tuple/b2dtuple.hxx>
+#include <utility>
 #include <basegfx/basegfxdllapi.h>
 
 namespace basegfx { class B2DRange; }
@@ -197,8 +198,8 @@ namespace basegfx::utils
             }
 
         public:
-            B2DHomMatrixBufferedOnDemandDecompose(const B2DHomMatrix& rB2DHomMatrix = B2DHomMatrix())
-            :   maB2DHomMatrix(rB2DHomMatrix),
+            B2DHomMatrixBufferedOnDemandDecompose(B2DHomMatrix aB2DHomMatrix = B2DHomMatrix())
+            :   maB2DHomMatrix(std::move(aB2DHomMatrix)),
                 mfRotate(0.0),
                 mfShearX(0.0),
                 mbDecomposed(false)
diff --git a/include/basegfx/utils/gradienttools.hxx b/include/basegfx/utils/gradienttools.hxx
index e3d816394b54..03892122b54b 100644
--- a/include/basegfx/utils/gradienttools.hxx
+++ b/include/basegfx/utils/gradienttools.hxx
@@ -23,6 +23,7 @@
 #include <basegfx/point/b2dpoint.hxx>
 #include <basegfx/vector/b2dvector.hxx>
 #include <basegfx/matrix/b2dhommatrix.hxx>
+#include <utility>
 #include <basegfx/basegfxdllapi.h>
 
 namespace basegfx { class B2DRange; }
@@ -72,10 +73,10 @@ namespace basegfx
         }
 
         ODFGradientInfo(
-            const B2DHomMatrix& rTextureTransform,
+            B2DHomMatrix aTextureTransform,
             double fAspectRatio,
             sal_uInt32 nSteps)
-        :   maTextureTransform(rTextureTransform),
+        :   maTextureTransform(std::move(aTextureTransform)),
             mfAspectRatio(fAspectRatio),
             mnSteps(nSteps)
         {
diff --git a/include/basegfx/utils/unopolypolygon.hxx b/include/basegfx/utils/unopolypolygon.hxx
index 714036a3d101..48788b074ede 100644
--- a/include/basegfx/utils/unopolypolygon.hxx
+++ b/include/basegfx/utils/unopolypolygon.hxx
@@ -40,7 +40,7 @@ namespace basegfx::unotools
         : public UnoPolyPolygonBase
     {
     public:
-        explicit UnoPolyPolygon( const B2DPolyPolygon& );
+        explicit UnoPolyPolygon( B2DPolyPolygon );
 
         // XPolyPolygon2D
         SAL_DLLPRIVATE virtual void SAL_CALL addPolyPolygon( const css::geometry::RealPoint2D& position, const css::uno::Reference< css::rendering::XPolyPolygon2D >& polyPolygon ) override;