diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-05-26 12:15:51 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-05-26 18:27:31 +0200 |
| commit | b566a5f5cef881c858d14d434df2b82b6d07d687 (patch) | |
| tree | 5d4a8a19f4dec58a3ab9f31d8346a27049c6af75 | |
| parent | 8148896dc8a81f4d4aeddae8527c18ab2db1aa3a (diff) | |
cid#1504573 Dereference before null check
since...
commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
Date: Mon May 23 15:48:41 2022 +0200
Advanced Diagram support: Isolated IDiagramHelper, selection visualization
we've already derefed pObj so can drop that check
Change-Id: I9bdab5c069405c0015f74e4621e7b37fbbed2dd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sc/source/ui/drawfunc/drawsh2.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/ui/drawfunc/drawsh2.cxx b/sc/source/ui/drawfunc/drawsh2.cxx index 020178be50ce..806216137a6d 100644 --- a/sc/source/ui/drawfunc/drawsh2.cxx +++ b/sc/source/ui/drawfunc/drawsh2.cxx @@ -270,7 +270,7 @@ void ScDrawShell::GetDrawFuncState( SfxItemSet& rSet ) // disable functions rSet.DisableItem( SID_FITCELLSIZE ); // Support advanced DiagramHelper - if(!pObj || !pObj->isDiagram()) + if (!pObj->isDiagram()) { rSet.DisableItem( SID_REGENERATE_DIAGRAM ); rSet.DisableItem( SID_EDIT_DIAGRAM ); |