summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2022-11-10 18:59:54 +0100
committerStephan Bergmann <sbergman@redhat.com>2022-11-11 15:40:45 +0100
commitb74d50003145f3805e3316a51c8be0222e680152 (patch)
treee0f9ab5ca3932a3cd722b6a1c101202b739953ac
parentbe89fcabd3da94a6441d0e2d07e0980a66d72e98 (diff)
Drop useless std::move of const object
...introduced with d8b60f77f389a248f98aa45592e6e1045baafbe1 "rtl_String->OString in DirectoryItem_Impl". (I came across this code with an upcoming loplugin:constmove that flags suspicious uses of std::move involving const-qualified types.) Change-Id: I3df2e6fb9dbf97adba6fbeda51d24cf025f5b207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-rw-r--r--sal/osl/unx/file_misc.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/sal/osl/unx/file_misc.cxx b/sal/osl/unx/file_misc.cxx
index c411b78cc260..01842dc73154 100644
--- a/sal/osl/unx/file_misc.cxx
+++ b/sal/osl/unx/file_misc.cxx
@@ -330,9 +330,9 @@ oslFileError SAL_CALL osl_getNextDirectoryItem(oslDirectory pDirectory,
pImpl = nullptr;
}
#ifdef _DIRENT_HAVE_D_TYPE
- pImpl = new DirectoryItem_Impl(std::move(strFilePath), pEntry->d_type);
+ pImpl = new DirectoryItem_Impl(strFilePath, pEntry->d_type);
#else
- pImpl = new DirectoryItem_Impl(std::move(strFilePath));
+ pImpl = new DirectoryItem_Impl(strFilePath);
#endif /* _DIRENT_HAVE_D_TYPE */
*pItem = pImpl;