diff options
author | Mike Kaganski <mike.kaganski@collabora.com> | 2020-05-29 19:26:08 +0300 |
---|---|---|
committer | Mike Kaganski <mike.kaganski@collabora.com> | 2020-05-30 10:06:32 +0200 |
commit | cefad27ee85486b01cf600c08371a651787dadc2 (patch) | |
tree | 6fd9941ac70f1282b5f13724d2988f8f9b15d43f | |
parent | 83c4f86f22dc37269ac6a038fe7de053c42aad6e (diff) |
Add TODOs
Change-Id: I6ab5840487f7676d5070ea4be00272f13dd47f96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-rw-r--r-- | drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 4 | ||||
-rw-r--r-- | vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx index 8d217dcf18db..3a57695f81e0 100644 --- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx @@ -1022,6 +1022,10 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const primitive2d::GlowPrimitiv void VclPixelProcessor2D::processSoftEdgePrimitive2D( const primitive2d::SoftEdgePrimitive2D& rCandidate) { + // TODO: don't limit the object at view range. This is needed to not blur objects at window + // borders, where they don't end. Ideally, process the full object once at maximal reasonable + // resolution, and store the resulting alpha mask in primitive's cache; then reuse it later, + // applying the transform. basegfx::B2DRange aRange(rCandidate.getB2DRange(getViewInformation2D())); aRange.transform(maCurrentTransformation); basegfx::B2DVector aRadiusVector(rCandidate.getRadius(), 0); diff --git a/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx b/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx index fe4f63f90d16..5cf24ec2f101 100644 --- a/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx +++ b/vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx @@ -19,6 +19,10 @@ #include <algorithm> +/* TODO: Use round kernel instead of square one. + This would make the result more natural, e.g. not making rounded square out of circle. + */ + namespace { struct FilterSharedData |