diff options
| author | Stephan Bergmann <stephan.bergmann@allotropia.de> | 2024-04-16 20:37:25 +0200 |
|---|---|---|
| committer | Stephan Bergmann <stephan.bergmann@allotropia.de> | 2024-04-17 07:56:09 +0200 |
| commit | d304fdb3369235ff4916463687b5e625c7fa3650 (patch) | |
| tree | e241e50e356e3f6460f710962da318dbbcc9af15 | |
| parent | 96f62b48b4425f0bc2b6d8497782694078d968fc (diff) | |
Embind: css::uno::Type should probably use sharing_policy::NONE
Given the reasoning in 0957ee9f5d379c80fca4027c187b471118d0490d "Embind: No need
for $query", those sharing_policies appear to be (solely) about upcasting of
those smart pointers, and css::uno::Type doesn't involve any class hierarchies,
so NONE ("no upcasting", in genericPointerToWireType in Emscripten's
src/embind/embind.js) appears to be the best match here.
Change-Id: I74b74d3c31cc17a7fd0a6d072160316e60884557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166160
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
| -rw-r--r-- | static/source/unoembindhelpers/PrimaryBindings.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/static/source/unoembindhelpers/PrimaryBindings.cxx b/static/source/unoembindhelpers/PrimaryBindings.cxx index c8d4717aa347..d74b63ab8402 100644 --- a/static/source/unoembindhelpers/PrimaryBindings.cxx +++ b/static/source/unoembindhelpers/PrimaryBindings.cxx @@ -45,7 +45,7 @@ template <> struct emscripten::smart_ptr_trait<css::uno::Type> { return ptr.getTypeLibType(); } - static sharing_policy get_sharing_policy() { return sharing_policy::INTRUSIVE; } + static sharing_policy get_sharing_policy() { return sharing_policy::NONE; } static css::uno::Type* share(typelib_TypeDescriptionReference* v) { return new css::uno::Type(v); |