summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-17 16:47:45 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-21 08:32:39 +0200
commitdefd2cb0255ad9e376ccd18df9a48ed1adae9d1e (patch)
treef1620e0100965549da9c7476e98078e078717003
parentd5ec8bc929d243fbd707b916883d0a192d5bb072 (diff)
loplugin:virtualdead unused param in SdrHdl::onHelpRequest
Change-Id: I3d75755bd6fd7f3168725c53fd8ce571a938fa37 Reviewed-on: https://gerrit.libreoffice.org/81181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--compilerplugins/clang/virtualdead.unusedparams.results3
-rw-r--r--include/svx/svdhdl.hxx2
-rw-r--r--sd/source/ui/view/viewoverlaymanager.cxx4
-rw-r--r--svx/source/svdraw/svdhdl.cxx2
-rw-r--r--svx/source/svdraw/svdmrkv.cxx2
5 files changed, 5 insertions, 8 deletions
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 08ae23369b67..5646996b40db 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -184,9 +184,6 @@ include/svx/IAccessibleParent.hxx:80
include/svx/selectioncontroller.hxx:48
_Bool sdr::SelectionController::onMouseButtonUp(const class MouseEvent &,class vcl::Window *,)
10
-include/svx/svdhdl.hxx:242
- void SdrHdl::onHelpRequest(const class HelpEvent &,)
- 0
include/vcl/accessibletable.hxx:91
class tools::Rectangle vcl::table::IAccessibleTable::GetFieldCharacterBounds(int,int,int,)
001
diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index a96e63b4ed6b..29d72620ada9 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -239,7 +239,7 @@ public:
virtual void onMouseEnter(const MouseEvent& rMEvt);
/** is called when help is requested for the area of this handle */
- virtual void onHelpRequest(const HelpEvent& rHEvt);
+ virtual void onHelpRequest();
/** is called when the mouse leaves the area of this handle. If the handle changes his
visualisation during mouse over it must override this method and call Touch(). */
diff --git a/sd/source/ui/view/viewoverlaymanager.cxx b/sd/source/ui/view/viewoverlaymanager.cxx
index dd5dc860c33f..8b5814749529 100644
--- a/sd/source/ui/view/viewoverlaymanager.cxx
+++ b/sd/source/ui/view/viewoverlaymanager.cxx
@@ -139,7 +139,7 @@ public:
virtual PointerStyle GetPointer() const override;
virtual void onMouseEnter(const MouseEvent& rMEvt) override;
- virtual void onHelpRequest(const HelpEvent& rHEvt) override;
+ virtual void onHelpRequest() override;
virtual void onMouseLeave() override;
int getHighlightId() const { return mnHighlightId; }
@@ -196,7 +196,7 @@ void ImageButtonHdl::ShowTip()
Help::ShowQuickHelp(pWindow, aScreenRect, aHelpText);
}
-void ImageButtonHdl::onHelpRequest(const HelpEvent& /*rHEvt*/)
+void ImageButtonHdl::onHelpRequest()
{
ShowTip();
}
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 69ac684925af..7bbd56293a0d 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -1064,7 +1064,7 @@ void SdrHdl::onMouseEnter(const MouseEvent& /*rMEvt*/)
{
}
-void SdrHdl::onHelpRequest(const HelpEvent& /*rHEvt*/)
+void SdrHdl::onHelpRequest()
{
}
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 0a3f5052d437..c012cc0fb10e 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -1449,7 +1449,7 @@ bool SdrMarkView::RequestHelp(const HelpEvent& rHEvt)
SdrHdl* pCurrentHdl = GetHdl(nHdl);
if (pCurrentHdl->mbMouseOver)
{
- pCurrentHdl->onHelpRequest(rHEvt);
+ pCurrentHdl->onHelpRequest();
return true;
}
}