diff options
author | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2018-08-04 23:38:44 -0400 |
---|---|---|
committer | Andras Timar <andras.timar@collabora.com> | 2019-09-03 13:36:37 +0200 |
commit | e204fcf3e2e675de4c429b8453cb4a9abcb46dd9 (patch) | |
tree | 86ab93e1f6a7a019b769bcbe91fe1686601df173 | |
parent | cbff1b6f6d71ab721eb8dff1638cb441ac367959 (diff) |
ViewShellBase const correctness
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac
(cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28)
(cherry picked from commit e1143d75eea07bdcd1e13d99a6015c1fc32bfb60)
Reviewed-on: https://gerrit.libreoffice.org/78432
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
-rw-r--r-- | include/sfx2/viewsh.hxx | 3 | ||||
-rw-r--r-- | sd/source/ui/framework/tools/FrameworkHelper.cxx | 8 | ||||
-rw-r--r-- | sd/source/ui/inc/framework/FrameworkHelper.hxx | 6 | ||||
-rw-r--r-- | sfx2/source/view/viewsh.cxx | 2 |
4 files changed, 9 insertions, 10 deletions
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx index cb185bb7b058..0f6915d8a9c0 100644 --- a/include/sfx2/viewsh.hxx +++ b/include/sfx2/viewsh.hxx @@ -281,8 +281,7 @@ public: void SetNewWindowAllowed( bool bSet ) { bNoNewWindow = !bSet; } void SetController( SfxBaseController* pController ); - css::uno::Reference< css::frame::XController > - GetController(); + css::uno::Reference<css::frame::XController> GetController() const; bool TryContextMenuInterception( Menu& rIn, const OUString& rMenuIdentifier, VclPtr<Menu>& rpOut, css::ui::ContextMenuExecuteEvent aEvent ); bool TryContextMenuInterception( Menu& rMenu, const OUString& rMenuIdentifier, css::ui::ContextMenuExecuteEvent aEvent ); diff --git a/sd/source/ui/framework/tools/FrameworkHelper.cxx b/sd/source/ui/framework/tools/FrameworkHelper.cxx index fb1c2acf35f0..b5bcee227e43 100644 --- a/sd/source/ui/framework/tools/FrameworkHelper.cxx +++ b/sd/source/ui/framework/tools/FrameworkHelper.cxx @@ -88,7 +88,7 @@ public: callback is destroyed. */ CallbackCaller ( - ::sd::ViewShellBase& rBase, + const ::sd::ViewShellBase& rBase, const OUString& rsEventType, const ::sd::framework::FrameworkHelper::ConfigurationChangeEventFilter& rFilter, const ::sd::framework::FrameworkHelper::Callback& rCallback); @@ -347,7 +347,7 @@ FrameworkHelper::InstanceMap FrameworkHelper::maInstanceMap; return pHelper; } -void FrameworkHelper::DisposeInstance (ViewShellBase& rBase) +void FrameworkHelper::DisposeInstance (const ViewShellBase& rBase) { InstanceMap::iterator iHelper (maInstanceMap.find(&rBase)); if (iHelper != maInstanceMap.end()) @@ -356,7 +356,7 @@ void FrameworkHelper::DisposeInstance (ViewShellBase& rBase) } } -void FrameworkHelper::ReleaseInstance (ViewShellBase& rBase) +void FrameworkHelper::ReleaseInstance (const ViewShellBase& rBase) { InstanceMap::iterator iHelper (maInstanceMap.find(&rBase)); if (iHelper != maInstanceMap.end()) @@ -834,7 +834,7 @@ namespace { //===== CallbackCaller ======================================================== CallbackCaller::CallbackCaller ( - ::sd::ViewShellBase& rBase, + const ::sd::ViewShellBase& rBase, const OUString& rsEventType, const ::sd::framework::FrameworkHelper::ConfigurationChangeEventFilter& rFilter, const ::sd::framework::FrameworkHelper::Callback& rCallback) diff --git a/sd/source/ui/inc/framework/FrameworkHelper.hxx b/sd/source/ui/inc/framework/FrameworkHelper.hxx index f4e44fab22db..20d7d0c9149a 100644 --- a/sd/source/ui/inc/framework/FrameworkHelper.hxx +++ b/sd/source/ui/inc/framework/FrameworkHelper.hxx @@ -114,14 +114,14 @@ public: Do not call this method. It is an internally used method that can not be made private. */ - static void DisposeInstance (ViewShellBase& rBase); + static void DisposeInstance (const ViewShellBase& rBase); /** Destroy the FrameworkHelper object for the given ViewShellBase. Do not call this method. It is an internally used method that can not be made private. */ - static void ReleaseInstance (ViewShellBase& rBase); + static void ReleaseInstance (const ViewShellBase& rBase); /** Return an identifier for the given view URL. This identifier can be used in a switch statement. See GetViewURL() for a mapping in the @@ -299,7 +299,7 @@ public: private: typedef ::std::map< - ViewShellBase*, + const ViewShellBase*, ::std::shared_ptr<FrameworkHelper> > InstanceMap; /** The instance map holds (at least) one FrameworkHelper instance for every ViewShellBase object. diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx index d3826d29d7ad..e7e61f40ec83 100644 --- a/sfx2/source/view/viewsh.cxx +++ b/sfx2/source/view/viewsh.cxx @@ -1762,7 +1762,7 @@ void SfxViewShell::SetController( SfxBaseController* pController ) pImpl->xClipboardListener = new SfxClipboardChangeListener( this, GetClipboardNotifier() ); } -Reference < XController > SfxViewShell::GetController() +Reference < XController > SfxViewShell::GetController() const { return pImpl->m_pController.get(); } |