clang-tidy performance-unnecessary-value-param in cui

Change-Id: I93a09bf8e475ec1aa2ebf7754c7048c81696922b

20 files changed, 26 insertions, 26 deletions

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index d89f288a1dcf..8f5c1c4c5395 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -3711,7 +3711,7 @@ ToolbarSaveInData::~ToolbarSaveInData()
 }
 
 void ToolbarSaveInData::SetSystemStyle(
-    uno::Reference< frame::XFrame > xFrame,
+    const uno::Reference< frame::XFrame >& xFrame,
     const OUString& rResourceURL,
     sal_Int32 nStyle )
 {
diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index 7120d233291c..2cdbfbaf3682 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -700,7 +700,7 @@ void SfxConfigGroupListBox::Init(const css::uno::Reference< css::uno::XComponent
 }
 
 Image SfxConfigGroupListBox::GetImage(
-    Reference< browse::XBrowseNode > node,
+    const Reference< browse::XBrowseNode >& node,
     Reference< XComponentContext > xCtx,
     bool bIsRootNode
 )
diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index 6e7c2dedcfa8..efffa6716992 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -712,7 +712,7 @@ long _SvxMacroTabPage::GenericHandler_Impl( _SvxMacroTabPage* pThis, PushButton*
 
 // pass in the XNameReplace.
 // can remove the 3rd arg once issue ?? is fixed
-void _SvxMacroTabPage::InitAndSetHandler( Reference< container::XNameReplace> xAppEvents, Reference< container::XNameReplace> xDocEvents, Reference< util::XModifiable > xModifiable )
+void _SvxMacroTabPage::InitAndSetHandler( const Reference< container::XNameReplace>& xAppEvents, const Reference< container::XNameReplace>& xDocEvents, const Reference< util::XModifiable >& xModifiable )
 {
     m_xAppEvents = xAppEvents;
     m_xDocEvents = xDocEvents;
@@ -799,7 +799,7 @@ Any _SvxMacroTabPage::GetPropsByName( const OUString& eventName, EventsHash& eve
 
 // converts the Any returned by GetByName into a pair which can be stored in
 // the EventHash
-::std::pair< OUString, OUString  > _SvxMacroTabPage::GetPairFromAny( Any aAny )
+::std::pair< OUString, OUString  > _SvxMacroTabPage::GetPairFromAny( const Any& aAny )
 {
     Sequence< beans::PropertyValue > props;
     OUString type, url;
diff --git a/cui/source/customize/selector.cxx b/cui/source/customize/selector.cxx
index 01d4f4246b37..eba339db7cdd 100644
--- a/cui/source/customize/selector.cxx
+++ b/cui/source/customize/selector.cxx
@@ -555,7 +555,7 @@ void SvxConfigGroupListBox::Init(bool bShowSlots, const Reference< frame::XFrame
 }
 
 Image SvxConfigGroupListBox::GetImage(
-    Reference< browse::XBrowseNode > node,
+    const Reference< browse::XBrowseNode >& node,
     Reference< XComponentContext > xCtx,
     bool bIsRootNode
 )
diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx
index 0a5815f6135d..75a14c890488 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -144,7 +144,7 @@ public:
     void                    SetErrorLanguageSelected(bool bSet){ m_bIsErrorLanguageSelected = bSet;}
     bool                    IsErrorLanguageSelected() const {return m_bIsErrorLanguageSelected;}
 
-    void                    SetDictionary(Reference<XDictionary> xDict) { m_xDictionary = xDict; }
+    void                    SetDictionary(const Reference<XDictionary>& xDict) { m_xDictionary = xDict; }
     Reference<XDictionary>  GetDictionary() const {return m_xDictionary;}
     void                    SetAddedWord(const OUString& rWord) {m_sAddedWord = rWord;}
     const OUString&         GetAddedWord() const { return m_sAddedWord;}
@@ -1580,7 +1580,7 @@ void SentenceEditWindow_Impl::dispose()
     VclMultiLineEdit::dispose();
 }
 
-bool SentenceEditWindow_Impl::MarkNextError( bool bIgnoreCurrentError, css::uno::Reference<css::linguistic2::XSpellChecker1> xSpell )
+bool SentenceEditWindow_Impl::MarkNextError( bool bIgnoreCurrentError, const css::uno::Reference<css::linguistic2::XSpellChecker1>& xSpell )
 {
     if (bIgnoreCurrentError)
         m_aIgnoreErrorsAt.insert( m_nErrorStart );
@@ -1775,7 +1775,7 @@ void SentenceEditWindow_Impl::RestoreCurrentError()
 }
 
 
-void SentenceEditWindow_Impl::SetAlternatives( Reference< XSpellAlternatives> xAlt )
+void SentenceEditWindow_Impl::SetAlternatives( const Reference< XSpellAlternatives>& xAlt )
 {
     TextPaM aCursor(0, m_nErrorStart);
     DBG_ASSERT(static_cast<const SpellErrorAttrib*>(
diff --git a/cui/source/dialogs/hangulhanjadlg.cxx b/cui/source/dialogs/hangulhanjadlg.cxx
index a073dfadc3ab..2e600ab9e91c 100644
--- a/cui/source/dialogs/hangulhanjadlg.cxx
+++ b/cui/source/dialogs/hangulhanjadlg.cxx
@@ -1465,7 +1465,7 @@ namespace svx
 
     namespace
     {
-        bool GetConversions(    Reference< XConversionDictionary >  _xDict,
+        bool GetConversions(    const Reference< XConversionDictionary >&  _xDict,
                                 const OUString& _rOrg,
                                 Sequence< OUString >& _rEntries )
         {
diff --git a/cui/source/dialogs/hlmarkwn.cxx b/cui/source/dialogs/hlmarkwn.cxx
index 10f8ead8f9eb..96e2a04c52a0 100644
--- a/cui/source/dialogs/hlmarkwn.cxx
+++ b/cui/source/dialogs/hlmarkwn.cxx
@@ -396,7 +396,7 @@ bool SvxHlinkDlgMarkWnd::RefreshFromDoc(const OUString& aURL)
 |*
 |************************************************************************/
 
-int SvxHlinkDlgMarkWnd::FillTree( uno::Reference< container::XNameAccess > xLinks, SvTreeListEntry* pParentEntry )
+int SvxHlinkDlgMarkWnd::FillTree( const uno::Reference< container::XNameAccess >& xLinks, SvTreeListEntry* pParentEntry )
 {
     int nEntries=0;
     const uno::Sequence< OUString > aNames( xLinks->getElementNames() );
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 0e8598629351..01dbaaa6889a 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -1140,7 +1140,7 @@ bool SvxScriptOrgDialog::getBoolProperty( Reference< beans::XPropertySet >& xPro
     return result;
 }
 
-OUString SvxScriptOrgDialog::getListOfChildren( Reference< browse::XBrowseNode > node, int depth )
+OUString SvxScriptOrgDialog::getListOfChildren( const Reference< browse::XBrowseNode >& node, int depth )
 {
     OUString result = "\n";
     for( int i=0;i<=depth;i++ )
diff --git a/cui/source/inc/SpellDialog.hxx b/cui/source/inc/SpellDialog.hxx
index e0ad793bff74..595035d497d4 100644
--- a/cui/source/inc/SpellDialog.hxx
+++ b/cui/source/inc/SpellDialog.hxx
@@ -88,14 +88,14 @@ public:
     void            SetAttrib( const TextAttrib& rAttr, sal_uLong nPara, sal_uInt16 nStart, sal_uInt16 nEnd );
     void            SetText( const OUString& rStr ) override;
 
-    bool            MarkNextError( bool bIgnoreCurrentError, css::uno::Reference<css::linguistic2::XSpellChecker1> );
+    bool            MarkNextError( bool bIgnoreCurrentError, const css::uno::Reference<css::linguistic2::XSpellChecker1>& );
     void            ChangeMarkedWord(const OUString& rNewWord, LanguageType eLanguage);
     void            MoveErrorMarkTo(sal_uInt16 nErrorStart, sal_uInt16 nErrorEnd, bool bGrammar);
     OUString        GetErrorText() const;
     void            RestoreCurrentError();
 
     void            SetAlternatives(
-                        css::uno::Reference<css::linguistic2::XSpellAlternatives> );
+                        const css::uno::Reference<css::linguistic2::XSpellAlternatives>& );
 
     const SpellErrorDescription* GetAlternatives();
 
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index 104f2e5af3ab..acbdc908a90d 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -635,7 +635,7 @@ public:
     void            SetSystemStyle( const OUString& rResourceURL, sal_Int32 nStyle );
 
     void            SetSystemStyle(
-        css::uno::Reference< css::frame::XFrame > xFrame,
+        const css::uno::Reference< css::frame::XFrame >& xFrame,
         const OUString& rResourceURL, sal_Int32 nStyle );
 
     SvxEntries*     GetEntries() override;
diff --git a/cui/source/inc/cfgutil.hxx b/cui/source/inc/cfgutil.hxx
index fddbdc17c0c5..7701291910d1 100644
--- a/cui/source/inc/cfgutil.hxx
+++ b/cui/source/inc/cfgutil.hxx
@@ -134,7 +134,7 @@ class SfxConfigGroupListBox : public SvTreeListBox
     css::uno::Reference< css::container::XNameAccess > m_xUICmdDescription;
 
     Image GetImage(
-        css::uno::Reference< css::script::browse::XBrowseNode > node,
+        const css::uno::Reference< css::script::browse::XBrowseNode >& node,
         css::uno::Reference< css::uno::XComponentContext > xCtx,
         bool bIsRootNode
     );
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index 671d4220da95..575d290095f6 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -754,7 +754,7 @@ public:
 
     void             SetPropertyList( XPropertyListType t, const XPropertyListRef &xRef );
 
-    void    SetColorList( XColorListRef pColList );
+    void    SetColorList( const XColorListRef& pColList );
     XColorListRef GetColorList() { return pColorList; }
     void    SaveToViewFrame( SfxViewFrame *pViewFrame );
     void    SetupForViewFrame( SfxViewFrame *pViewFrame );
diff --git a/cui/source/inc/hlmarkwn.hxx b/cui/source/inc/hlmarkwn.hxx
index 71b82b6712f1..6d3bb8a6e4a4 100644
--- a/cui/source/inc/hlmarkwn.hxx
+++ b/cui/source/inc/hlmarkwn.hxx
@@ -82,7 +82,7 @@ protected:
 
     SvTreeListEntry* FindEntry(const OUString& aStrName);
     void ClearTree();
-    int FillTree( css::uno::Reference< css::container::XNameAccess > xLinks, SvTreeListEntry* pParentEntry =nullptr );
+    int FillTree( const css::uno::Reference< css::container::XNameAccess >& xLinks, SvTreeListEntry* pParentEntry =nullptr );
 
     virtual void Move () override;
 
diff --git a/cui/source/inc/macropg.hxx b/cui/source/inc/macropg.hxx
index 5036d4b8f5e2..8f2afbd0bb80 100644
--- a/cui/source/inc/macropg.hxx
+++ b/cui/source/inc/macropg.hxx
@@ -79,7 +79,7 @@ protected:
 
     void                        EnableButtons();
     static css::uno::Any  GetPropsByName( const OUString& eventName, EventsHash& eventsHash );
-    static ::std::pair< OUString, OUString > GetPairFromAny( css::uno::Any aAny );
+    static ::std::pair< OUString, OUString > GetPairFromAny( const css::uno::Any& aAny );
 
 public:
 
@@ -87,7 +87,7 @@ public:
     virtual void                dispose() override;
     void                        InitResources();
 
-    void                        InitAndSetHandler( css::uno::Reference< css::container::XNameReplace > xAppEvents, css::uno::Reference< css::container::XNameReplace > xDocEvents, css::uno::Reference< css::util::XModifiable > xModifiable );
+    void                        InitAndSetHandler( const css::uno::Reference< css::container::XNameReplace >& xAppEvents, const css::uno::Reference< css::container::XNameReplace >& xDocEvents, const css::uno::Reference< css::util::XModifiable >& xModifiable );
     virtual bool                FillItemSet( SfxItemSet* rSet ) override;
 
     virtual void                Reset( const SfxItemSet* ) override;
diff --git a/cui/source/inc/scriptdlg.hxx b/cui/source/inc/scriptdlg.hxx
index 1dcfc36b7445..53c92b05ef3a 100644
--- a/cui/source/inc/scriptdlg.hxx
+++ b/cui/source/inc/scriptdlg.hxx
@@ -167,7 +167,7 @@ protected:
     static css::uno::Reference< css::script::browse::XBrowseNode >
                 getBrowseNode( SvTreeListEntry* pEntry );
     static css::uno::Reference< css::frame::XModel > getModel( SvTreeListEntry* pEntry );
-    OUString    getListOfChildren( css::uno::Reference< css::script::browse::XBrowseNode > node, int depth );
+    OUString    getListOfChildren( const css::uno::Reference< css::script::browse::XBrowseNode >& node, int depth );
     void        StoreCurrentSelection();
     void        RestorePreviousSelection();
 
diff --git a/cui/source/inc/selector.hxx b/cui/source/inc/selector.hxx
index d9b617290239..98b7991b2384 100644
--- a/cui/source/inc/selector.hxx
+++ b/cui/source/inc/selector.hxx
@@ -135,7 +135,7 @@ class SvxConfigGroupListBox : public SvTreeListBox
     OUString m_sMyMacros;
     OUString m_sProdMacros;
     Image GetImage(
-        css::uno::Reference< css::script::browse::XBrowseNode > node,
+        const css::uno::Reference< css::script::browse::XBrowseNode >& node,
         css::uno::Reference< css::uno::XComponentContext > xCtx,
         bool bIsRootNode
     );
diff --git a/cui/source/options/connpooloptions.cxx b/cui/source/options/connpooloptions.cxx
index 4f09494d9636..df1949946797 100644
--- a/cui/source/options/connpooloptions.cxx
+++ b/cui/source/options/connpooloptions.cxx
@@ -84,7 +84,7 @@ namespace offapp
 
 
     private:
-        OUString implGetCellText(DriverPoolingSettings::const_iterator _rPos, sal_uInt16 _nColId) const;
+        OUString implGetCellText(const DriverPoolingSettings::const_iterator& _rPos, sal_uInt16 _nColId) const;
     };
 
 
@@ -192,7 +192,7 @@ namespace offapp
     }
 
 
-    OUString DriverListControl::implGetCellText(DriverPoolingSettings::const_iterator _rPos, sal_uInt16 _nColId) const
+    OUString DriverListControl::implGetCellText(const DriverPoolingSettings::const_iterator& _rPos, sal_uInt16 _nColId) const
     {
         OSL_ENSURE(_rPos < m_aSettings.end(), "DriverListControl::implGetCellText: invalid position!");
 
diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx
index 3532d56bb91a..bd97e912b2ff 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -220,7 +220,7 @@ void SelectPersonaDialog::SetProgress( OUString& rProgress )
     }
 }
 
-void SelectPersonaDialog::SetImages( Image aImage, sal_Int32 nIndex )
+void SelectPersonaDialog::SetImages( const Image& aImage, sal_Int32 nIndex )
 {
     m_vResultList[nIndex]->Enable();
     m_vResultList[nIndex]->SetModeImage( aImage );
diff --git a/cui/source/options/personalization.hxx b/cui/source/options/personalization.hxx
index ea92dc22900d..362fa6cdc5d1 100644
--- a/cui/source/options/personalization.hxx
+++ b/cui/source/options/personalization.hxx
@@ -98,7 +98,7 @@ public:
 
     OUString GetSelectedPersona() const;
     void SetProgress( OUString& );
-    void SetImages( Image, sal_Int32 );
+    void SetImages( const Image&, sal_Int32 );
     void AddPersonaSetting( OUString& );
     void ClearSearchResults();
     void SetAppliedPersonaSetting( OUString& );
diff --git a/cui/source/tabpages/tpcolor.cxx b/cui/source/tabpages/tpcolor.cxx
index f376503c57b3..033dbf109d85 100644
--- a/cui/source/tabpages/tpcolor.cxx
+++ b/cui/source/tabpages/tpcolor.cxx
@@ -1180,7 +1180,7 @@ void SvxColorTabPage::SetPropertyList( XPropertyListType t, const XPropertyListR
     pColorList = XColorListRef( static_cast<XColorList *>(xRef.get() ) );
 }
 
-void SvxColorTabPage::SetColorList( XColorListRef pColList )
+void SvxColorTabPage::SetColorList( const XColorListRef& pColList )
 {
     SetPropertyList( XCOLOR_LIST, XPropertyListRef( ( pColList.get() ) ) );
 }