diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-17 16:11:45 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-20 21:53:47 +0200 |
commit | fb74f7b6631d0c01de9919dfe77894588dea1c45 (patch) | |
tree | 7dd05b154af57b234f3346ef21f8769005da1769 | |
parent | 1d5261adcc7ad4178a242651449d189fdbdd91a9 (diff) |
loplugin:virtualdead unused param in SvListView::ModelIsMoving
Change-Id: I83af14bb3a29cb8a4a36f714ac2fb91687f13996
Reviewed-on: https://gerrit.libreoffice.org/81156
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r-- | compilerplugins/clang/virtualdead.unusedparams.results | 3 | ||||
-rw-r--r-- | include/vcl/treelist.hxx | 6 | ||||
-rw-r--r-- | include/vcl/treelistbox.hxx | 3 | ||||
-rw-r--r-- | vcl/source/treelist/treelist.cxx | 7 | ||||
-rw-r--r-- | vcl/source/treelist/treelistbox.cxx | 4 |
5 files changed, 6 insertions, 17 deletions
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results index a22567d37cea..186a2780eaba 100644 --- a/compilerplugins/clang/virtualdead.unusedparams.results +++ b/compilerplugins/clang/virtualdead.unusedparams.results @@ -214,9 +214,6 @@ include/vcl/opengl/OpenGLContext.hxx:141 include/vcl/task.hxx:71 unsigned long Task::UpdateMinPeriod(unsigned long,unsigned long,)const 01 -include/vcl/treelist.hxx:304 - void SvListView::ModelIsMoving(class SvTreeListEntry *,class SvTreeListEntry *,unsigned long,) - 100 include/xmloff/xmlimp.hxx:244 class SvXMLImportContext * SvXMLImport::CreateDocumentContext(const unsigned short,const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::xml::sax::XAttributeList> &,) 110 diff --git a/include/vcl/treelist.hxx b/include/vcl/treelist.hxx index 61b7ea742832..2d8fc7b4379d 100644 --- a/include/vcl/treelist.hxx +++ b/include/vcl/treelist.hxx @@ -299,11 +299,7 @@ public: virtual void ModelHasCleared(); virtual void ModelHasInserted( SvTreeListEntry* pEntry ); virtual void ModelHasInsertedTree( SvTreeListEntry* pEntry ); - virtual void ModelIsMoving( - SvTreeListEntry* pSource, - SvTreeListEntry* pTargetParent, - sal_uLong nPos - ); + virtual void ModelIsMoving( SvTreeListEntry* pSource ); virtual void ModelHasMoved( SvTreeListEntry* pSource ); virtual void ModelIsRemoving( SvTreeListEntry* pEntry ); virtual void ModelHasRemoved( SvTreeListEntry* pEntry ); diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx index 0606f106a087..4dcd516cea22 100644 --- a/include/vcl/treelistbox.hxx +++ b/include/vcl/treelistbox.hxx @@ -634,8 +634,7 @@ public: virtual void ModelHasCleared() override; virtual void ModelHasInserted( SvTreeListEntry* pEntry ) override; virtual void ModelHasInsertedTree( SvTreeListEntry* pEntry ) override; - virtual void ModelIsMoving(SvTreeListEntry* pSource, - SvTreeListEntry* pTargetParent, sal_uLong nChildPos ) override; + virtual void ModelIsMoving(SvTreeListEntry* pSource ) override; virtual void ModelHasMoved(SvTreeListEntry* pSource ) override; virtual void ModelIsRemoving( SvTreeListEntry* pEntry ) override; virtual void ModelHasRemoved( SvTreeListEntry* pEntry ) override; diff --git a/vcl/source/treelist/treelist.cxx b/vcl/source/treelist/treelist.cxx index 49ac19692756..11a4221e5305 100644 --- a/vcl/source/treelist/treelist.cxx +++ b/vcl/source/treelist/treelist.cxx @@ -1157,8 +1157,7 @@ void SvListView::ModelHasInsertedTree( SvTreeListEntry* ) { } -void SvListView::ModelIsMoving( SvTreeListEntry* /* pSource */ , - SvTreeListEntry* /* pTargetParent */ , sal_uLong /* nPos */ ) +void SvListView::ModelIsMoving( SvTreeListEntry* /* pSource */ ) { } @@ -1292,7 +1291,7 @@ void SvListView::Impl::ActionClear() } void SvListView::ModelNotification( SvListAction nActionId, SvTreeListEntry* pEntry1, - SvTreeListEntry* pEntry2, sal_uLong nPos ) + SvTreeListEntry* /*pEntry2*/, sal_uLong /*nPos*/ ) { switch( nActionId ) { @@ -1312,7 +1311,7 @@ void SvListView::ModelNotification( SvListAction nActionId, SvTreeListEntry* pEn ModelHasRemoved( pEntry1 ); break; case SvListAction::MOVING: - ModelIsMoving( pEntry1, pEntry2, nPos ); + ModelIsMoving( pEntry1 ); m_pImpl->ActionMoving( pEntry1 ); break; case SvListAction::MOVED: diff --git a/vcl/source/treelist/treelistbox.cxx b/vcl/source/treelist/treelistbox.cxx index 6569fc6b7c82..529839943445 100644 --- a/vcl/source/treelist/treelistbox.cxx +++ b/vcl/source/treelist/treelistbox.cxx @@ -2230,9 +2230,7 @@ void SvTreeListBox::ModelHasInserted( SvTreeListEntry* pEntry ) pImpl->EntryInserted( pEntry ); } -void SvTreeListBox::ModelIsMoving(SvTreeListEntry* pSource, - SvTreeListEntry* /* pTargetParent */, - sal_uLong /* nChildPos */ ) +void SvTreeListBox::ModelIsMoving(SvTreeListEntry* pSource ) { pImpl->MovingEntry( pSource ); } |