loplugin:constvars in sccomp..sd

Change-Id: Ic4b2a1d23da80a5b0976692f490c29a7169be3ef
Reviewed-on: https://gerrit.libreoffice.org/77793
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

28 files changed, 47 insertions, 46 deletions

diff --git a/sccomp/source/solver/SwarmSolver.cxx b/sccomp/source/solver/SwarmSolver.cxx
index 25bccc57970b..6652127dc9b2 100644
--- a/sccomp/source/solver/SwarmSolver.cxx
+++ b/sccomp/source/solver/SwarmSolver.cxx
@@ -400,7 +400,7 @@ size_t SwarmSolver::getDimensionality() { return maVariables.getLength(); }
 
 bool SwarmSolver::doesViolateConstraints()
 {
-    for (sheet::SolverConstraint& rConstraint : maNonBoundedConstraints)
+    for (const sheet::SolverConstraint& rConstraint : maNonBoundedConstraints)
     {
         double fLeftValue = getValue(rConstraint.Left);
         double fRightValue = 0.0;
@@ -520,7 +520,7 @@ void SAL_CALL SwarmSolver::solve()
 
         size_t index = 0;
         bool bFoundVariable = false;
-        for (table::CellAddress& rVariableCell : maVariables)
+        for (const table::CellAddress& rVariableCell : std::as_const(maVariables))
         {
             if (aLeftCellAddress == rVariableCell)
             {
diff --git a/scripting/source/provider/BrowseNodeFactoryImpl.cxx b/scripting/source/provider/BrowseNodeFactoryImpl.cxx
index 92ce1be6c273..83d3cbec80aa 100644
--- a/scripting/source/provider/BrowseNodeFactoryImpl.cxx
+++ b/scripting/source/provider/BrowseNodeFactoryImpl.cxx
@@ -190,7 +190,7 @@ public:
         Sequence<  Reference< browse::XBrowseNode > > children( m_hBNA->size() );
         sal_Int32 index = 0;
 
-        for ( auto& str : m_vStr )
+        for ( const auto& str : m_vStr )
         {
             children[ index ].set( m_hBNA->find( str )->second );
             ++index;
diff --git a/scripting/source/provider/MasterScriptProvider.cxx b/scripting/source/provider/MasterScriptProvider.cxx
index 8fb19dc8ac09..7a5475541179 100644
--- a/scripting/source/provider/MasterScriptProvider.cxx
+++ b/scripting/source/provider/MasterScriptProvider.cxx
@@ -456,7 +456,8 @@ template <typename Proc> bool FindProviderAndApply(ProviderCache& rCache, Proc p
     auto pass = [&rCache, &p]() -> bool
     {
         bool bResult = false;
-        for (auto& rProv : rCache.getAllProviders())
+        const Sequence<Reference<provider::XScriptProvider>> aAllProviders = rCache.getAllProviders();
+        for (const auto& rProv : aAllProviders)
         {
             Reference<container::XNameContainer> xCont(rProv, UNO_QUERY);
             if (!xCont.is())
diff --git a/scripting/source/stringresource/stringresource.cxx b/scripting/source/stringresource/stringresource.cxx
index b74f76c23906..2da2fe5be1e1 100644
--- a/scripting/source/stringresource/stringresource.cxx
+++ b/scripting/source/stringresource/stringresource.cxx
@@ -272,7 +272,7 @@ Sequence< Locale > StringResourceImpl::getLocales(  )
     Sequence< Locale > aLocalSeq( nSize );
     Locale* pLocales = aLocalSeq.getArray();
     int iTarget = 0;
-    for( auto& pLocaleItem : m_aLocaleItemVector )
+    for( const auto& pLocaleItem : m_aLocaleItemVector )
     {
         pLocales[iTarget] = pLocaleItem->m_locale;
         iTarget++;
@@ -489,7 +489,7 @@ void StringResourceImpl::removeLocale( const Locale& locale )
                 m_pDefaultLocaleItem  == pRemoveItem )
             {
                 LocaleItem* pFallbackItem = nullptr;
-                for( auto& pLocaleItem : m_aLocaleItemVector )
+                for( const auto& pLocaleItem : m_aLocaleItemVector )
                 {
                     if( pLocaleItem.get() != pRemoveItem )
                     {
@@ -610,7 +610,7 @@ LocaleItem* StringResourceImpl::getClosestMatchItemForLocale( const Locale& loca
 
     ::std::vector< Locale > aLocales( m_aLocaleItemVector.size());
     size_t i = 0;
-    for( auto& pLocaleItem : m_aLocaleItemVector )
+    for( const auto& pLocaleItem : m_aLocaleItemVector )
     {
         aLocales[i] = (pLocaleItem ? pLocaleItem->m_locale : Locale());
         ++i;
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index e9a6a49ddceb..8ac645c97765 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -323,7 +323,7 @@ void SdTiledRenderingTest::callbackImpl(int nType, const char* pPayload)
         boost::property_tree::ptree aTree;
         std::stringstream aStream(pPayload);
         boost::property_tree::read_json(aStream, aTree);
-        for (boost::property_tree::ptree::value_type& rValue : aTree.get_child("searchResultSelection"))
+        for (const boost::property_tree::ptree::value_type& rValue : aTree.get_child("searchResultSelection"))
         {
             m_aSearchResultSelection.emplace_back(rValue.second.get<std::string>("rectangles").c_str());
             m_aSearchResultPart.push_back(std::atoi(rValue.second.get<std::string>("part").c_str()));
diff --git a/sd/source/core/CustomAnimationEffect.cxx b/sd/source/core/CustomAnimationEffect.cxx
index a6f75ee9cdc0..102df7fb1f2f 100644
--- a/sd/source/core/CustomAnimationEffect.cxx
+++ b/sd/source/core/CustomAnimationEffect.cxx
@@ -2533,7 +2533,7 @@ void EffectSequenceHelper::setTextGrouping( const CustomAnimationTextGroupPtr& p
         EffectSequence aEffects( pTextGroup->maEffects );
         pTextGroup->reset();
 
-        for( CustomAnimationEffectPtr& pEffect : aEffects )
+        for( const CustomAnimationEffectPtr& pEffect : aEffects )
         {
             if( pEffect->getTarget().getValueType() == ::cppu::UnoType<ParagraphTarget>::get() )
                 remove( pEffect );
diff --git a/sd/source/core/EffectMigration.cxx b/sd/source/core/EffectMigration.cxx
index 7aa7be5fe62b..8f73d7bb8883 100644
--- a/sd/source/core/EffectMigration.cxx
+++ b/sd/source/core/EffectMigration.cxx
@@ -1125,7 +1125,7 @@ void EffectMigration::SetPresentationOrder( SvxShape* pShape, sal_Int32 nNewPos
 
     std::vector< CustomAnimationEffectPtr > aEffects;
 
-    for( auto& rIter : aEffectVector[nCurrentPos] )
+    for( const auto& rIter : aEffectVector[nCurrentPos] )
     {
         aEffects.push_back( *rIter );
         rSequence.erase( rIter );
@@ -1164,7 +1164,7 @@ sal_Int32 EffectMigration::GetPresentationOrder( SvxShape* pShape )
     Reference< XShape > xThis( pShape );
     Reference< XShape > xCurrent;
 
-    for( CustomAnimationEffectPtr& pEffect : rSequence )
+    for( const CustomAnimationEffectPtr& pEffect : rSequence )
     {
         if( !xCurrent.is() || pEffect->getTargetShape() != xCurrent )
         {
diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx
index a1e988d9c9d7..12691c5175a8 100644
--- a/sd/source/core/sdpage2.cxx
+++ b/sd/source/core/sdpage2.cxx
@@ -194,7 +194,7 @@ void SdPage::SetPresentationLayout(const OUString& rLayoutName,
 
             std::vector<SfxStyleSheetBase*>::iterator iterOldOut = aOldOutlineStyles.begin();
 
-            for (auto& rpOut : aOutlineStyles)
+            for (const auto& rpOut : aOutlineStyles)
             {
                 SfxStyleSheet* pSheet = static_cast<SfxStyleSheet*>(rpOut);
                 SfxStyleSheet* pOldSheet = static_cast<SfxStyleSheet*>(*iterOldOut);
@@ -264,7 +264,7 @@ void SdPage::EndListenOutlineText()
     std::vector<SfxStyleSheetBase*> aOutlineStyles;
     pSPool->CreateOutlineSheetList(aTrueLayoutName,aOutlineStyles);
 
-    for (auto& rpStyle : aOutlineStyles)
+    for (const auto& rpStyle : aOutlineStyles)
     {
         SfxStyleSheet *pSheet = static_cast<SfxStyleSheet*>(rpStyle);
         pOutlineTextObj->EndListening(*pSheet);
diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index d9c6b62656b5..a477636e49ab 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -1231,7 +1231,7 @@ void PPTWriter::ImplWriteOLE( )
 
     SvxMSExportOLEObjects aOleExport( mnCnvrtFlags );
 
-    for ( auto& rxExOleObjEntry : maExOleObj )
+    for ( const auto& rxExOleObjEntry : maExOleObj )
     {
         PPTExOleObjEntry* pPtr = rxExOleObjEntry.get();
         std::unique_ptr<SvMemoryStream> pStrm;
@@ -1355,7 +1355,7 @@ void PPTWriter::ImplWriteAtomEnding()
         }
     }
     // Ole persists
-    for ( auto& rxExOleObjEntry : maExOleObj )
+    for ( const auto& rxExOleObjEntry : maExOleObj )
     {
         PPTExOleObjEntry* pPtr = rxExOleObjEntry.get();
         nOfs = mpPptEscherEx->PtGetOffsetByID( EPP_Persist_ExObj );
diff --git a/sd/source/filter/html/buttonset.cxx b/sd/source/filter/html/buttonset.cxx
index 50ea0d7c251a..c4b1523d7e59 100644
--- a/sd/source/filter/html/buttonset.cxx
+++ b/sd/source/filter/html/buttonset.cxx
@@ -223,7 +223,7 @@ bool ButtonSetImpl::getPreview( int nSet, const std::vector< OUString >& rButton
 
         Point aPos;
 
-        for( Graphic& aGraphic : aGraphics )
+        for( const Graphic& aGraphic : aGraphics )
         {
             aGraphic.Draw( pDev, aPos );
 
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx b/sd/source/filter/pdf/sdpdffilter.cxx
index e6d3a02b3023..3fe38252b626 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -74,7 +74,7 @@ bool SdPdfFilter::Import()
     }
 
     size_t nPageNumber = 0;
-    for (Bitmap& aBitmap : aBitmaps)
+    for (const Bitmap& aBitmap : aBitmaps)
     {
         // Create the Graphic and link the original PDF stream.
         Graphic aGraphic(aBitmap);
diff --git a/sd/source/ui/animations/CustomAnimationDialog.cxx b/sd/source/ui/animations/CustomAnimationDialog.cxx
index 124af14f6b52..4f68909bda7a 100644
--- a/sd/source/ui/animations/CustomAnimationDialog.cxx
+++ b/sd/source/ui/animations/CustomAnimationDialog.cxx
@@ -138,7 +138,7 @@ void PresetPropertyBox::setValue( const Any& rValue, const OUString& rPresetId )
 
         mpControl->Enable( !aSubTypes.empty() );
 
-        for( auto& aSubType : aSubTypes )
+        for( const auto& aSubType : aSubTypes )
         {
             sal_Int32 nPos = mpControl->InsertEntry( rPresets.getUINameForProperty( aSubType ) );
             if( aSubType == aPropertyValue )
@@ -225,7 +225,7 @@ void SdPresetPropertyBox::setValue( const Any& rValue, const OUString& rPresetId
 
         mxControl->set_sensitive(!aSubTypes.empty());
 
-        for( auto& aSubType : aSubTypes )
+        for( const auto& aSubType : aSubTypes )
         {
             mxControl->append_text(rPresets.getUINameForProperty(aSubType));
             maPropertyValues.push_back(aSubType);
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx
index 4eb984ba370e..275575e64cf9 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -693,7 +693,7 @@ sal_Int8 CustomAnimationList::ExecuteDrop( const ExecuteDropEvent& /*rEvt*/ )
 
         // Build list of effects
         std::vector< CustomAnimationEffectPtr > aEffects;
-        for( auto &pEntry : mDndEffectsSelected )
+        for( const auto &pEntry : mDndEffectsSelected )
         {
             CustomAnimationListEntry* pCustomAnimationEffect = static_cast< CustomAnimationListEntry* >( pEntry );
             aEffects.push_back( pCustomAnimationEffect->getEffect() );
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx
index f5ad1821e367..5791772c1b31 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -715,7 +715,7 @@ void CustomAnimationPane::updateControls()
             MainSequenceRebuildGuard aGuard( mpMainSequence );
 
             EffectSequenceHelper* pSequence = nullptr;
-            for( CustomAnimationEffectPtr& pEffect : maListSelection )
+            for( const CustomAnimationEffectPtr& pEffect : maListSelection )
             {
                 if( pEffect.get() )
                 {
@@ -2040,7 +2040,7 @@ IMPL_LINK_NOARG(CustomAnimationPane, implPropertyHdl, LinkParamNone*, void)
     bool bNeedUpdate = false;
 
     // change selected effect
-    for( CustomAnimationEffectPtr& pEffect : maListSelection )
+    for( const CustomAnimationEffectPtr& pEffect : maListSelection )
     {
         if( setProperty1Value( mnPropertyType, pEffect, aValue ) )
             bNeedUpdate = true;
@@ -2097,7 +2097,7 @@ IMPL_LINK_NOARG(CustomAnimationPane, AnimationSelectHdl, ListBox&, void)
         std::vector< Any > aTargets;
         MainSequenceRebuildGuard aGuard( mpMainSequence );
 
-        for( CustomAnimationEffectPtr& pEffect : maListSelection )
+        for( const CustomAnimationEffectPtr& pEffect : maListSelection )
         {
             aTargets.push_back( pEffect->getTarget() );
 
@@ -2120,7 +2120,7 @@ IMPL_LINK_NOARG(CustomAnimationPane, AnimationSelectHdl, ListBox&, void)
     MainSequenceRebuildGuard aGuard( mpMainSequence );
 
     // get selected effect
-    for( CustomAnimationEffectPtr& pEffect : maListSelection )
+    for( const CustomAnimationEffectPtr& pEffect : maListSelection )
     {
         // Dispose the deprecated motion path tag. It will be rebuilt later.
         if (pEffect->getPresetClass() == css::presentation::EffectPresetClass::MOTIONPATH)
@@ -2277,7 +2277,7 @@ void CustomAnimationPane::moveSelection( bool bUp )
 
     if( bUp )
     {
-        for( CustomAnimationEffectPtr& pEffect : maListSelection )
+        for( const CustomAnimationEffectPtr& pEffect : maListSelection )
         {
             EffectSequence::iterator aUpEffectPos( pSequence->find( pEffect ) );
             // coverity[copy_paste_error : FALSE] - this is correct, checking if it exists
@@ -2382,7 +2382,7 @@ void CustomAnimationPane::onPreview( bool bForcePreview )
     {
         MainSequencePtr pSequence( new MainSequence() );
 
-        for( CustomAnimationEffectPtr& pEffect : maListSelection )
+        for( const CustomAnimationEffectPtr& pEffect : maListSelection )
         {
             pSequence->append( pEffect->clone() );
         }
diff --git a/sd/source/ui/dlg/BulletAndPositionDlg.cxx b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
index 23e5b5de2d36..f22a659a4779 100644
--- a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
+++ b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
@@ -914,7 +914,7 @@ IMPL_LINK_NOARG(SvxBulletAndPositionDlg, PopupActivateHdl_Impl, weld::ToggleButt
             OUString sGrfName;
             ScopedVclPtrInstance<VirtualDevice> pVD;
             size_t i = 0;
-            for (auto& grfName : aGrfNames)
+            for (const auto& grfName : aGrfNames)
             {
                 sGrfName = grfName;
                 OUString sItemId = "gallery" + OUString::number(i);
diff --git a/sd/source/ui/dlg/tpaction.cxx b/sd/source/ui/dlg/tpaction.cxx
index d7e74eb12ccf..c5c1f6fb51db 100644
--- a/sd/source/ui/dlg/tpaction.cxx
+++ b/sd/source/ui/dlg/tpaction.cxx
@@ -234,7 +234,7 @@ void SdTPAction::Construct()
     maCurrentActions.push_back( presentation::ClickAction_STOPPRESENTATION );
 
     // fill Action-Listbox
-    for (presentation::ClickAction & rAction : maCurrentActions)
+    for (const presentation::ClickAction & rAction : maCurrentActions)
     {
         const char* pRId = GetClickActionSdResId(rAction);
         m_xLbAction->append_text(SdResId(pRId));
diff --git a/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx b/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx
index 9ed25ff10af5..bb490c9b91df 100644
--- a/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx
+++ b/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx
@@ -201,7 +201,7 @@ void ConfigurationUpdater::CleanRequestedConfiguration()
     {
         Reference<XConfigurationController> xCC (
             mxControllerManager->getConfigurationController());
-        for (auto& rxId : aResourcesToDeactivate)
+        for (const auto& rxId : aResourcesToDeactivate)
             if (rxId.is())
                 xCC->requestResourceDeactivation(rxId);
     }
diff --git a/sd/source/ui/func/unmovss.cxx b/sd/source/ui/func/unmovss.cxx
index eaa37a73a695..d21f83b39af2 100644
--- a/sd/source/ui/func/unmovss.cxx
+++ b/sd/source/ui/func/unmovss.cxx
@@ -31,7 +31,7 @@ SdMoveStyleSheetsUndoAction::SdMoveStyleSheetsUndoAction( SdDrawDocument* pTheDo
     maListOfChildLists.resize( maStyles.size() );
     // create list with lists of style sheet children
     std::size_t i = 0;
-    for (auto& a : maStyles)
+    for (const auto& a : maStyles)
     {
         maListOfChildLists[i++] = SdStyleSheetPool::CreateChildList(a.m_xStyleSheet.get());
     }
@@ -55,7 +55,7 @@ void SdMoveStyleSheetsUndoAction::Undo()
 
         // now assign the children again
         std::vector< SdStyleSheetVector >::iterator childlistiter( maListOfChildLists.begin() );
-        for (auto& a : maStyles)
+        for (const auto& a : maStyles)
         {
             OUString aParent(a.m_xStyleSheet->GetName());
             for( auto& rxChild : *childlistiter )
diff --git a/sd/source/ui/presenter/PresenterTextView.cxx b/sd/source/ui/presenter/PresenterTextView.cxx
index 0ebdd603ae28..8e2edc8d9326 100644
--- a/sd/source/ui/presenter/PresenterTextView.cxx
+++ b/sd/source/ui/presenter/PresenterTextView.cxx
@@ -247,7 +247,7 @@ PresenterTextView::Implementation::Implementation()
     aTable[1].nLang = MsLangId::resolveSystemLanguageByScriptType(aOpt.nDefaultLanguage_CJK, css::i18n::ScriptType::ASIAN);
     aTable[2].nLang = MsLangId::resolveSystemLanguageByScriptType(aOpt.nDefaultLanguage_CTL, css::i18n::ScriptType::COMPLEX);
 
-    for (FontDta & rFntDta : aTable)
+    for (const FontDta & rFntDta : aTable)
     {
         LanguageType nLang = (LANGUAGE_NONE == rFntDta.nLang) ?
             rFntDta.nFallbackLang : rFntDta.nLang;
diff --git a/sd/source/ui/sidebar/MasterPageContainer.cxx b/sd/source/ui/sidebar/MasterPageContainer.cxx
index 971f164bd2fc..eda233ea18ea 100644
--- a/sd/source/ui/sidebar/MasterPageContainer.cxx
+++ b/sd/source/ui/sidebar/MasterPageContainer.cxx
@@ -672,7 +672,7 @@ MasterPageContainer::Token MasterPageContainer::Implementation::PutMasterPage (
             // appropriate events to the listeners.
             UpdateDescriptor(*aEntry,false,false, true);
 
-            for (auto& rEventType : *pEventTypes)
+            for (const auto& rEventType : *pEventTypes)
             {
                 FireContainerChange(rEventType, (*aEntry)->maToken);
             }
@@ -922,7 +922,7 @@ void MasterPageContainer::Implementation::FireContainerChange (
     MasterPageContainerChangeEvent aEvent;
     aEvent.meEventType = eType;
     aEvent.maChildToken = aToken;
-    for (auto& rListener : aCopy)
+    for (const auto& rListener : aCopy)
         rListener.Call(aEvent);
 }
 
diff --git a/sd/source/ui/sidebar/MasterPageObserver.cxx b/sd/source/ui/sidebar/MasterPageObserver.cxx
index 232ea0e3c73e..28f1938f583d 100644
--- a/sd/source/ui/sidebar/MasterPageObserver.cxx
+++ b/sd/source/ui/sidebar/MasterPageObserver.cxx
@@ -278,7 +278,7 @@ void MasterPageObserver::Implementation::AnalyzeUsedMasterPages (
         aOldMasterPagesDescriptor->second.begin(),
         aOldMasterPagesDescriptor->second.end(),
         std::back_inserter(aNewMasterPages));
-    for (auto& aNewMasterPage : aNewMasterPages)
+    for (const auto& aNewMasterPage : aNewMasterPages)
     {
         MasterPageObserverEvent aEvent (
             MasterPageObserverEvent::ET_MASTER_PAGE_ADDED,
@@ -293,7 +293,7 @@ void MasterPageObserver::Implementation::AnalyzeUsedMasterPages (
         aCurrentMasterPages.begin(),
         aCurrentMasterPages.end(),
         std::back_inserter(aRemovedMasterPages));
-    for (auto& aRemovedMasterPage : aRemovedMasterPages)
+    for (const auto& aRemovedMasterPage : aRemovedMasterPages)
     {
         MasterPageObserverEvent aEvent (
             MasterPageObserverEvent::ET_MASTER_PAGE_REMOVED,
@@ -308,7 +308,7 @@ void MasterPageObserver::Implementation::AnalyzeUsedMasterPages (
 void MasterPageObserver::Implementation::SendEvent (
     MasterPageObserverEvent& rEvent)
 {
-    for (auto& aLink : maListeners)
+    for (const auto& aLink : maListeners)
     {
         aLink.Call(rEvent);
     }
diff --git a/sd/source/ui/sidebar/RecentlyUsedMasterPages.cxx b/sd/source/ui/sidebar/RecentlyUsedMasterPages.cxx
index a5ce3f997aba..b6783aa0abce 100644
--- a/sd/source/ui/sidebar/RecentlyUsedMasterPages.cxx
+++ b/sd/source/ui/sidebar/RecentlyUsedMasterPages.cxx
@@ -271,7 +271,7 @@ MasterPageContainer::Token RecentlyUsedMasterPages::GetTokenForIndex (sal_uInt32
 
 void RecentlyUsedMasterPages::SendEvent()
 {
-    for (auto& aLink : maListeners)
+    for (const auto& aLink : maListeners)
     {
         aLink.Call(nullptr);
     }
diff --git a/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx b/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx
index ba8273d7628a..132b3d6e2904 100644
--- a/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx
@@ -220,7 +220,7 @@ void FocusManager::NotifyFocusChangeListeners() const
     ::std::vector<Link<LinkParamNone*,void>> aListeners (maFocusChangeListeners);
 
     // Tell the selection change listeners that the selection has changed.
-    for (auto& rListener : aListeners)
+    for (const auto& rListener : aListeners)
     {
         rListener.Call(nullptr);
     }
diff --git a/sd/source/ui/slidesorter/controller/SlsSelectionManager.cxx b/sd/source/ui/slidesorter/controller/SlsSelectionManager.cxx
index 478e065ae40a..c73abad8d07c 100644
--- a/sd/source/ui/slidesorter/controller/SlsSelectionManager.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsSelectionManager.cxx
@@ -237,7 +237,7 @@ void SelectionManager::SelectionHasChanged ()
         pViewShell->UpdatePreview(pDescriptor->GetPage());
 
     // Tell the selection change listeners that the selection has changed.
-    for (auto& rLink : maSelectionChangeListeners)
+    for (const auto& rLink : maSelectionChangeListeners)
     {
         rLink.Call(nullptr);
     }
diff --git a/sd/source/ui/tools/EventMultiplexer.cxx b/sd/source/ui/tools/EventMultiplexer.cxx
index 1dcb9b1c28d0..ee2e7e4fd0ca 100644
--- a/sd/source/ui/tools/EventMultiplexer.cxx
+++ b/sd/source/ui/tools/EventMultiplexer.cxx
@@ -636,7 +636,7 @@ void EventMultiplexer::Implementation::CallListeners (
 void EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent& rEvent)
 {
     ListenerList aCopyListeners( maListeners );
-    for (auto& rListener : aCopyListeners)
+    for (const auto& rListener : aCopyListeners)
     {
         rListener.Call(rEvent);
     }
diff --git a/sd/source/ui/view/ToolBarManager.cxx b/sd/source/ui/view/ToolBarManager.cxx
index 5010323ee51f..e24ff1b12447 100644
--- a/sd/source/ui/view/ToolBarManager.cxx
+++ b/sd/source/ui/view/ToolBarManager.cxx
@@ -692,7 +692,7 @@ void ToolBarManager::Implementation::PreUpdate()
     maToolBarList.GetToolBarsToDeactivate(aToolBars);
 
     // Turn off the tool bars.
-    for (auto& aToolBar : aToolBars)
+    for (const auto& aToolBar : aToolBars)
     {
         OUString sFullName (GetToolBarResourceName(aToolBar));
         SAL_INFO("sd.view", OSL_THIS_FUNC << ":    turning off tool bar " << sFullName);
@@ -721,7 +721,7 @@ void ToolBarManager::Implementation::PostUpdate()
     SAL_INFO("sd.view", OSL_THIS_FUNC << ": ToolBarManager::PostUpdate [");
 
     // Turn on the tool bars that are visible in the new context.
-    for (auto& aToolBar : aToolBars)
+    for (const auto& aToolBar : aToolBars)
     {
         OUString sFullName (GetToolBarResourceName(aToolBar));
         SAL_INFO("sd.view", OSL_THIS_FUNC << ":    turning on tool bar " << sFullName);
@@ -1262,7 +1262,7 @@ void ToolBarList::GetToolBarsToActivate (std::vector<OUString>& rToolBars) const
     std::vector<OUString> aRequestedToolBars;
     MakeRequestedToolBarList(aRequestedToolBars);
 
-    for (auto& aToolBar : aRequestedToolBars)
+    for (const auto& aToolBar : aRequestedToolBars)
     {
         if (::std::find(maActiveToolBars.begin(),maActiveToolBars.end(),aToolBar)
             == maActiveToolBars.end())
diff --git a/sd/source/ui/view/ViewTabBar.cxx b/sd/source/ui/view/ViewTabBar.cxx
index d9663930a1da..969a59aa689d 100644
--- a/sd/source/ui/view/ViewTabBar.cxx
+++ b/sd/source/ui/view/ViewTabBar.cxx
@@ -466,7 +466,7 @@ bool ViewTabBar::HasTabBarButton (
 {
     bool bResult (false);
 
-    for (css::drawing::framework::TabBarButton & r : maTabBarButtons)
+    for (const css::drawing::framework::TabBarButton & r : maTabBarButtons)
     {
         if (IsEqual(r, rButton))
         {
diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx
index bf452204c092..14eaef7bdd91 100644
--- a/sd/source/ui/view/sdview3.cxx
+++ b/sd/source/ui/view/sdview3.cxx
@@ -107,7 +107,7 @@ struct ImpRememberOrigAndClone
 
 static SdrObject* ImpGetClone(std::vector<ImpRememberOrigAndClone>& aConnectorContainer, SdrObject const * pConnObj)
 {
-    for(ImpRememberOrigAndClone& rImp : aConnectorContainer)
+    for(const ImpRememberOrigAndClone& rImp : aConnectorContainer)
     {
         if(pConnObj == rImp.pOrig)
             return rImp.pClone;