summaryrefslogtreecommitdiff
path: root/Library_merged.mk
diff options
context:
space:
mode:
authorMichael Stahl <michael.stahl@allotropia.de>2023-12-14 17:45:43 +0100
committerMichael Stahl <michael.stahl@allotropia.de>2023-12-15 10:52:04 +0100
commit4eebf31e38969335471de884c7fd2db7c0e79454 (patch)
tree96691333b0116f87a713c67567da99e0bfcc8f4f /Library_merged.mk
parent53c64cce13863861aabc4b1056cc3a1a66bf64a7 (diff)
xmlsecurity: remove "AdES-compliant signature" checkbox
This is essentially a footgun because the user can accidentally turn it off and get non-AdES signatures which use obsolete SHA1 hashes. Unfortunately it turns out that the initial setting of the checkbox only works for ODF, because OOXML have m_sODFVersion set to "1.0" due to some defaulting code somewhere. So what this checkbox actually did is unintentionally disable XAdES signatures for OOXML by default. Now that i actually test it by setting ODF version 1.1 in Tools->Options, it turns out that signing ODF 1.1 documents isn't possible at all, a dialog pops up that says "Signing documents requires ODF 1.2 (OpenOffice.org 3.x)". Change-Id: I0eaf590c290b2c0ee0ff890ed73f0dbea4cf0ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160785 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'Library_merged.mk')
0 files changed, 0 insertions, 0 deletions