diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-04-24 11:50:04 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-04-24 15:45:22 +0200 |
| commit | e0097fea5a761747c1c1ce19a0873d7a760c4c37 (patch) | |
| tree | 032417cc266671f1a630f1db9b16f4a93eafd707 /UnoControls | |
| parent | f747797772e39d77a664845bdd66378524829ea3 (diff) | |
loplugin:checkunusedparams in i18nlangtag and l10ntools
Change-Id: If7c7404b1cc1cf9445a2af8106f7326b76524388
Reviewed-on: https://gerrit.libreoffice.org/36883
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'UnoControls')
| -rw-r--r-- | UnoControls/source/controls/progressmonitor.cxx | 17 | ||||
| -rw-r--r-- | UnoControls/source/inc/progressmonitor.hxx | 4 |
2 files changed, 8 insertions, 13 deletions
diff --git a/UnoControls/source/controls/progressmonitor.cxx b/UnoControls/source/controls/progressmonitor.cxx index 1eda7f784fbf..3354e60131c1 100644 --- a/UnoControls/source/controls/progressmonitor.cxx +++ b/UnoControls/source/controls/progressmonitor.cxx @@ -205,8 +205,8 @@ void SAL_CALL ProgressMonitor::addText( { // Safe impossible cases // Check valid call of this method. - DBG_ASSERT ( impl_debug_checkParameter ( rTopic, rText, bbeforeProgress ) , "ProgressMonitor::addText()\nCall without valid parameters!\n"); - DBG_ASSERT ( !(impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr ) , "ProgressMonitor::addText()\nThe text already exist.\n" ); + DBG_ASSERT ( impl_debug_checkParameter ( rTopic, rText ), "ProgressMonitor::addText()\nCall without valid parameters!\n"); + DBG_ASSERT ( !(impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr ), "ProgressMonitor::addText()\nThe text already exist.\n" ); // Do nothing (in Release), if topic already exist. if ( impl_searchTopic ( rTopic, bbeforeProgress ) != nullptr ) @@ -244,7 +244,7 @@ void SAL_CALL ProgressMonitor::removeText ( const OUString& rTopic, sal_Bool bbe { // Safe impossible cases // Check valid call of this method. - DBG_ASSERT ( impl_debug_checkParameter ( rTopic, bbeforeProgress ), "ProgressMonitor::removeText()\nCall without valid parameters!\n" ); + DBG_ASSERT ( impl_debug_checkParameter ( rTopic ), "ProgressMonitor::removeText()\nCall without valid parameters!\n" ); // Search the topic ... IMPL_TextlistItem* pSearchItem = impl_searchTopic ( rTopic, bbeforeProgress ); @@ -287,7 +287,7 @@ void SAL_CALL ProgressMonitor::updateText ( { // Safe impossible cases // Check valid call of this method. - DBG_ASSERT ( impl_debug_checkParameter ( rTopic, rText, bbeforeProgress ), "ProgressMonitor::updateText()\nCall without valid parameters!\n" ); + DBG_ASSERT ( impl_debug_checkParameter ( rTopic, rText ), "ProgressMonitor::updateText()\nCall without valid parameters!\n" ); // Search topic ... IMPL_TextlistItem* pSearchItem = impl_searchTopic ( rTopic, bbeforeProgress ); @@ -863,26 +863,21 @@ IMPL_TextlistItem* ProgressMonitor::impl_searchTopic ( const OUString& rTopic, b // addText, updateText bool ProgressMonitor::impl_debug_checkParameter ( const OUString& rTopic, - const OUString& rText, - bool /*bbeforeProgress*/ + const OUString& rText ) { if ( rTopic.isEmpty() ) return false; // "" if ( rText.isEmpty() ) return false; // "" - // "bbeforeProgress" is valid in everyway! - // Parameter OK ... return true. return true; } // removeText -bool ProgressMonitor::impl_debug_checkParameter ( const OUString& rTopic, bool /*bbeforeProgress*/ ) +bool ProgressMonitor::impl_debug_checkParameter ( const OUString& rTopic ) { if ( rTopic.isEmpty() ) return false; // "" - // "bbeforeProgress" is valid in everyway! - // Parameter OK ... return true. return true; } diff --git a/UnoControls/source/inc/progressmonitor.hxx b/UnoControls/source/inc/progressmonitor.hxx index 027a8d3fdc9e..a5a364534dbf 100644 --- a/UnoControls/source/inc/progressmonitor.hxx +++ b/UnoControls/source/inc/progressmonitor.hxx @@ -278,8 +278,8 @@ private: private: - static bool impl_debug_checkParameter( const OUString& sTopic, const OUString& sText, bool bbeforeProgress ); // addText, updateText - static bool impl_debug_checkParameter( const OUString& rTopic, bool bbeforeProgress ); // removeText + static bool impl_debug_checkParameter( const OUString& sTopic, const OUString& sText ); // addText, updateText + static bool impl_debug_checkParameter( const OUString& rTopic ); // removeText // private variables |