diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-19 10:26:30 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-19 12:53:42 +0200 |
| commit | 3d8400a8d938be7b116298d6a79bb49d7cc0cc99 (patch) | |
| tree | c1ae099e540025c1dfa7e6d62f6f6d9e5ce90c12 /accessibility | |
| parent | 2e51afc77c0800dda6c09bb645d8962ae125b2ba (diff) | |
loplugin:comparisonwithconstant in accessibility..basegfx
re-running this plugin on these modules now that sberg has improved
the plugin.
Change-Id: I1818b1fa540cf62b81219a4f3ed2dcae8ff0e838
Reviewed-on: https://gerrit.libreoffice.org/37805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'accessibility')
4 files changed, 5 insertions, 5 deletions
diff --git a/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx b/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx index ea8f6694d290..835bd62d6365 100644 --- a/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx +++ b/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx @@ -75,7 +75,7 @@ namespace accessibility sal_Int32 _nOffset ) :AccessibleBrowseBoxCell( _rxParent, _rBrowseBox, _xFocusWindow, _nRowPos, _nColPos ) { - m_nOffset = ( OFFSET_DEFAULT == _nOffset ) ? (sal_Int32)BBINDEX_FIRSTCONTROL : _nOffset; + m_nOffset = ( _nOffset == OFFSET_DEFAULT ) ? (sal_Int32)BBINDEX_FIRSTCONTROL : _nOffset; sal_Int32 nIndex = getIndex_Impl( _nRowPos, _nColPos, _rBrowseBox.GetColumnCount() ); setAccessibleName( _rBrowseBox.GetAccessibleObjectName( BBTYPE_TABLECELL, nIndex ) ); setAccessibleDescription( _rBrowseBox.GetAccessibleObjectDescription( BBTYPE_TABLECELL, nIndex ) ); diff --git a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx index 6be99bec6c93..94816740b8cb 100644 --- a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx +++ b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx @@ -92,7 +92,7 @@ namespace accessibility if ( _rSource.Source == m_xParent ) { dispose(); - OSL_ENSURE( !m_xParent.is() && ( nullptr == m_pIconCtrl ), "" ); + OSL_ENSURE( !m_xParent.is() && ( m_pIconCtrl == nullptr ), "" ); } } diff --git a/accessibility/source/standard/vclxaccessibletabpagewindow.cxx b/accessibility/source/standard/vclxaccessibletabpagewindow.cxx index c8edcab404f8..0b8c2c5f7390 100644 --- a/accessibility/source/standard/vclxaccessibletabpagewindow.cxx +++ b/accessibility/source/standard/vclxaccessibletabpagewindow.cxx @@ -114,9 +114,9 @@ Reference< XAccessible > VCLXAccessibleTabPageWindow::getAccessibleParent( ) if ( xCont.is() ) { sal_uInt16 const nPagePos(m_pTabControl->GetPagePos(m_nPageId)); - SAL_WARN_IF(TAB_PAGE_NOTFOUND == nPagePos, "accessibility", + SAL_WARN_IF(nPagePos == TAB_PAGE_NOTFOUND, "accessibility", "getAccessibleParent(): no tab page"); - if (TAB_PAGE_NOTFOUND != nPagePos) + if (nPagePos != TAB_PAGE_NOTFOUND) { xParent = xCont->getAccessibleChild(nPagePos); } diff --git a/accessibility/source/standard/vclxaccessibletoolbox.cxx b/accessibility/source/standard/vclxaccessibletoolbox.cxx index d00778116f19..113391b8bf39 100644 --- a/accessibility/source/standard/vclxaccessibletoolbox.cxx +++ b/accessibility/source/standard/vclxaccessibletoolbox.cxx @@ -140,7 +140,7 @@ namespace if ( _ppImplementation ) *_ppImplementation = pImplementation; - return nullptr != pImplementation; + return pImplementation != nullptr; } Sequence< sal_Int8 > OToolBoxWindowItem::getUnoTunnelImplementationId() |