diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-04-03 14:10:24 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-04-20 10:11:53 +0000 |
| commit | 6a4620ec244b41b32fe339af303e1c72c49c681d (patch) | |
| tree | 17208b700640e9f8433912a9c3030adf54c30784 /accessibility | |
| parent | 255884bd221d0521f5c99add4b9af8723668c300 (diff) | |
Related: tdf#82998 don't emit an Indeterminate state change for boxes
Emitting object:state-changed:indeterminate is appropriate for things like
tri-state checkboxes when the state is neither fully checked nor fully
unchecked. ... jdiggs think that this event doesn't make sense in this instance
for any platform's accessibility API
Change-Id: Id8288522a825ad7ff61524ad4f225a79c015bb8f
(cherry picked from commit ccaeafab704b46ed8ca8c4aad3c14f6143bfc141)
Reviewed-on: https://gerrit.libreoffice.org/15386
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'accessibility')
| -rw-r--r-- | accessibility/source/standard/vclxaccessiblebox.cxx | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/accessibility/source/standard/vclxaccessiblebox.cxx b/accessibility/source/standard/vclxaccessiblebox.cxx index 295bbe41153d..c75e8b431a70 100644 --- a/accessibility/source/standard/vclxaccessiblebox.cxx +++ b/accessibility/source/standard/vclxaccessiblebox.cxx @@ -113,9 +113,8 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven case VCLEVENT_DROPDOWN_SELECT: case VCLEVENT_LISTBOX_SELECT: case VCLEVENT_LISTBOX_FOCUSITEMCHANGED: - { - // Forward the call to the list child. + // Forward the call to the list child. VCLXAccessibleList* pList = static_cast<VCLXAccessibleList*>(m_xList.get()); if ( pList == NULL ) { @@ -125,14 +124,9 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven if ( pList != NULL ) { pList->ProcessWindowEvent (rVclWindowEvent, m_bIsDropDownBox); - if(m_bIsDropDownBox) + if (m_bIsDropDownBox) { NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any()); - Any aOldValue; - Any aNewValue; - aOldValue <<= AccessibleStateType::INDETERMINATE; - NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOldValue, aNewValue); - } } break; @@ -187,12 +181,6 @@ void VCLXAccessibleBox::ProcessWindowEvent (const VclWindowEvent& rVclWindowEven pList->UpdateSelection_Acc(sText, m_bIsDropDownBox); if (m_bIsDropDownBox || ( !m_bIsDropDownBox && m_aBoxType==COMBOBOX)) NotifyAccessibleEvent(AccessibleEventId::VALUE_CHANGED, Any(), Any()); - - Any aOldValue; - Any aNewValue; - aOldValue <<= AccessibleStateType::INDETERMINATE; - NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOldValue, aNewValue); - } } break; |