diff options
author | Michael Weghorn <m.weghorn@posteo.de> | 2023-11-08 15:31:38 +0100 |
---|---|---|
committer | Michael Weghorn <m.weghorn@posteo.de> | 2023-11-09 07:54:24 +0100 |
commit | 30a981cc2061b374361bbf8862ec3889b06acf88 (patch) | |
tree | 711e12e2e3ceed45efbf5ae62e67229c512f7164 /android | |
parent | d088e3cfc582beeabb26257f689c7e4e83e7e731 (diff) |
android: Drop unused LayerView#registerCxxCompositor
The comment saying it's called via JNI is not true
for LibreOffice Viewer, is probably from Gecko/Fennec
days like the ones for previously dropped methods.
Now that the method is gone, `mContext` no longer
needs to be static, so make it non-static and drop
the corresponding TODO comment.
Change-Id: I32db3728234715bc29af1ad757c715003c70ca4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159162
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'android')
-rw-r--r-- | android/source/src/java/org/mozilla/gecko/gfx/LayerView.java | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java b/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java index 5429d09cbb1d..7c2dda766d0a 100644 --- a/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java +++ b/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java @@ -53,8 +53,7 @@ public class LayerView extends FrameLayout { private Listener mListener; private OnInterceptTouchListener mTouchIntercepter; - //TODO static because of registerCxxCompositor() function, should be fixed in the future - private static LibreOfficeMainActivity mContext; + private LibreOfficeMainActivity mContext; public LayerView(Context context, AttributeSet attrs) { super(context, attrs); @@ -267,18 +266,6 @@ public class LayerView extends FrameLayout { return mSurfaceView.getHolder(); } - /** This function is invoked by Gecko (compositor thread) via JNI; be careful when modifying signature. */ - public static GLController registerCxxCompositor() { - try { - LayerView layerView = mContext.getLayerClient().getView(); - layerView.mListener.compositorCreated(); - return layerView.getGLController(); - } catch (Exception e) { - Log.e(LOGTAG, "Error registering compositor!", e); - return null; - } - } - public interface Listener { void compositorCreated(); void renderRequested(); |