android: Update Android Gradle Plugin to 8.3.2

... as suggested by Android Studio.

Also update the Lint baseline file, as the build would
otherwise fail due to this new warning:

> Task :lintReportStrippedUIEditingDebug
Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html

> Task :lintStrippedUIEditingDebug FAILED
/home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 213 errors and 1 warning were filtered out because they are listed in the baseline file, lint-baseline.xml
[LintBaseline]
/home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 6 errors/warnings were listed in the baseline file (lint-baseline.xml) but not found in the project; perhaps they have been fixed? Another possible explanation is that lint recently stopped analyzing (and including results from) dependent projects by default. You can turn this back on with android.lintOptions.checkDependencies=true. Unmatched issue types: PrivateResource, RedundantNamespace, TypographyEllipsis (3), UnusedNamespace [LintBaseline]
/home/michi/development/git/libreoffice-WORKTREE-android/android/source/AndroidManifest.xml:109: Error: Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed. [DiscouragedApi]
android:screenOrientation="landscape" >
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Explanation for issues of type "DiscouragedApi":
Discouraged APIs are allowed and are not deprecated, but they may be unfit
for common use (e.g. due to slow performance or subtle behavior).

1 errors, 0 warnings (213 errors, 1 warning filtered by baseline lint-baseline.xml)

FAILURE: Build failed with an exception.

Change-Id: I621b2334fef954bcd341cdde9034187f455339e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166114
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2 files changed, 13 insertions, 68 deletions

diff --git a/android/source/build.gradle b/android/source/build.gradle
index 090d73f49bfb..8cbef7744d8e 100644
--- a/android/source/build.gradle
+++ b/android/source/build.gradle
@@ -21,7 +21,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.2.1'
+        classpath 'com.android.tools.build:gradle:8.3.2'
     }
 }
 
diff --git a/android/source/lint-baseline.xml b/android/source/lint-baseline.xml
index 24e6447295e3..01fdd6f8d234 100644
--- a/android/source/lint-baseline.xml
+++ b/android/source/lint-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 8.2.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.0)" variant="all" version="8.2.0">
+<issues format="6" by="lint 8.3.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.3.2)" variant="all" version="8.3.2">
 
     <issue
         id="ScopedStorage"
@@ -156,17 +156,6 @@
     </issue>
 
     <issue
-        id="PrivateResource"
-        message="The resource `@drawable/ic_keyboard_black_24dp` is marked as private in com.google.android.material:material:1.10.0"
-        errorLine1="    android:src=&quot;@drawable/ic_keyboard_black_24dp&quot;"
-        errorLine2="                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="res/drawable-hdpi/ic_keyboard.xml"
-            line="4"
-            column="18"/>
-    </issue>
-
-    <issue
         id="SpUsage"
         message="Should use &quot;`sp`&quot; instead of &quot;`dp`&quot; for text sizes"
         errorLine1="                    android:textSize=&quot;14dp&quot;"
@@ -179,6 +168,17 @@
 
     <issue
         id="DiscouragedApi"
+        message="Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed."
+        errorLine1="            android:screenOrientation=&quot;landscape&quot; >"
+        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="AndroidManifest.xml"
+            line="109"
+            column="13"/>
+    </issue>
+
+    <issue
+        id="DiscouragedApi"
         message="Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. `R.foo.bar`) than by name (e.g. `getIdentifier(&quot;bar&quot;, &quot;foo&quot;, null)`)."
         errorLine1="        int resourceID = resources.getIdentifier(name, &quot;drawable&quot;, packageName);"
         errorLine2="                                   ~~~~~~~~~~~~~">
@@ -1214,17 +1214,6 @@
     </issue>
 
     <issue
-        id="RedundantNamespace"
-        message="This namespace declaration is redundant"
-        errorLine1="&lt;LinearLayout xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
-        errorLine2="              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="res/layout/about.xml"
-            line="6"
-            column="15"/>
-    </issue>
-
-    <issue
         id="TooDeepLayout"
         message="`toolbar_bottom.xml` has more than 10 levels, bad for performance"
         errorLine1="                                    &lt;ImageButton"
@@ -1236,50 +1225,6 @@
     </issue>
 
     <issue
-        id="UnusedNamespace"
-        message="Unused namespace declaration xmlns:android; already declared on the root element"
-        errorLine1="&lt;LinearLayout xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
-        errorLine2="              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="res/layout/about.xml"
-            line="6"
-            column="15"/>
-    </issue>
-
-    <issue
-        id="TypographyEllipsis"
-        message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
-        errorLine1="    &lt;string name=&quot;action_save_as&quot;>Պահել որպես...&lt;/string>"
-        errorLine2="                                  ~~~~~~~~~~~~~~">
-        <location
-            file="res/values-hy/strings.xml"
-            line="36"
-            column="35"/>
-    </issue>
-
-    <issue
-        id="TypographyEllipsis"
-        message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
-        errorLine1="    &lt;string name=&quot;action_save_as&quot;>Cadw Fel...&lt;/string>"
-        errorLine2="                                  ~~~~~~~~~~~">
-        <location
-            file="res/values-cy/strings.xml"
-            line="40"
-            column="35"/>
-    </issue>
-
-    <issue
-        id="TypographyEllipsis"
-        message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
-        errorLine1="    &lt;string name=&quot;action_save_as&quot;>Gardar como...&lt;/string>"
-        errorLine2="                                  ~~~~~~~~~~~~~~">
-        <location
-            file="res/values-gl/strings.xml"
-            line="42"
-            column="35"/>
-    </issue>
-
-    <issue
         id="IconLocation"
         message="Found bitmap drawable `res/drawable/calc.png` in densityless folder">
         <location