diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2016-08-19 09:31:35 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-08-19 11:25:18 +0000 |
| commit | 396138a6bc7192abe0837b419283860d3331f607 (patch) | |
| tree | f80818ba86220abb8db205b402429e3d45aa62d1 /avmedia/source | |
| parent | 8b4705e0e0c76503b1ca61cb567d222f49466fc5 (diff) | |
Resolves: coverity#705366 Mixing enum types
and
coverity#705367 Mixing enum types
coverity#705371 Mixing enum types
coverity#982694 Mixing enum types
coverity#1027717 Mixing enum types
coverity#1371228 Mixing enum types
coverity#1371242 Mixing enum types
coverity#1371280 Mixing enum types
coverity#1371310 Mixing enum types
MapUnit and SfxMapUnit share the same values and
are freely cast from one to the other.
Now that
commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527
Date: Thu Aug 11 15:02:19 2016 +0200
loplugin:unusedenumconstants in package..svtools
removed the SfxMapUnit entries that were directly unused, they
don't match anymore and casting from one to the other is dangerous.
Why there was two of these anyway escapes me, get rid of SfxMapUnit
and just use MapUnit universally
Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e
Reviewed-on: https://gerrit.libreoffice.org/28234
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'avmedia/source')
| -rw-r--r-- | avmedia/source/framework/mediaitem.cxx | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/avmedia/source/framework/mediaitem.cxx b/avmedia/source/framework/mediaitem.cxx index ed413f23a363..5a6a92ccb63b 100644 --- a/avmedia/source/framework/mediaitem.cxx +++ b/avmedia/source/framework/mediaitem.cxx @@ -125,24 +125,21 @@ bool MediaItem::operator==( const SfxPoolItem& rItem ) const && m_pImpl->m_eZoom == rOther.m_pImpl->m_eZoom; } - SfxPoolItem* MediaItem::Clone( SfxItemPool* ) const { return new MediaItem( *this ); } - bool MediaItem::GetPresentation( SfxItemPresentation, - SfxMapUnit, - SfxMapUnit, - OUString& rText, - const IntlWrapper * ) const + MapUnit, + MapUnit, + OUString& rText, + const IntlWrapper * ) const { rText.clear(); return false; } - bool MediaItem::QueryValue( css::uno::Any& rVal, sal_uInt8 ) const { uno::Sequence< uno::Any > aSeq( 10 ); |