diff options
| author | Matteo Casalin <matteo.casalin@yahoo.com> | 2018-11-27 22:51:25 +0100 |
|---|---|---|
| committer | Matteo Casalin <matteo.casalin@yahoo.com> | 2018-12-28 16:48:20 +0100 |
| commit | a33c2a1ad09f834207b15e664e5b30a21c50b3ab (patch) | |
| tree | 1eb6dfbe4e193d9d86de89c02ada273b0e8b5945 /avmedia | |
| parent | 854b6a5f00d86b55ca8c0cb7f83940e84e65d27c (diff) | |
Return early
Change-Id: I96774c66d2a14b9be2d8e400be928c3c0073411f
Reviewed-on: https://gerrit.libreoffice.org/65663
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
Diffstat (limited to 'avmedia')
| -rw-r--r-- | avmedia/source/viewer/mediawindow.cxx | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/avmedia/source/viewer/mediawindow.cxx b/avmedia/source/viewer/mediawindow.cxx index d778c72e7c31..f1ef17a4b664 100644 --- a/avmedia/source/viewer/mediawindow.cxx +++ b/avmedia/source/viewer/mediawindow.cxx @@ -306,7 +306,6 @@ void MediaWindow::executeFormatErrorBox(weld::Window* pParent) bool MediaWindow::isMediaURL( const OUString& rURL, const OUString& rReferer, bool bDeep, Size* pPreferredSizePixel ) { const INetURLObject aURL( rURL ); - bool bRet = false; if( aURL.GetProtocol() != INetProtocol::NotValid ) { @@ -320,8 +319,6 @@ bool MediaWindow::isMediaURL( const OUString& rURL, const OUString& rReferer, bo if( xPlayer.is() ) { - bRet = true; - if( pPreferredSizePixel ) { const awt::Size aAwtSize( xPlayer->getPreferredPlayerWindowSize() ); @@ -329,6 +326,8 @@ bool MediaWindow::isMediaURL( const OUString& rURL, const OUString& rReferer, bo pPreferredSizePixel->setWidth( aAwtSize.Width ); pPreferredSizePixel->setHeight( aAwtSize.Height ); } + + return true; } } catch( ... ) @@ -342,18 +341,18 @@ bool MediaWindow::isMediaURL( const OUString& rURL, const OUString& rReferer, bo getMediaFilters( aFilters ); - for( FilterNameVector::size_type i = 0; ( i < aFilters.size() ) && !bRet; ++i ) + for( FilterNameVector::size_type i = 0; i < aFilters.size(); ++i ) { - for( sal_Int32 nIndex = 0; nIndex >= 0 && !bRet; ) + for( sal_Int32 nIndex = 0; nIndex >= 0; ) { if( aExt.equalsIgnoreAsciiCase( aFilters[ i ].second.getToken( 0, ';', nIndex ) ) ) - bRet = true; + return true; } } } } - return bRet; + return false; } |