diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:36:33 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 08:39:10 +0200 |
| commit | 44688e498c9672f0a1759ead394f6d6e0f0ef5fd (patch) | |
| tree | f2f1b33f882ced5c23c2854177c9b266c907ac56 /basctl/source/basicide/basides1.cxx | |
| parent | b0c6d587405af9e2263dc5073a9a965db46ff986 (diff) | |
clang-tidy performance-unnecessary-copy-initialization in
basctl..basic
Change-Id: I4009282869cd8a2f269093564bd4fafccab80ec3
Reviewed-on: https://gerrit.libreoffice.org/62212
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basctl/source/basicide/basides1.cxx')
| -rw-r--r-- | basctl/source/basicide/basides1.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx index 007269ec71ad..1159777d9037 100644 --- a/basctl/source/basicide/basides1.cxx +++ b/basctl/source/basicide/basides1.cxx @@ -416,7 +416,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq ) bool bRenameOk = false; if (ModulWindow* pModWin = dynamic_cast<ModulWindow*>(pWin.get())) { - OUString aLibName = pModWin->GetLibName(); + const OUString& aLibName = pModWin->GetLibName(); ScriptDocument aDocument( pWin->GetDocument() ); if (RenameModule(pModWin->GetFrameWeld(), aDocument, aLibName, aOldName, aNewName)) @@ -625,7 +625,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq ) const SfxStringItem* pDocumentItem = rReq.GetArg<SfxStringItem>(SID_BASICIDE_ARG_DOCUMENT); if ( pDocumentItem ) { - OUString sDocumentCaption = pDocumentItem->GetValue(); + const OUString& sDocumentCaption = pDocumentItem->GetValue(); if ( !sDocumentCaption.isEmpty() ) pDocument.reset( new ScriptDocument( ScriptDocument::getDocumentWithURLOrCaption( sDocumentCaption ) ) ); } @@ -651,7 +651,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq ) const SfxStringItem* pNameItem = rReq.GetArg<SfxStringItem>(SID_BASICIDE_ARG_NAME); if ( pNameItem ) { - OUString aName( pNameItem->GetValue() ); + const OUString& aName( pNameItem->GetValue() ); OUString aModType( "Module" ); OUString aType( aModType ); const SfxStringItem* pTypeItem = rReq.GetArg<SfxStringItem>(SID_BASICIDE_ARG_TYPE); @@ -1297,7 +1297,7 @@ VclPtr<ModulWindow> Shell::ShowActiveModuleWindow( StarBASIC const * pBasic ) if (BasicManager* pBasMgr = FindBasicManager(pLib)) { ScriptDocument aDocument( ScriptDocument::getDocumentForBasicManager( pBasMgr ) ); - OUString aLibName = pLib->GetName(); + const OUString& aLibName = pLib->GetName(); pWin = FindBasWin( aDocument, aLibName, pActiveModule->GetName(), true ); DBG_ASSERT( pWin, "Error/Step-Hdl: Window was not created/found!" ); SetCurLib( aDocument, aLibName ); |