convert SFX_HINT to scoped enum

Notes

(*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a
dynamic_cast check.

(*) In SC, removed the hint id field from ScIndexHint, no point in
storing the hint id twice

(*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no
point in storing two different hint ids

(*) In some cases, multiple #define's used to map to the same SFX_HINT
value (notably the SFX_HINT_USER* values). I made all of those separate
values.

Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5
Reviewed-on: https://gerrit.libreoffice.org/31751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 8 insertions, 12 deletions

diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx
index 762b90b43b0a..90e093ae885e 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -475,21 +475,17 @@ void Shell::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
 {
     if (GetShell())
     {
-        switch (rHint.GetId())
+        if (rHint.GetId() == SfxHintId::Dying)
         {
-            case SFX_HINT_DYING:
-                {
-                    EndListening( rBC, true /* log off all */ );
-                    aObjectCatalog->UpdateEntries();
-                }
-            break;
+            EndListening( rBC, true /* log off all */ );
+            aObjectCatalog->UpdateEntries();
         }
 
         if (SbxHint const* pSbxHint = dynamic_cast<SbxHint const*>(&rHint))
         {
-            const sal_uInt32 nHintId = pSbxHint->GetId();
-            if (    ( nHintId == SBX_HINT_BASICSTART ) ||
-                    ( nHintId == SBX_HINT_BASICSTOP ) )
+            const SfxHintId nHintId = pSbxHint->GetId();
+            if (    ( nHintId == SfxHintId::BasicStart ) ||
+                    ( nHintId == SfxHintId::BasicStop ) )
             {
                 if (SfxBindings* pBindings = GetBindingsPtr())
                 {
@@ -515,7 +511,7 @@ void Shell::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
                     pBindings->Update( SID_BASICLOAD );
                 }
 
-                if ( nHintId == SBX_HINT_BASICSTOP )
+                if ( nHintId == SfxHintId::BasicStop )
                 {
                     // not only at error/break or explicit stoppage,
                     // if the update is turned off due to a programming bug
@@ -533,7 +529,7 @@ void Shell::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
                 for (WindowTableIt it = aWindowTable.begin(); it != aWindowTable.end(); ++it)
                 {
                     BaseWindow* pWin = it->second;
-                    if ( nHintId == SBX_HINT_BASICSTART )
+                    if ( nHintId == SfxHintId::BasicStart )
                         pWin->BasicStarted();
                     else
                         pWin->BasicStopped();