diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-10 12:53:02 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-11 06:55:41 +0000 |
| commit | 78b4a1fb01af9ad3b3395a22f6e396be914b553e (patch) | |
| tree | 846fdaea907a70fdc274a1e76642ed5e06622c0d /basctl/source/basicide/basobj3.cxx | |
| parent | 071e23fee07b92b8f07800cda3ca7e66afe818ae (diff) | |
update vclwidget loplugin to find ref-dropping assigment
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.
Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basctl/source/basicide/basobj3.cxx')
| -rw-r--r-- | basctl/source/basicide/basobj3.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx index d406120b1d39..f3cdc49b6a70 100644 --- a/basctl/source/basicide/basobj3.cxx +++ b/basctl/source/basicide/basobj3.cxx @@ -158,7 +158,7 @@ bool RenameDialog ( } Shell* pShell = GetShell(); - DialogWindow* pWin = pShell ? pShell->FindDlgWin(rDocument, rLibName, rOldName) : nullptr; + VclPtr<DialogWindow> pWin = pShell ? pShell->FindDlgWin(rDocument, rLibName, rOldName) : nullptr; Reference< XNameContainer > xExistingDialog; if ( pWin ) xExistingDialog = pWin->GetEditor().GetDialog(); @@ -195,7 +195,7 @@ bool RemoveDialog( const ScriptDocument& rDocument, const OUString& rLibName, co { if (Shell* pShell = GetShell()) { - if (DialogWindow* pDlgWin = pShell->FindDlgWin(rDocument, rLibName, rDlgName)) + if (VclPtr<DialogWindow> pDlgWin = pShell->FindDlgWin(rDocument, rLibName, rDlgName)) { Reference< container::XNameContainer > xDialogModel = pDlgWin->GetDialog(); LocalizationMgr::removeResourceForDialog( rDocument, rLibName, rDlgName, xDialogModel ); |