Basic IDE: namespace basctl

Now all names in basctl are in namespace 'basctl'.
There were lots of names that included the word 'Basic' or 'BasicIDE' in
it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox,
BasicIDEModule, IDEBaseWindow etc. This information is now stored in the
namespace name, so the names could be shortened: basctl::DocumentEntry,
basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc.
Some other minor changes:
* LibInfos, LibInfoItem, LibInfoKey ->
LibInfos, LibInfos::Item, LibInfos::Key
* The header guards are now uniformly BASCTL_FILENAME_HXX, instead of
e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'.
* namespace BasicIDE, BasicIDEGlobals, basicide -> namespace basctl
* BASICIDE_TYPE_MODULE, ... -> basctl::TYPE_MODULE, ...

Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b
Reviewed-on: https://gerrit.libreoffice.org/501
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>

1 files changed, 31 insertions, 50 deletions

diff --git a/basctl/source/basicide/sbxitem.cxx b/basctl/source/basicide/sbxitem.cxx
index ab75ee8ad34b..a53b1b28323a 100644
--- a/basctl/source/basicide/sbxitem.cxx
+++ b/basctl/source/basicide/sbxitem.cxx
@@ -19,34 +19,38 @@
 
 #include "sbxitem.hxx"
 
-SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument& rDocument, const ::rtl::OUString& aLibName, const ::rtl::OUString& aName, BasicIDEType nType)
-    :SfxPoolItem( nWhich_ )
-    ,m_aDocument(rDocument)
-    ,m_aLibName(aLibName)
-    ,m_aName(aName)
-    ,m_nType(nType)
+namespace basctl
 {
-}
 
-SbxItem::SbxItem(sal_uInt16 nWhich_, const ScriptDocument& rDocument, const ::rtl::OUString& aLibName, const ::rtl::OUString& aName, const ::rtl::OUString& aMethodName, BasicIDEType nType)
-    :SfxPoolItem( nWhich_ )
-    ,m_aDocument(rDocument)
-    ,m_aLibName(aLibName)
-    ,m_aName(aName)
-    ,m_aMethodName(aMethodName)
-    ,m_nType(nType)
-{
-}
+SbxItem::SbxItem (
+    sal_uInt16 nWhichItem,
+    ScriptDocument const& rDocument,
+    rtl::OUString const& aLibName,
+    rtl::OUString const& aName,
+    ItemType eType
+) :
+    SfxPoolItem(nWhichItem),
+    m_aDocument(rDocument),
+    m_aLibName(aLibName),
+    m_aName(aName),
+    m_eType(eType)
+{ }
 
-SbxItem::SbxItem(const SbxItem& rCopy)
-    :SfxPoolItem(rCopy)
-    ,m_aDocument(rCopy.m_aDocument)
-    ,m_aLibName(rCopy.m_aLibName)
-    ,m_aName(rCopy.m_aName)
-    ,m_aMethodName(rCopy.m_aMethodName)
-    ,m_nType(rCopy.m_nType)
-{
-}
+SbxItem::SbxItem (
+    sal_uInt16 nWhichItem,
+    ScriptDocument const& rDocument,
+    rtl::OUString const& aLibName,
+    rtl::OUString const& aName,
+    rtl::OUString const& aMethodName,
+    ItemType eType
+) :
+    SfxPoolItem(nWhichItem),
+    m_aDocument(rDocument),
+    m_aLibName(aLibName),
+    m_aName(aName),
+    m_aMethodName(aMethodName),
+    m_eType(eType)
+{ }
 
 SfxPoolItem *SbxItem::Clone(SfxItemPool*) const
 {
@@ -63,32 +67,9 @@ int SbxItem::operator==(const SfxPoolItem& rCmp) const
         m_aLibName == pSbxItem->m_aLibName &&
         m_aName == pSbxItem->m_aName &&
         m_aMethodName == pSbxItem->m_aMethodName &&
-        m_nType == pSbxItem->m_nType;
+        m_eType == pSbxItem->m_eType;
 }
 
-const ScriptDocument& SbxItem::GetDocument() const
-{
-    return m_aDocument;
-}
-
-const ::rtl::OUString& SbxItem::GetLibName() const
-{
-    return m_aLibName;
-}
-
-const ::rtl::OUString& SbxItem::GetName() const
-{
-    return m_aName;
-}
-
-const ::rtl::OUString& SbxItem::GetMethodName() const
-{
-    return m_aMethodName;
-}
-
-BasicIDEType SbxItem::GetType() const
-{
-    return m_nType;
-}
+} // namespace basctl
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */