Revert "loplugin:finalclasses"

This reverts commit 9ce9011230a97f3fe4fcd2f8d761781c4300772b.

Reason for revert: see comments in https://gerrit.libreoffice.org/c/core/+/124632

Change-Id: Ibc8b7a8c190e7a8afec793c1202dba97ac6909bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124483
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 12 insertions, 5 deletions

diff --git a/basctl/source/inc/baside3.hxx b/basctl/source/inc/baside3.hxx
index 3eef27cd2f63..f5d367182d0a 100644
--- a/basctl/source/inc/baside3.hxx
+++ b/basctl/source/inc/baside3.hxx
@@ -45,13 +45,15 @@ class ObjectCatalog;
 
 bool implImportDialog(weld::Window* pWin, const ScriptDocument& rDocument, const OUString& rLibName);
 
-class DialogWindow final : public BaseWindow
+class DialogWindow: public BaseWindow
 {
+private:
     DialogWindowLayout& m_rLayout;
     std::unique_ptr<DlgEditor> m_pEditor;
     std::unique_ptr<SfxUndoManager> m_pUndoMgr; // never nullptr
     sal_uInt16          m_nControlSlotId;
 
+protected:
     virtual void        Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRect) override;
     virtual void        Resize() override;
     virtual void        dispose() override;
@@ -112,32 +114,37 @@ public:
 
 // DialogWindowLayout
 
-class DialogWindowLayout final : public Layout
+class DialogWindowLayout : public Layout
 {
 public:
     DialogWindowLayout (vcl::Window* pParent, ObjectCatalog&);
     virtual ~DialogWindowLayout() override;
     virtual void dispose() override;
+public:
     void ShowPropertyBrowser ();
     void UpdatePropertyBrowser ();
     void DisablePropertyBrowser ();
+public:
     // Layout:
     virtual void Activating (BaseWindow&) override;
     virtual void Deactivating () override;
     virtual void ExecuteGlobal (SfxRequest&) override;
     virtual void GetState (SfxItemSet&, unsigned nWhich) override;
     virtual void UpdateDebug (bool) override {};
-
-private:
+protected:
     // Layout:
     virtual void OnFirstSize (tools::Long nWidth, tools::Long nHeight) override;
+
+private:
     // dockable windows:
     // object catalog (owned by Shell)
     ObjectCatalog& rObjectCatalog;
     // property browser (created by this, deleted by toolkit)
     VclPtr<PropBrw> pPropertyBrowser;
-    void AddPropertyBrowser ();
 
+private:
+    void AddPropertyBrowser ();
+private:
     friend class DialogWindow;
 };