loplugin:stringviewparam: operator +

Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

3 files changed, 23 insertions, 17 deletions

diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index d8fe56feb43c..f3127186ce93 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -29,6 +29,7 @@
 #include <vcl/scrbar.hxx>
 #include <map>
 #include <memory>
+#include <string_view>
 
 class SfxViewFactory;
 class SdrView;
@@ -197,7 +198,7 @@ public:
     static void CopyDialogResources(
         css::uno::Reference< css::io::XInputStreamProvider >& io_xISP,
         const ScriptDocument& rSourceDoc, const OUString& rSourceLibName, const ScriptDocument& rDestDoc,
-        const OUString& rDestLibName, const OUString& rDlgName );
+        const OUString& rDestLibName, std::u16string_view rDlgName );
 
     static void InvalidateControlSlots();
 
diff --git a/basctl/source/inc/bastypes.hxx b/basctl/source/inc/bastypes.hxx
index 21e6c0227a9c..fecebced52ee 100644
--- a/basctl/source/inc/bastypes.hxx
+++ b/basctl/source/inc/bastypes.hxx
@@ -26,6 +26,7 @@
 #include <vcl/dockwin.hxx>
 #include <vcl/weld.hxx>
 
+#include <string_view>
 #include <unordered_map>
 
 class SbModule;
@@ -288,14 +289,14 @@ private:
 };
 
 void            CutLines( OUString& rStr, sal_Int32 nStartLine, sal_Int32 nLines );
-OUString CreateMgrAndLibStr( const OUString& rMgrName, const OUString& rLibName );
+OUString CreateMgrAndLibStr( std::u16string_view rMgrName, std::u16string_view rLibName );
 sal_uInt32           CalcLineCount( SvStream& rStream );
 
-bool QueryReplaceMacro( const OUString& rName, weld::Widget* pParent );
-bool QueryDelMacro( const OUString& rName, weld::Widget* pParent );
-bool QueryDelDialog( const OUString& rName, weld::Widget* pParent );
-bool QueryDelModule( const OUString& rName, weld::Widget* pParent );
-bool QueryDelLib( const OUString& rName, bool bRef, weld::Widget* pParent );
+bool QueryReplaceMacro( std::u16string_view rName, weld::Widget* pParent );
+bool QueryDelMacro( std::u16string_view rName, weld::Widget* pParent );
+bool QueryDelDialog( std::u16string_view rName, weld::Widget* pParent );
+bool QueryDelModule( std::u16string_view rName, weld::Widget* pParent );
+bool QueryDelLib( std::u16string_view rName, bool bRef, weld::Widget* pParent );
 bool QueryPassword(weld::Widget* pDialogParent, const css::uno::Reference< css::script::XLibraryContainer >& xLibContainer, const OUString& rLibName, OUString& rPassword, bool bRepeat = false, bool bNewTitle = false);
 
 class ModuleInfoHelper
diff --git a/basctl/source/inc/localizationmgr.hxx b/basctl/source/inc/localizationmgr.hxx
index 4b72a7d8e58d..847ef0f75729 100644
--- a/basctl/source/inc/localizationmgr.hxx
+++ b/basctl/source/inc/localizationmgr.hxx
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include <sal/config.h>
+
+#include <string_view>
+
 #include "scriptdocument.hxx"
 
 #include <com/sun/star/resource/XStringResourceManager.hpp>
@@ -51,8 +55,8 @@ class LocalizationMgr
         COPY_RESOURCES
     };
     static sal_Int32 implHandleControlResourceProperties(const css::uno::Any& rControlAny,
-            const OUString& aDialogName,
-            const OUString& aCtrlName,
+            std::u16string_view aDialogName,
+            std::u16string_view aCtrlName,
             const css::uno::Reference< css::resource::XStringResourceManager >& xStringResourceManager,
             const css::uno::Reference< css::resource::XStringResourceResolver >& xSourceStringResolver,
             HandleResourceMode eMode );
@@ -95,21 +99,21 @@ public:
     void handleBasicStopped();
 
     static void setControlResourceIDsForNewEditorObject(DlgEditor const * pEditor,
-        const css::uno::Any& rControlAny, const OUString& aCtrlName);
+        const css::uno::Any& rControlAny, std::u16string_view aCtrlName);
 
     static void renameControlResourceIDsForEditorObject(DlgEditor const * pEditor,
-        const css::uno::Any& rControlAny, const OUString& aNewCtrlName);
+        const css::uno::Any& rControlAny, std::u16string_view aNewCtrlName);
 
     static void deleteControlResourceIDsForDeletedEditorObject(DlgEditor const * pEditor,
-        const css::uno::Any& rControlAny, const OUString& aCtrlName);
+        const css::uno::Any& rControlAny, std::u16string_view aCtrlName);
 
-    static void setStringResourceAtDialog( const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aDlgName,
+    static void setStringResourceAtDialog( const ScriptDocument& rDocument, const OUString& aLibName, std::u16string_view aDlgName,
         const css::uno::Reference< css::container::XNameContainer >& xDialogModel );
 
-    static void renameStringResourceIDs( const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aDlgName,
+    static void renameStringResourceIDs( const ScriptDocument& rDocument, const OUString& aLibName, std::u16string_view aDlgName,
         const css::uno::Reference< css::container::XNameContainer >& xDialogModel );
 
-    static void removeResourceForDialog( const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aDlgName,
+    static void removeResourceForDialog( const ScriptDocument& rDocument, const OUString& aLibName, std::u16string_view aDlgName,
         const css::uno::Reference< css::container::XNameContainer >& xDialogModel );
 
     static css::uno::Reference< css::resource::XStringResourceManager >
@@ -125,12 +129,12 @@ public:
         const css::uno::Reference< css::resource::XStringResourceManager >& xStringResourceManager );
 
     static void copyResourcesForPastedEditorObject( DlgEditor const * pEditor,
-        const css::uno::Any& rControlAny, const OUString& aCtrlName,
+        const css::uno::Any& rControlAny, std::u16string_view aCtrlName,
         const css::uno::Reference< css::resource::XStringResourceResolver >& xSourceStringResolver );
 
     static void copyResourceForDroppedDialog(
         const css::uno::Reference< css::container::XNameContainer >& xDialogModel,
-        const OUString& aDialogName,
+        std::u16string_view aDialogName,
         const css::uno::Reference< css::resource::XStringResourceManager >& xStringResourceManager,
         const css::uno::Reference< css::resource::XStringResourceResolver >& xSourceStringResolver );