loplugin:countusersofdefaultparams in basctl..basic

Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695
Reviewed-on: https://gerrit.libreoffice.org/27793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

11 files changed, 19 insertions, 19 deletions

diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 1a4ad3e4670f..c994910dbd9c 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -778,7 +778,7 @@ void ModulWindow::UpdateData()
 
 sal_Int32 ModulWindow::countPages( Printer* pPrinter )
 {
-    return FormatAndPrint( pPrinter );
+    return FormatAndPrint( pPrinter, -1 );
 }
 
 void ModulWindow::printPage( sal_Int32 nPage, Printer* pPrinter )
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 23d84770aac3..8a04886495c3 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -246,7 +246,7 @@ public:
 
     void            AddWatch( const OUString& rVName );
     void            RemoveSelectedWatch();
-    void            UpdateWatches( bool bBasicStopped = false );
+    void            UpdateWatches( bool bBasicStopped );
 };
 
 
@@ -313,7 +313,7 @@ private:
 
     static void         GoOnTop();
 
-    sal_Int32           FormatAndPrint( Printer* pPrinter, sal_Int32 nPage = -1 );
+    sal_Int32           FormatAndPrint( Printer* pPrinter, sal_Int32 nPage );
     SbModuleRef const & XModule();
 protected:
     virtual void    Resize() override;
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 8c863989fa04..d16fb3576633 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1744,7 +1744,7 @@ void WatchWindow::AddWatch( const OUString& rVName )
     aTreeListBox->MakeVisible(pNewEntry);
     aRemoveWatchButton->Enable();
 
-    UpdateWatches();
+    UpdateWatches(false);
 }
 
 void WatchWindow::RemoveSelectedWatch()
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index 6819a7c13dc6..4546873632e3 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1081,7 +1081,7 @@ void Shell::ManageToolbars()
 
 VclPtr<BaseWindow> Shell::FindApplicationWindow()
 {
-    return FindWindow( ScriptDocument::getApplicationScriptDocument() );
+    return FindWindow( ScriptDocument::getApplicationScriptDocument(), "", "", TYPE_UNKNOWN );
 }
 
 VclPtr<BaseWindow> Shell::FindWindow(
diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index 70b85e4d3307..360b72f492cb 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -254,7 +254,7 @@ void MarkDocumentModified( const ScriptDocument& rDocument )
     {
         if (Shell* pShell = GetShell())
         {
-            pShell->SetAppBasicModified();
+            pShell->SetAppBasicModified(true);
             pShell->UpdateObjectCatalog();
         }
     }
diff --git a/basctl/source/basicide/macrodlg.cxx b/basctl/source/basicide/macrodlg.cxx
index c10aab995af5..aed300eef587 100644
--- a/basctl/source/basicide/macrodlg.cxx
+++ b/basctl/source/basicide/macrodlg.cxx
@@ -366,7 +366,7 @@ SbMethod* MacroChooser::CreateMacro()
         if ( !pModule )
         {
             pModule = createModImpl( static_cast<vcl::Window*>( this ),
-                aDocument, *m_pBasicBox, aLibName, aModName );
+                aDocument, *m_pBasicBox, aLibName, aModName, false );
         }
 
         OUString aSubName = m_pMacroNameEdit->GetText();
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index d3cc32b74012..238bcaa48210 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -262,7 +262,7 @@ public:
 
 // Helper functions
 SbModule* createModImpl( vcl::Window* pWin, const ScriptDocument& rDocument,
-    TreeListBox& rBasicBox, const OUString& rLibName, const OUString& aModName, bool bMain = false );
+    TreeListBox& rBasicBox, const OUString& rLibName, const OUString& aModName, bool bMain );
 void createLibImpl( vcl::Window* pWin, const ScriptDocument& rDocument,
                     CheckBox* pLibBox, TreeListBox* pBasicBox );
 
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index 33c7f8e2549d..0f8edbe22d6f 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -79,7 +79,7 @@ DlgEdObj::DlgEdObj(const OUString& rModelName,
 DlgEdObj::~DlgEdObj()
 {
     if ( isListening() )
-        EndListening();
+        EndListening(true);
 }
 
 void DlgEdObj::SetPage(SdrPage* _pNewPage)
diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index ee3c30f77ec9..43bbd9430dfc 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -185,14 +185,14 @@ public:
     bool                CallBasicErrorHdl( StarBASIC* pBasic );
     long                CallBasicBreakHdl( StarBASIC* pBasic );
 
-    VclPtr<BaseWindow>   FindWindow( const ScriptDocument& rDocument, const OUString& rLibName = OUString(), const OUString& rName = OUString(), ItemType nType = TYPE_UNKNOWN, bool bFindSuspended = false );
+    VclPtr<BaseWindow>   FindWindow( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, ItemType nType, bool bFindSuspended = false );
     VclPtr<DialogWindow> FindDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
     VclPtr<ModulWindow>  FindBasWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rModName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
     VclPtr<BaseWindow>   FindApplicationWindow();
-    bool                 NextPage( bool bPrev = false );
+    bool                 NextPage( bool bPrev );
 
     bool                IsAppBasicModified () const { return m_bAppBasicModified; }
-    void                SetAppBasicModified (bool bModified = true) { m_bAppBasicModified = bModified; }
+    void                SetAppBasicModified (bool bModified) { m_bAppBasicModified = bModified; }
 
     // For Dialog Drag&Drop in Dialog Organizer:
     // (defined in moduldlg.cxx)
diff --git a/basctl/source/inc/bastypes.hxx b/basctl/source/inc/bastypes.hxx
index 9f1c0fa46fdf..98cc41740280 100644
--- a/basctl/source/inc/bastypes.hxx
+++ b/basctl/source/inc/bastypes.hxx
@@ -286,15 +286,15 @@ private:
     Map m_aMap;
 };
 
-void            CutLines( OUString& rStr, sal_Int32 nStartLine, sal_Int32 nLines, bool bEraseTrailingEmptyLines = false );
+void            CutLines( OUString& rStr, sal_Int32 nStartLine, sal_Int32 nLines, bool bEraseTrailingEmptyLines );
 OUString CreateMgrAndLibStr( const OUString& rMgrName, const OUString& rLibName );
 sal_uLong           CalcLineCount( SvStream& rStream );
 
-bool QueryReplaceMacro( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelMacro( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelDialog( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelModule( const OUString& rName, vcl::Window* pParent = nullptr );
-bool QueryDelLib( const OUString& rName, bool bRef = false, vcl::Window* pParent = nullptr );
+bool QueryReplaceMacro( const OUString& rName, vcl::Window* pParent );
+bool QueryDelMacro( const OUString& rName, vcl::Window* pParent );
+bool QueryDelDialog( const OUString& rName, vcl::Window* pParent );
+bool QueryDelModule( const OUString& rName, vcl::Window* pParent );
+bool QueryDelLib( const OUString& rName, bool bRef, vcl::Window* pParent );
 bool QueryPassword( const css::uno::Reference< css::script::XLibraryContainer >& xLibContainer, const OUString& rLibName, OUString& rPassword, bool bRepeat = false, bool bNewTitle = false );
 
 class ModuleInfoHelper
diff --git a/basctl/source/inc/dlgedobj.hxx b/basctl/source/inc/dlgedobj.hxx
index 7d4addf38291..2fe4ca0b9247 100644
--- a/basctl/source/inc/dlgedobj.hxx
+++ b/basctl/source/inc/dlgedobj.hxx
@@ -69,7 +69,7 @@ protected:
     using SfxListener::StartListening;
     void StartListening();
     using SfxListener::EndListening;
-    void    EndListening(bool bRemoveListener = true);
+    void    EndListening(bool bRemoveListener);
     bool    isListening() const { return bIsListening; }
 
     bool TransformSdrToControlCoordinates(