loplugin:constparams in basctl

Change-Id: If6c2b980a2916c4ee8ac108fbb84b006a35f49c5
Reviewed-on: https://gerrit.libreoffice.org/40570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

16 files changed, 43 insertions, 43 deletions

diff --git a/basctl/inc/iderdll.hxx b/basctl/inc/iderdll.hxx
index 83f92f839a3a..0087c915053c 100644
--- a/basctl/inc/iderdll.hxx
+++ b/basctl/inc/iderdll.hxx
@@ -30,7 +30,7 @@ void EnsureIde ();
 
 void ShellCreated (Shell* pShell);
 Shell* GetShell();
-void ShellDestroyed (Shell* pShell);
+void ShellDestroyed (Shell const * pShell);
 
 ExtraData* GetExtraData();
 
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index b3b3c44e23e2..300114d1185f 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -177,7 +177,7 @@ void lcl_ConvertTabsToSpaces( OUString& rLine )
 } // namespace
 
 ModulWindow::ModulWindow (ModulWindowLayout* pParent, ScriptDocument const& rDocument,
-                          const OUString& aLibName, const OUString& aName, OUString& aModule)
+                          const OUString& aLibName, const OUString& aName, OUString const & aModule)
     : BaseWindow(pParent, rDocument, aLibName, aName)
     , m_rLayout(*pParent)
     , m_nValid(ValidWindow)
@@ -587,7 +587,7 @@ void ModulWindow::ManageBreakPoints()
 }
 
 
-bool ModulWindow::BasicErrorHdl( StarBASIC * pBasic )
+bool ModulWindow::BasicErrorHdl( StarBASIC const * pBasic )
 {
     GetShell()->GetViewFrame()->ToTop();
 
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 06539527200b..46d0d4353f59 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -157,7 +157,7 @@ public:
     void            ChangeFontColor( Color aColor );
     void            UpdateSyntaxHighlighting ();
 
-    bool            GetProcedureName(OUString& rLine, OUString& rProcType, OUString& rProcName) const;
+    bool            GetProcedureName(OUString const & rLine, OUString& rProcType, OUString& rProcName) const;
 };
 
 
@@ -322,7 +322,7 @@ protected:
     virtual void    DoScroll( ScrollBar* pCurScrollBar ) override;
 
 public:
-    ModulWindow( ModulWindowLayout* pParent, const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aName, OUString& aModule );
+    ModulWindow( ModulWindowLayout* pParent, const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aName, OUString const & aModule );
 
                     virtual ~ModulWindow() override;
     virtual void    dispose() override;
@@ -361,7 +361,7 @@ public:
     void            UpdateBreakPoint( const BreakPoint& rBrk );
     void            BasicAddWatch();
 
-    bool            BasicErrorHdl( StarBASIC* pBasic );
+    bool            BasicErrorHdl( StarBASIC const * pBasic );
     BasicDebugFlags BasicBreakHdl();
     void            AssertValidEditEngine();
 
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 631ab8a576e8..ef902a174294 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -122,7 +122,7 @@ void setTextEngineText (ExtTextEngine& rEngine, OUString const& aStr)
 namespace
 {
 
-void lcl_DrawIDEWindowFrame(DockingWindow* pWin, vcl::RenderContext& rRenderContext)
+void lcl_DrawIDEWindowFrame(DockingWindow const * pWin, vcl::RenderContext& rRenderContext)
 {
     if (pWin->IsFloatingMode())
         return;
@@ -783,7 +783,7 @@ void EditorWindow::HandleProcedureCompletion()
     }
 }
 
-bool EditorWindow::GetProcedureName(OUString& rLine, OUString& rProcType, OUString& rProcName) const
+bool EditorWindow::GetProcedureName(OUString const & rLine, OUString& rProcType, OUString& rProcName) const
 {
     std::vector<HighlightPortion> aPortions;
     aHighlighter.getHighlightPortions(rLine, aPortions);
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index d1083a607380..5fb85ec7dde4 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1162,7 +1162,7 @@ VclPtr<BaseWindow> Shell::FindWindow(
     return nullptr;
 }
 
-bool Shell::CallBasicErrorHdl( StarBASIC* pBasic )
+bool Shell::CallBasicErrorHdl( StarBASIC const * pBasic )
 {
     bool bRet = false;
     VclPtr<ModulWindow> pModWin = ShowActiveModuleWindow( pBasic );
@@ -1171,7 +1171,7 @@ bool Shell::CallBasicErrorHdl( StarBASIC* pBasic )
     return bRet;
 }
 
-BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC* pBasic )
+BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC const * pBasic )
 {
     BasicDebugFlags nRet = BasicDebugFlags::NONE;
     VclPtr<ModulWindow> pModWin = ShowActiveModuleWindow( pBasic );
@@ -1201,7 +1201,7 @@ BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC* pBasic )
     return nRet;
 }
 
-VclPtr<ModulWindow> Shell::ShowActiveModuleWindow( StarBASIC* pBasic )
+VclPtr<ModulWindow> Shell::ShowActiveModuleWindow( StarBASIC const * pBasic )
 {
     SetCurLib( ScriptDocument::getApplicationScriptDocument(), OUString(), false );
 
diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index 4b4128cab931..00c6ea0a1cf4 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -44,9 +44,9 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::container;
 
 extern "C" {
-    SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void* pPtr )
+    SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void const * pPtr )
     {
-        return HandleBasicError( static_cast<StarBASIC*>(pPtr) );
+        return HandleBasicError( static_cast<StarBASIC const *>(pPtr) );
     }
 }
 
@@ -212,7 +212,7 @@ StarBASIC* FindBasic( const SbxVariable* pVar )
     return const_cast<StarBASIC*>(static_cast<const StarBASIC*>(pSbx));
 }
 
-BasicManager* FindBasicManager( StarBASIC* pLib )
+BasicManager* FindBasicManager( StarBASIC const * pLib )
 {
     ScriptDocuments aDocuments( ScriptDocument::getAllScriptDocuments( ScriptDocument::AllWithApplication ) );
     for (   ScriptDocuments::const_iterator doc = aDocuments.begin();
@@ -263,7 +263,7 @@ void MarkDocumentModified( const ScriptDocument& rDocument )
     }
 }
 
-void RunMethod( SbMethod* pMethod )
+void RunMethod( SbMethod const * pMethod )
 {
     SbxValues aRes;
     aRes.eType = SbxVOID;
@@ -355,7 +355,7 @@ void InvalidateDebuggerSlots()
     }
 }
 
-long HandleBasicError( StarBASIC* pBasic )
+long HandleBasicError( StarBASIC const * pBasic )
 {
     EnsureIde();
     BasicStopped();
diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx
index f85b8ce5a113..beb4be4b54cc 100644
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@@ -581,7 +581,7 @@ void TreeListBox::UpdateEntries()
 }
 
 // Removes the entry from the tree.
-void TreeListBox::RemoveEntry (SvTreeListEntry* pEntry)
+void TreeListBox::RemoveEntry (SvTreeListEntry const * pEntry)
 {
     // removing the associated user data
     delete static_cast<Entry*>(pEntry->GetUserData());
@@ -780,7 +780,7 @@ void TreeListBox::GetRootEntryBitmaps( const ScriptDocument& rDocument, Image& r
     }
 }
 
-void TreeListBox::SetCurrentEntry (EntryDescriptor& rDesc)
+void TreeListBox::SetCurrentEntry (EntryDescriptor const & rDesc)
 {
     SvTreeListEntry* pCurEntry = nullptr;
     EntryDescriptor aDesc = rDesc;
diff --git a/basctl/source/basicide/iderdll.cxx b/basctl/source/basicide/iderdll.cxx
index 0773338a8537..7a2b80ae4c78 100644
--- a/basctl/source/basicide/iderdll.cxx
+++ b/basctl/source/basicide/iderdll.cxx
@@ -91,7 +91,7 @@ void ShellCreated (Shell* pShell)
         pDll->SetShell(pShell);
 }
 
-void ShellDestroyed (Shell* pShell)
+void ShellDestroyed (Shell const * pShell)
 {
     Dll* pDll = theDllInstance::get().get();
     if (pDll && pDll->GetShell() == pShell)
diff --git a/basctl/source/basicide/iderdll2.hxx b/basctl/source/basicide/iderdll2.hxx
index cd2484011039..feb9e0e6b74b 100644
--- a/basctl/source/basicide/iderdll2.hxx
+++ b/basctl/source/basicide/iderdll2.hxx
@@ -57,7 +57,7 @@ public:
     LibInfo&         GetLibInfo () { return aLibInfo; }
 
     EntryDescriptor&  GetLastEntryDescriptor () { return m_aLastEntryDesc; }
-    void              SetLastEntryDescriptor (EntryDescriptor& rDesc) { m_aLastEntryDesc = rDesc; }
+    void              SetLastEntryDescriptor (EntryDescriptor const & rDesc) { m_aLastEntryDesc = rDesc; }
 
     bool&             ChoosingMacro()          { return bChoosingMacro; }
     bool&             ShellInCriticalSection() { return bShellInCriticalSection; }
diff --git a/basctl/source/basicide/localizationmgr.cxx b/basctl/source/basicide/localizationmgr.cxx
index 1af9b1224e33..6150cc70fb8a 100644
--- a/basctl/source/basicide/localizationmgr.cxx
+++ b/basctl/source/basicide/localizationmgr.cxx
@@ -774,7 +774,7 @@ void LocalizationMgr::handleBasicStopped()
 }
 
 
-DialogWindow* FindDialogWindowForEditor( DlgEditor* pEditor )
+DialogWindow* FindDialogWindowForEditor( DlgEditor const * pEditor )
 {
     Shell::WindowTable const& aWindowTable = GetShell()->GetWindowTable();
     for (Shell::WindowTableIt it = aWindowTable.begin(); it != aWindowTable.end(); ++it )
@@ -791,7 +791,7 @@ DialogWindow* FindDialogWindowForEditor( DlgEditor* pEditor )
 }
 
 
-void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor* pEditor,
+void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor const * pEditor,
     const Any& rControlAny, const OUString& aCtrlName )
 {
     // Get library for DlgEditor
@@ -821,7 +821,7 @@ void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor* pEdito
         MarkDocumentModified( aDocument );
 }
 
-void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor* pEditor,
+void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor const * pEditor,
     const css::uno::Any& rControlAny, const OUString& aNewCtrlName )
 {
     // Get library for DlgEditor
@@ -849,7 +849,7 @@ void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor* pEdito
 }
 
 
-void LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject( DlgEditor* pEditor,
+void LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject( DlgEditor const * pEditor,
     const Any& rControlAny, const OUString& aCtrlName )
 {
     // Get library for DlgEditor
@@ -1019,7 +1019,7 @@ void LocalizationMgr::setResourceIDsForDialog( const Reference< container::XName
     }
 }
 
-void LocalizationMgr::copyResourcesForPastedEditorObject( DlgEditor* pEditor,
+void LocalizationMgr::copyResourcesForPastedEditorObject( DlgEditor const * pEditor,
     const Any& rControlAny, const OUString& aCtrlName,
     const Reference< XStringResourceResolver >& xSourceStringResolver )
 {
diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx
index 81b7a6e79868..5fd341d3dc4b 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -306,7 +306,7 @@ void Shell::CopyDialogResources(
     }
 }
 
-TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
+TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry const * pEntry,
                         SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos, bool bMove )
 {
     DBG_ASSERT( pEntry, "No entry?" );   // ASS is ok here, should not be reached
@@ -451,7 +451,7 @@ TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeLi
 
 // OrganizeDialog
 OrganizeDialog::OrganizeDialog(vcl::Window* pParent, sal_Int16 tabId,
-    EntryDescriptor& rDesc )
+    EntryDescriptor const & rDesc )
     : TabDialog( pParent, "OrganizeDialog",
         "modules/BasicIDE/ui/organizedialog.ui" )
     , m_aCurEntry( rDesc )
@@ -597,7 +597,7 @@ void ObjectPage::dispose()
     TabPage::dispose();
 }
 
-void ObjectPage::SetCurrentEntry (EntryDescriptor& rDesc)
+void ObjectPage::SetCurrentEntry (EntryDescriptor const & rDesc)
 {
     m_pBasicBox->SetCurrentEntry( rDesc );
 }
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index 39bd7d8659e2..ee9c90cc2588 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -104,7 +104,7 @@ protected:
                         SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos ) override;
     virtual TriState    NotifyCopying( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
                         SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos ) override;
-    TriState            NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
+    TriState            NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry const * pEntry,
                         SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos, bool bMove );
 
 public:
@@ -168,7 +168,7 @@ private:
     EntryDescriptor    m_aCurEntry;
 
 public:
-    OrganizeDialog( vcl::Window* pParent, sal_Int16 tabId, EntryDescriptor& rDesc );
+    OrganizeDialog( vcl::Window* pParent, sal_Int16 tabId, EntryDescriptor const & rDesc );
     virtual ~OrganizeDialog() override;
     virtual void    dispose() override;
 
@@ -203,7 +203,7 @@ public:
     virtual ~ObjectPage() override;
     virtual void dispose() override;
 
-    void                SetCurrentEntry( EntryDescriptor& rDesc );
+    void                SetCurrentEntry( EntryDescriptor const & rDesc );
     void                SetTabDlg( TabDialog* p ) { pTabDlg = p;}
 };
 
diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index 63117788f8e0..6e5aa6f5185e 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -115,7 +115,7 @@ private:
     VclPtr<ModulWindow>  CreateBasWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rModName );
     VclPtr<DialogWindow> CreateDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rDlgName );
 
-    VclPtr<ModulWindow>  ShowActiveModuleWindow( StarBASIC* pBasic );
+    VclPtr<ModulWindow>  ShowActiveModuleWindow( StarBASIC const * pBasic );
 
     virtual void        Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
 
@@ -176,8 +176,8 @@ public:
 
     virtual bool        HasUIFeature(SfxShellFeature nFeature) const override;
 
-    bool                CallBasicErrorHdl( StarBASIC* pBasic );
-    BasicDebugFlags     CallBasicBreakHdl( StarBASIC* pBasic );
+    bool                CallBasicErrorHdl( StarBASIC const * pBasic );
+    BasicDebugFlags     CallBasicBreakHdl( StarBASIC const * pBasic );
 
     VclPtr<BaseWindow>   FindWindow( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, ItemType nType, bool bFindSuspended = false );
     VclPtr<DialogWindow> FindDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
diff --git a/basctl/source/inc/basobj.hxx b/basctl/source/inc/basobj.hxx
index 8b10c60035ff..8e5e9badc8af 100644
--- a/basctl/source/inc/basobj.hxx
+++ b/basctl/source/inc/basobj.hxx
@@ -39,17 +39,17 @@ namespace basctl
 
     // help methods for the general use:
     SbMethod*       CreateMacro( SbModule* pModule, const OUString& rMacroName );
-    void            RunMethod( SbMethod* pMethod );
+    void            RunMethod( SbMethod const * pMethod );
 
     StarBASIC*      FindBasic( const SbxVariable* pVar );
     void            StopBasic();
-    long            HandleBasicError( StarBASIC* pBasic );
+    long            HandleBasicError( StarBASIC const * pBasic );
     void            BasicStopped( bool* pbAppWindowDisabled = nullptr, bool* pbDispatcherLocked = nullptr, sal_uInt16* pnWaitCount = nullptr,
                             SfxUInt16Item** ppSWActionCount = nullptr, SfxUInt16Item** ppSWLockViewCount = nullptr );
 
     bool            IsValidSbxName( const OUString& rName );
 
-    BasicManager*   FindBasicManager( StarBASIC* pLib );
+    BasicManager*   FindBasicManager( StarBASIC const * pLib );
 
     SfxBindings*    GetBindingsPtr();
 
diff --git a/basctl/source/inc/bastype2.hxx b/basctl/source/inc/bastype2.hxx
index 23c777da6105..262cd0183216 100644
--- a/basctl/source/inc/bastype2.hxx
+++ b/basctl/source/inc/bastype2.hxx
@@ -235,13 +235,13 @@ public:
         SvTreeListEntry* pParent, bool bChildrenOnDemand,
         std::unique_ptr<Entry> && aUserData
     );
-    void            RemoveEntry (SvTreeListEntry*);
+    void            RemoveEntry (SvTreeListEntry const *);
     void            RemoveEntry (ScriptDocument const&);
 
     OUString        GetRootEntryName( const ScriptDocument& rDocument, LibraryLocation eLocation ) const;
     static void     GetRootEntryBitmaps( const ScriptDocument& rDocument, Image& rImage );
 
-    void            SetCurrentEntry (EntryDescriptor&);
+    void            SetCurrentEntry (EntryDescriptor const &);
 
 private:
     LibraryType     GetLibraryType() const;
diff --git a/basctl/source/inc/localizationmgr.hxx b/basctl/source/inc/localizationmgr.hxx
index 15f9bace2f36..906fed0aea40 100644
--- a/basctl/source/inc/localizationmgr.hxx
+++ b/basctl/source/inc/localizationmgr.hxx
@@ -95,13 +95,13 @@ public:
 
     void handleBasicStopped();
 
-    static void setControlResourceIDsForNewEditorObject(DlgEditor* pEditor,
+    static void setControlResourceIDsForNewEditorObject(DlgEditor const * pEditor,
         const css::uno::Any& rControlAny, const OUString& aCtrlName);
 
-    static void renameControlResourceIDsForEditorObject(DlgEditor* pEditor,
+    static void renameControlResourceIDsForEditorObject(DlgEditor const * pEditor,
         const css::uno::Any& rControlAny, const OUString& aNewCtrlName);
 
-    static void deleteControlResourceIDsForDeletedEditorObject(DlgEditor* pEditor,
+    static void deleteControlResourceIDsForDeletedEditorObject(DlgEditor const * pEditor,
         const css::uno::Any& rControlAny, const OUString& aCtrlName);
 
     static void setStringResourceAtDialog( const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aDlgName,
@@ -125,7 +125,7 @@ public:
         const css::uno::Reference< css::container::XNameContainer >& xDialogModel,
         const css::uno::Reference< css::resource::XStringResourceManager >& xStringResourceManager );
 
-    static void copyResourcesForPastedEditorObject( DlgEditor* pEditor,
+    static void copyResourcesForPastedEditorObject( DlgEditor const * pEditor,
         const css::uno::Any& rControlAny, const OUString& aCtrlName,
         const css::uno::Reference< css::resource::XStringResourceResolver >& xSourceStringResolver );