diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-29 14:15:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-29 18:19:37 +0100 |
| commit | 4b030651a0ad5e0eedd6d08b6cd1459ca514d818 (patch) | |
| tree | 5a02580a42d8593c3afc9f39816128562a9cfc6b /basctl | |
| parent | d460842616d467dfaf7b51ac2db94adb1ff5cbb0 (diff) | |
loplugin:passstuffbyref improved return in various
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560
Reviewed-on: https://gerrit.libreoffice.org/47173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basctl')
| -rw-r--r-- | basctl/source/basicide/baside2.hxx | 8 | ||||
| -rw-r--r-- | basctl/source/basicide/baside3.cxx | 2 | ||||
| -rw-r--r-- | basctl/source/inc/baside3.hxx | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx index b2d10b8aa205..1e97b1cf9040 100644 --- a/basctl/source/basicide/baside2.hxx +++ b/basctl/source/basicide/baside2.hxx @@ -420,8 +420,8 @@ public: public: void BasicAddWatch (OUString const&); void BasicRemoveWatch (); - Color GetBackgroundColor () const { return aSyntaxColors.GetBackgroundColor(); } - Color GetFontColor () const { return aSyntaxColors.GetFontColor(); } + Color const & GetBackgroundColor () const { return aSyntaxColors.GetBackgroundColor(); } + Color const & GetFontColor () const { return aSyntaxColors.GetFontColor(); } Color GetSyntaxColor (TokenType eType) const { return aSyntaxColors.GetColor(eType); } protected: @@ -447,8 +447,8 @@ private: public: void SetActiveEditor (EditorWindow* pEditor_) { pEditor = pEditor_; } public: - Color GetBackgroundColor () const { return m_aBackgroundColor; }; - Color GetFontColor () const { return m_aFontColor; } + Color const & GetBackgroundColor () const { return m_aBackgroundColor; }; + Color const & GetFontColor () const { return m_aFontColor; } Color GetColor (TokenType eType) const { return aColors[eType]; } private: diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx index 4ebbadb600d5..5b705b15f2c4 100644 --- a/basctl/source/basicide/baside3.cxx +++ b/basctl/source/basicide/baside3.cxx @@ -564,7 +564,7 @@ void DialogWindow::ExecuteCommand( SfxRequest& rReq ) rReq.Done(); } -Reference< container::XNameContainer > DialogWindow::GetDialog() const +Reference< container::XNameContainer > const & DialogWindow::GetDialog() const { return m_pEditor->GetDialog(); } diff --git a/basctl/source/inc/baside3.hxx b/basctl/source/inc/baside3.hxx index ae09f3cecc0c..5062e8050751 100644 --- a/basctl/source/inc/baside3.hxx +++ b/basctl/source/inc/baside3.hxx @@ -84,7 +84,7 @@ public: virtual void ExecuteCommand( SfxRequest& rReq ) override; virtual void GetState( SfxItemSet& ) override; DlgEditor& GetEditor() const { return *m_pEditor; } - css::uno::Reference< css::container::XNameContainer > GetDialog() const; + css::uno::Reference< css::container::XNameContainer > const & GetDialog() const; DlgEdModel& GetModel() const; DlgEdPage& GetPage() const; DlgEdView& GetView() const; |